mirror of
https://github.com/affaan-m/ECC.git
synced 2026-09-23 18:15:13 +02:00
feat(install): require an explicit hook decision at the apply layer
The guided installer asks how ECC hooks should run, but that consent lived only in the wizard path. Running install-apply directly with a profile that includes hooks-runtime still materialized the hook runtime with no disclosure and no decision. Gate the apply layer instead, so every entry point is covered: - disclose the six hook capability groups when a plan would materialize the hook runtime, and refuse to apply until the caller decides - --enable-hooks confirms the hook runtime; --no-hooks installs the rest of the selection without it and records the reduced module closure in install-state - surface the pending decision as a dry-run warning - show the same capability disclosure in the guided installer's plan preview, so the wizard's hook question states what it is asking about Plans that never materialize hooks (Kimi, --profile minimal, --without baseline:hooks) are unaffected and need no flag. Repair and uninstall operate on already-recorded state and stay unchanged. The capability taxonomy and the held-materialization behavior come from Samarjeet Singh Tomar's PR #2634, reworked to fit the single-decision consent model that shipped with the guided installer in #2649. Co-Authored-By: Samarjeet Singh Tomar <samar_tomar@hotmail.com> Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
co-authored by
Samarjeet Singh Tomar
Claude Fable 5
parent
a89cec9658
commit
6aaa41e028
@@ -16,6 +16,7 @@ const {
|
||||
createMultiHarnessPlan,
|
||||
normalizeGuidedInstallRequest,
|
||||
} = require('./lib/multi-harness-setup');
|
||||
const { formatHookCapabilityDisclosure } = require('./lib/install/hook-consent');
|
||||
const { startTerminalSpinner } = require('./lib/terminal-spinner');
|
||||
const { showTerminalWelcome } = require('./lib/terminal-welcome');
|
||||
const { stripAnsi } = require('./lib/utils');
|
||||
@@ -209,6 +210,13 @@ function printPlan(plan, output) {
|
||||
if (plan.request.harnesses.includes('kimi')) {
|
||||
output.write('\nKimi note: ECC hooks are not configured; model, provider, and authentication settings are unchanged.\n');
|
||||
}
|
||||
if (plan.request.harnesses.includes('claude') && plan.request.claudeHooks && plan.request.claudeHooks !== 'off') {
|
||||
output.write(
|
||||
`\nClaude hook profile '${plan.request.claudeHooks}' enables automation that can:\n`
|
||||
+ `${formatHookCapabilityDisclosure()}\n`
|
||||
+ "Choose '--claude-hooks off' to install without automatic hook behavior.\n"
|
||||
);
|
||||
}
|
||||
}
|
||||
|
||||
async function confirmPlan(terminal, output) {
|
||||
|
||||
Reference in New Issue
Block a user