WEBDIENSTE/ECC
1
0
Fork 0
mirror of https://github.com/affaan-m/ECC.git synced 2026-10-20 06:51:44 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix(ci): flag CLAUDE_PROJECT_DIR in skill fences with Codex rewrite guidance

Browse Source
This commit is contained in:
Matt Van Horn
2026-09-25 06:44:12 -07:00
parent 9c45149bae
commit da5757b6ff
5 changed files with 98 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
scripts/ci/validate-skill-host-compat.js
+14 -2
View File
@@ -5,7 +5,9 @@
* Checks:
* 1. Claude-only substitutions in executable bash/sh/zsh fences
* (${CLAUDE_SESSION_ID}, ${CLAUDE_SKILL_DIR}, ${CLAUDE_PLUGIN_ROOT},
* $ARGUMENTS). Codex and a bare shell leave those tokens literal.
* ${CLAUDE_PROJECT_DIR}, $ARGUMENTS). Codex and a bare shell leave
* those tokens literal. Rewrite ${CLAUDE_PROJECT_DIR} in Codex copies
* to $(pwd) or an explicit path.
* 2. Codex-copy frontmatter allowlist on .agents/skills/<name>/SKILL.md
* (name, description, metadata, license, allowed-tools). origin/version
* may remain on the canonical skills/ copy.
@@ -47,6 +49,8 @@ const CLAUDE_SUBSTITUTION_PATTERNS = [
{ token: '$CLAUDE_SKILL_DIR', regex: /\$CLAUDE_SKILL_DIR\b/g },
{ token: '${CLAUDE_PLUGIN_ROOT}', regex: /\$\{CLAUDE_PLUGIN_ROOT\}/g },
{ token: '$CLAUDE_PLUGIN_ROOT', regex: /\$CLAUDE_PLUGIN_ROOT\b/g },
{ token: '${CLAUDE_PROJECT_DIR}', regex: /\$\{CLAUDE_PROJECT_DIR\}/g },
{ token: '$CLAUDE_PROJECT_DIR', regex: /\$CLAUDE_PROJECT_DIR\b/g },
{ token: '$ARGUMENTS', regex: /\$ARGUMENTS\b|\$\{ARGUMENTS\}/g },
// Claude skill form ${1}. Bare $1 is handled in findSubstitutionTokens so
// POSIX `VAR=$1` and Perl/awk `$1 < 80` are not treated as Claude args.
@@ -231,6 +235,14 @@ function pushFinding(findings, finding) {
findings.push(finding);
}
function substitutionMessage(skillName, fenceLang, token) {
const base = `${relSkillMd(skillName)} - ${fenceLang} fence contains Claude-only substitution ${token}`;
if (token === '${CLAUDE_PROJECT_DIR}' || token === '$CLAUDE_PROJECT_DIR') {
return `${base}; rewrite to $(pwd) or an explicit path`;
}
return base;
}
function inspectCanonicalSkill(skillName, content, findings) {
const { frontmatter, body } = stripFrontmatter(content);
const values = frontmatter.present ? inspectFrontmatter(frontmatter.lines).values : {};
@@ -289,7 +301,7 @@ function inspectCanonicalSkill(skillName, content, findings) {
code: 'substitution',
skill: skillName,
token,
message: `${relSkillMd(skillName)} - ${fence.lang} fence contains Claude-only substitution ${token}`,
message: substitutionMessage(skillName, fence.lang, token),
});
}
}