mirror of https://github.com/affaan-m/ECC.git synced 2026-08-20 06:25:43 +02:00

Files

T

haelyraandGitHub 569b1d5b32 fix: disable Claude co-author attribution by default (#2758 )

* fix: disable Claude co-author attribution by default

* fix: harden default co-author opt-out and correct the docs

Follow-up on the co-author default in this PR.

- Remove the existsSync/writeFileSync race in the installer settings write
  (CodeQL js/file-system-race, high). A single guarded read now covers the
  fresh-install case, and unreadable or non-object settings are left untouched.
- Respect `attribution` as an explicit user choice. It supersedes
  `includeCoAuthoredBy` in Claude Code 2.1.x, so a user who configured it would
  otherwise have had a dead key written into their settings.
- Share one opt-out rule via scripts/lib/claude-commit-attribution.js instead of
  duplicating it across the installer and plugin setup.
- Update the git-workflow rule and its nine mirrors and translations, which
  still told users ECC does not ship this setting.

We keep writing the deprecated `includeCoAuthoredBy` key rather than
`attribution`: unknown keys fail Claude Code settings validation, so writing
`attribution` would break users on older versions.

2026-08-12 00:43:58 -04:00

1008 B

Raw Permalink Blame History

Flujo de Trabajo con Git

Formato de Mensajes de Commit

<tipo>: <descripción>

<cuerpo opcional>

Tipos: feat, fix, refactor, docs, test, chore, perf, ci

Nota: Las instalaciones gestionadas por ECC configuran "includeCoAuthoredBy": false en ~/.claude/settings.json, por lo que los commits no incluyen Co-Authored-By de forma predeterminada. Para conservar la atribución de Claude, configure "includeCoAuthoredBy": true o attribution; ECC nunca sobrescribe una elección explícita.

Flujo de Trabajo de Pull Request

Al crear PRs:

Analizar el historial completo de commits (no solo el último commit)
Usar git diff [base-branch]...HEAD para ver todos los cambios
Redactar un resumen completo del PR
Incluir plan de pruebas con TODOs
Hacer push con la flag -u si es un branch nuevo

Para el proceso completo de desarrollo (planificación, TDD, revisión de código) antes de las operaciones de git, ver development-workflow.md.

1008 B Raw Permalink Blame History

Flujo de Trabajo con Git

Formato de Mensajes de Commit

Flujo de Trabajo de Pull Request

1008 B

Raw Permalink Blame History