ECC/tests/lib/agent-data-home.test.js

/**
 * Tests for scripts/lib/agent-data-home.js
 *
 * Run with: node tests/lib/agent-data-home.test.js
 *
 * Cwd / project context: many cases use `withIsolatedCwd()` (empty temp dir, no
 * `.cursor/`) so results do not depend on running inside a dogfooded ECC repo.
 * When this repo has `.cursor/ecc-agent-data.json` installed, `resolveAgentDataHome()`
 * from the real project root intentionally resolves to `~/.cursor/ecc` — see the
 * dedicated test below; do not expect `~/.claude` while cwd is the ECC tree.
 */

const assert = require('assert');
const fs = require('fs');
const os = require('os');
const path = require('path');

function test(name, fn) {
  try {
    fn();
    console.log(`  ✓ ${name}`);
    return true;
  } catch (error) {
    console.log(`  ✗ ${name}`);
    console.log(`    Error: ${error.message}`);
    return false;
  }
}

function withEnv(overrides, fn) {
  const previous = {};
  for (const key of Object.keys(overrides)) {
    previous[key] = process.env[key];
    if (overrides[key] === undefined) {
      delete process.env[key];
    } else {
      process.env[key] = overrides[key];
    }
  }

  try {
    fn();
  } finally {
    for (const key of Object.keys(previous)) {
      if (previous[key] === undefined) {
        delete process.env[key];
      } else {
        process.env[key] = previous[key];
      }
    }
    delete require.cache[require.resolve('../../scripts/lib/agent-data-home')];
  }
}

/**
 * Run fn with cwd in an empty directory (no .cursor/) so resolveProjectDir() does
 * not pick up the ECC repo's installed agent-data config.
 */
function withIsolatedCwd(fn) {
  const isolatedDir = fs.mkdtempSync(path.join(os.tmpdir(), 'ecc-agent-data-home-'));
  const originalCwd = process.cwd();
  try {
    process.chdir(isolatedDir);
    return fn(isolatedDir);
  } finally {
    process.chdir(originalCwd);
    fs.rmSync(isolatedDir, { recursive: true, force: true });
  }
}

function captureConsoleErrors(fn) {
  const originalError = console.error;
  const messages = [];
  console.error = (...args) => {
    messages.push(args.join(' '));
  };

  try {
    return { result: fn(), messages };
  } finally {
    console.error = originalError;
  }
}

function runTests() {
  console.log('\n=== Testing agent-data-home.js ===\n');
  let passed = 0;
  let failed = 0;

  if (test('defaults to ~/.claude outside Cursor (isolated cwd)', () => {
    withIsolatedCwd(() => {
      withEnv({
        ECC_AGENT_DATA_HOME: undefined,
        CURSOR_VERSION: undefined,
        CURSOR_PROJECT_DIR: undefined,
      }, () => {
        const agentDataHome = require('../../scripts/lib/agent-data-home');
        const home = os.homedir();
        assert.strictEqual(
          agentDataHome.resolveAgentDataHome(),
          path.join(home, '.claude')
        );
      });
    });
  })) passed++; else failed++;

  if (test('resolveAgentDataHome uses projectDir + .cursor/ecc-agent-data.json', () => {
    const projectDir = fs.mkdtempSync(path.join(os.tmpdir(), 'ecc-agent-data-home-project-'));
    const cursorDir = path.join(projectDir, '.cursor');
    fs.mkdirSync(cursorDir, { recursive: true });
    fs.writeFileSync(
      path.join(cursorDir, 'ecc-agent-data.json'),
      JSON.stringify({ agentDataHome: '~/.cursor/ecc' }),
      'utf8'
    );

    try {
      withIsolatedCwd(() => {
        withEnv({
          ECC_AGENT_DATA_HOME: undefined,
          CURSOR_VERSION: undefined,
          CURSOR_PROJECT_DIR: undefined,
        }, () => {
          const agentDataHome = require('../../scripts/lib/agent-data-home');
          assert.strictEqual(
            agentDataHome.resolveAgentDataHome({ projectDir }),
            path.join(os.homedir(), '.cursor', 'ecc')
          );
        });
      });
    } finally {
      fs.rmSync(projectDir, { recursive: true, force: true });
    }
  })) passed++; else failed++;

  if (test('defaults to ~/.cursor/ecc in Cursor hook runtime (isolated cwd)', () => {
    withIsolatedCwd(() => {
      withEnv({
        ECC_AGENT_DATA_HOME: undefined,
        CURSOR_VERSION: '1.0.0',
        CURSOR_PROJECT_DIR: undefined,
      }, () => {
        const agentDataHome = require('../../scripts/lib/agent-data-home');
        const home = os.homedir();
        assert.strictEqual(
          agentDataHome.resolveAgentDataHome(),
          path.join(home, '.cursor', 'ecc')
        );
      });
    });
  })) passed++; else failed++;

  if (test('honors ECC_AGENT_DATA_HOME over Cursor default', () => {
    const override = path.join(os.tmpdir(), `ecc-override-${Date.now()}`);
    withEnv({
      ECC_AGENT_DATA_HOME: override,
      CURSOR_VERSION: '1.0.0',
    }, () => {
      const agentDataHome = require('../../scripts/lib/agent-data-home');
      assert.strictEqual(agentDataHome.resolveAgentDataHome(), path.resolve(override));
    });
  })) passed++; else failed++;

  if (test('reads project ecc-agent-data.json config file', () => {
    const tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), 'ecc-agent-data-home-read-'));
    const homeDir = fs.mkdtempSync(path.join(os.tmpdir(), 'ecc-agent-data-home-user-'));
    const configPath = path.join(tmpDir, '.cursor', 'ecc-agent-data.json');
    const customHome = path.join(homeDir, '.cursor', 'ecc', 'custom');
    fs.mkdirSync(path.dirname(configPath), { recursive: true });
    fs.writeFileSync(
      configPath,
      JSON.stringify({ agentDataHome: customHome }),
      'utf8'
    );

    try {
      withEnv({
        ECC_AGENT_DATA_HOME: undefined,
        CURSOR_VERSION: undefined,
        HOME: homeDir,
        USERPROFILE: undefined,
      }, () => {
        const agentDataHome = require('../../scripts/lib/agent-data-home');
        assert.strictEqual(
          agentDataHome.readProjectConfigAt(configPath),
          path.join(fs.realpathSync(homeDir), '.cursor', 'ecc', 'custom')
        );
      });
    } finally {
      fs.rmSync(tmpDir, { recursive: true, force: true });
      fs.rmSync(homeDir, { recursive: true, force: true });
    }
  })) passed++; else failed++;

  if (test('allows the documented ~/.claude project sharing root and its descendants', () => {
    const projectDir = fs.mkdtempSync(path.join(os.tmpdir(), 'ecc-agent-data-home-claude-'));
    const homeDir = fs.mkdtempSync(path.join(os.tmpdir(), 'ecc-agent-data-home-claude-user-'));
    const configPath = path.join(projectDir, '.cursor', 'ecc-agent-data.json');
    fs.mkdirSync(path.dirname(configPath), { recursive: true });
    fs.mkdirSync(path.join(homeDir, '.claude'), { recursive: true });

    try {
      withEnv({
        ECC_AGENT_DATA_HOME: undefined,
        HOME: homeDir,
        USERPROFILE: undefined,
      }, () => {
        const agentDataHome = require('../../scripts/lib/agent-data-home');
        const cases = [
          {
            candidate: '~/.claude',
            expected: path.join(fs.realpathSync(homeDir), '.claude'),
          },
          {
            candidate: '~/.claude/shared',
            expected: path.join(fs.realpathSync(homeDir), '.claude', 'shared'),
          },
        ];

        for (const { candidate, expected } of cases) {
          fs.writeFileSync(
            configPath,
            JSON.stringify({ agentDataHome: candidate }),
            'utf8'
          );
          assert.strictEqual(
            agentDataHome.readProjectConfigAt(configPath),
            expected
          );
        }
      });
    } finally {
      fs.rmSync(projectDir, { recursive: true, force: true });
      fs.rmSync(homeDir, { recursive: true, force: true });
    }
  })) passed++; else failed++;

  if (test('rejects a relative agentDataHome that redirects into the project', () => {
    const stamp = Date.now();
    const projectDir = path.join(os.tmpdir(), `ecc-agent-data-home-relative-${stamp}`);
    const cursorDir = path.join(projectDir, '.cursor');
    const otherCwd = path.join(os.tmpdir(), `ecc-agent-data-home-other-cwd-${stamp}`);
    const homeDir = path.join(os.tmpdir(), `ecc-agent-data-home-relative-user-${stamp}`);
    fs.mkdirSync(cursorDir, { recursive: true });
    fs.mkdirSync(otherCwd, { recursive: true });
    fs.mkdirSync(homeDir, { recursive: true });
    const configPath = path.join(cursorDir, 'ecc-agent-data.json');
    fs.writeFileSync(
      configPath,
      JSON.stringify({ agentDataHome: '.ecc-data' }),
      'utf8'
    );

    const originalCwd = process.cwd();
    try {
      process.chdir(otherCwd);
      withEnv({
        ECC_AGENT_DATA_HOME: undefined,
        CURSOR_VERSION: undefined,
        CURSOR_PROJECT_DIR: projectDir,
        HOME: homeDir,
        USERPROFILE: undefined,
      }, () => {
        const agentDataHome = require('../../scripts/lib/agent-data-home');
        const { result, messages } = captureConsoleErrors(
          () => agentDataHome.readProjectConfigAt(configPath)
        );
        assert.strictEqual(result, null);
        assert.ok(messages.some(message => message.includes('Ignoring unsafe agent data project config')));
        assert.ok(messages.every(message => !message.includes('.ecc-data')));
        assert.strictEqual(
          captureConsoleErrors(
            () => agentDataHome.resolveAgentDataHome({ projectDir, preferCursorDefault: true })
          ).result,
          path.join(homeDir, '.cursor', 'ecc')
        );
      });
    } finally {
      process.chdir(originalCwd);
      fs.rmSync(projectDir, { recursive: true, force: true });
      fs.rmSync(otherCwd, { recursive: true, force: true });
      fs.rmSync(homeDir, { recursive: true, force: true });
    }
  })) passed++; else failed++;

  if (test('rejects relative project config paths even when the project is beneath the trusted root', () => {
    const homeDir = fs.mkdtempSync(path.join(os.tmpdir(), 'ecc-agent-data-home-nested-user-'));
    const projectDir = path.join(homeDir, '.cursor', 'ecc', 'checked-out-project');
    const configPath = path.join(projectDir, '.cursor', 'ecc-agent-data.json');
    const candidate = '.repo-data';
    fs.mkdirSync(path.dirname(configPath), { recursive: true });
    fs.writeFileSync(configPath, JSON.stringify({ agentDataHome: candidate }), 'utf8');

    try {
      withEnv({
        ECC_AGENT_DATA_HOME: undefined,
        HOME: homeDir,
        USERPROFILE: undefined,
      }, () => {
        const agentDataHome = require('../../scripts/lib/agent-data-home');
        const { result, messages } = captureConsoleErrors(
          () => agentDataHome.readProjectConfigAt(configPath)
        );
        assert.strictEqual(result, null);
        assert.ok(messages.some(message => message.includes('Ignoring unsafe agent data project config')));
        assert.ok(messages.every(message => !message.includes(candidate)));
      });
    } finally {
      fs.rmSync(homeDir, { recursive: true, force: true });
    }
  })) passed++; else failed++;

  if (test('rejects traversal and absolute project config paths outside the allowed data roots', () => {
    const projectDir = fs.mkdtempSync(path.join(os.tmpdir(), 'ecc-agent-data-home-unsafe-'));
    const homeDir = fs.mkdtempSync(path.join(os.tmpdir(), 'ecc-agent-data-home-unsafe-user-'));
    const configPath = path.join(projectDir, '.cursor', 'ecc-agent-data.json');
    fs.mkdirSync(path.dirname(configPath), { recursive: true });

    try {
      withEnv({
        ECC_AGENT_DATA_HOME: undefined,
        HOME: homeDir,
        USERPROFILE: undefined,
      }, () => {
        const agentDataHome = require('../../scripts/lib/agent-data-home');
        const unsafeCandidates = [
          '../../repo-data',
          path.join(projectDir, 'absolute-data'),
          '~/.cursor/ecc/profiles/../traversed-data',
          '~/.claude/profiles/../traversed-data',
          '~/.claude-other',
          '~/.config/ecc',
          '~',
          path.join(homeDir, 'arbitrary-agent-data'),
        ];
        for (const candidate of unsafeCandidates) {
          fs.writeFileSync(configPath, JSON.stringify({ agentDataHome: candidate }), 'utf8');
          const { result, messages } = captureConsoleErrors(
            () => agentDataHome.readProjectConfigAt(configPath)
          );
          assert.strictEqual(result, null);
          assert.ok(messages.some(message => message.includes('Ignoring unsafe agent data project config')));
          assert.ok(messages.every(message => !message.includes(candidate)));
        }
      });
    } finally {
      fs.rmSync(projectDir, { recursive: true, force: true });
      fs.rmSync(homeDir, { recursive: true, force: true });
    }
  })) passed++; else failed++;

  if (test('rejects a Claude project config destination that escapes through a symlink', () => {
    const projectDir = fs.mkdtempSync(path.join(os.tmpdir(), 'ecc-agent-data-home-claude-link-'));
    const homeDir = fs.mkdtempSync(path.join(os.tmpdir(), 'ecc-agent-data-home-claude-link-user-'));
    const outsideDir = fs.mkdtempSync(path.join(os.tmpdir(), 'ecc-agent-data-home-claude-link-outside-'));
    const configPath = path.join(projectDir, '.cursor', 'ecc-agent-data.json');
    const claudeRoot = path.join(homeDir, '.claude');
    const linkPath = path.join(claudeRoot, 'redirect');
    fs.mkdirSync(path.dirname(configPath), { recursive: true });
    fs.mkdirSync(claudeRoot, { recursive: true });

    try {
      try {
        fs.symlinkSync(outsideDir, linkPath, 'dir');
      } catch {
        console.log('    (symlink unsupported on this platform; skipping)');
        return;
      }
      const candidate = path.join(linkPath, 'session-data');
      fs.writeFileSync(configPath, JSON.stringify({ agentDataHome: candidate }), 'utf8');

      withEnv({
        ECC_AGENT_DATA_HOME: undefined,
        HOME: homeDir,
        USERPROFILE: undefined,
      }, () => {
        const agentDataHome = require('../../scripts/lib/agent-data-home');
        const { result, messages } = captureConsoleErrors(
          () => agentDataHome.readProjectConfigAt(configPath)
        );
        assert.strictEqual(result, null);
        assert.ok(messages.some(message => message.includes('Ignoring unsafe agent data project config')));
        assert.ok(messages.every(message => !message.includes(candidate)));
      });
    } finally {
      fs.rmSync(projectDir, { recursive: true, force: true });
      fs.rmSync(homeDir, { recursive: true, force: true });
      fs.rmSync(outsideDir, { recursive: true, force: true });
    }
  })) passed++; else failed++;

  if (test('allows a non-existent project config destination beneath the Cursor data root', () => {
    const projectDir = fs.mkdtempSync(path.join(os.tmpdir(), 'ecc-agent-data-home-safe-'));
    const homeDir = fs.mkdtempSync(path.join(os.tmpdir(), 'ecc-agent-data-home-safe-user-'));
    const configPath = path.join(projectDir, '.cursor', 'ecc-agent-data.json');
    const safeHome = path.join(homeDir, '.cursor', 'ecc', 'profiles', 'work');
    fs.mkdirSync(path.dirname(configPath), { recursive: true });
    fs.writeFileSync(configPath, JSON.stringify({ agentDataHome: safeHome }), 'utf8');

    try {
      withEnv({
        ECC_AGENT_DATA_HOME: undefined,
        HOME: homeDir,
        USERPROFILE: undefined,
      }, () => {
        const agentDataHome = require('../../scripts/lib/agent-data-home');
        assert.strictEqual(
          agentDataHome.readProjectConfigAt(configPath),
          path.join(fs.realpathSync(homeDir), '.cursor', 'ecc', 'profiles', 'work')
        );
      });
    } finally {
      fs.rmSync(projectDir, { recursive: true, force: true });
      fs.rmSync(homeDir, { recursive: true, force: true });
    }
  })) passed++; else failed++;

  if (test('rejects a project config destination that escapes through a symlink', () => {
    const projectDir = fs.mkdtempSync(path.join(os.tmpdir(), 'ecc-agent-data-home-link-'));
    const homeDir = fs.mkdtempSync(path.join(os.tmpdir(), 'ecc-agent-data-home-link-user-'));
    const outsideDir = fs.mkdtempSync(path.join(os.tmpdir(), 'ecc-agent-data-home-link-outside-'));
    const configPath = path.join(projectDir, '.cursor', 'ecc-agent-data.json');
    const cursorRoot = path.join(homeDir, '.cursor', 'ecc');
    const linkPath = path.join(cursorRoot, 'redirect');
    fs.mkdirSync(path.dirname(configPath), { recursive: true });
    fs.mkdirSync(cursorRoot, { recursive: true });

    try {
      try {
        fs.symlinkSync(outsideDir, linkPath, 'dir');
      } catch {
        console.log('    (symlink unsupported on this platform; skipping)');
        return;
      }
      const candidate = path.join(linkPath, 'session-data');
      fs.writeFileSync(configPath, JSON.stringify({ agentDataHome: candidate }), 'utf8');

      withEnv({
        ECC_AGENT_DATA_HOME: undefined,
        HOME: homeDir,
        USERPROFILE: undefined,
      }, () => {
        const agentDataHome = require('../../scripts/lib/agent-data-home');
        const { result, messages } = captureConsoleErrors(
          () => agentDataHome.readProjectConfigAt(configPath)
        );
        assert.strictEqual(result, null);
        assert.ok(messages.some(message => message.includes('Ignoring unsafe agent data project config')));
        assert.ok(messages.every(message => !message.includes(candidate)));
      });
    } finally {
      fs.rmSync(projectDir, { recursive: true, force: true });
      fs.rmSync(homeDir, { recursive: true, force: true });
      fs.rmSync(outsideDir, { recursive: true, force: true });
    }
  })) passed++; else failed++;

  if (test('readProjectConfigAt logs parse failures', () => {
    const tmpDir = path.join(os.tmpdir(), `ecc-agent-data-home-log-${Date.now()}`);
    fs.mkdirSync(tmpDir, { recursive: true });
    const configPath = path.join(tmpDir, 'ecc-agent-data.json');
    fs.writeFileSync(configPath, '{ invalid json', 'utf8');

    const originalError = console.error;
    const messages = [];
    console.error = (...args) => {
      messages.push(args.join(' '));
    };

    try {
      withEnv({
        ECC_AGENT_DATA_HOME: undefined,
        CURSOR_VERSION: undefined,
      }, () => {
        const agentDataHome = require('../../scripts/lib/agent-data-home');
        assert.strictEqual(agentDataHome.readProjectConfigAt(configPath), null);
        assert.ok(
          messages.some(message => message.includes(configPath)),
          'Expected config path in error log'
        );
      });
    } finally {
      console.error = originalError;
      fs.rmSync(tmpDir, { recursive: true, force: true });
    }
  })) passed++; else failed++;

  if (test('ensureAgentDataHomeEnv sets process.env when unset', () => {
    withEnv({
      ECC_AGENT_DATA_HOME: undefined,
      CURSOR_VERSION: '1.0.0',
    }, () => {
      const agentDataHome = require('../../scripts/lib/agent-data-home');
      const resolved = agentDataHome.ensureAgentDataHomeEnv();
      assert.ok(process.env.ECC_AGENT_DATA_HOME);
      assert.strictEqual(process.env.ECC_AGENT_DATA_HOME, resolved);
    });
  })) passed++; else failed++;

  console.log(`\n=== Test Results ===\nPassed: ${passed}\nFailed: ${failed}\n`);
  if (failed > 0) process.exit(1);
}

runTests();