mirror of
https://github.com/affaan-m/ECC.git
synced 2026-08-31 12:19:37 +02:00
6aaa41e028
The guided installer asks how ECC hooks should run, but that consent lived only in the wizard path. Running install-apply directly with a profile that includes hooks-runtime still materialized the hook runtime with no disclosure and no decision. Gate the apply layer instead, so every entry point is covered: - disclose the six hook capability groups when a plan would materialize the hook runtime, and refuse to apply until the caller decides - --enable-hooks confirms the hook runtime; --no-hooks installs the rest of the selection without it and records the reduced module closure in install-state - surface the pending decision as a dry-run warning - show the same capability disclosure in the guided installer's plan preview, so the wizard's hook question states what it is asking about Plans that never materialize hooks (Kimi, --profile minimal, --without baseline:hooks) are unaffected and need no flag. Repair and uninstall operate on already-recorded state and stay unchanged. The capability taxonomy and the held-materialization behavior come from Samarjeet Singh Tomar's PR #2634, reworked to fit the single-decision consent model that shipped with the guided installer in #2649. Co-Authored-By: Samarjeet Singh Tomar <samar_tomar@hotmail.com> Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
72 lines
2.5 KiB
JavaScript
72 lines
2.5 KiB
JavaScript
/**
|
|
* Regression coverage for supported manual Claude hook installation guidance.
|
|
*/
|
|
|
|
const assert = require('assert');
|
|
const fs = require('fs');
|
|
const path = require('path');
|
|
|
|
const README = path.join(__dirname, '..', '..', 'README.md');
|
|
const HOOKS_README = path.join(__dirname, '..', '..', 'hooks', 'README.md');
|
|
|
|
function test(name, fn) {
|
|
try {
|
|
fn();
|
|
console.log(` \u2713 ${name}`);
|
|
return true;
|
|
} catch (error) {
|
|
console.log(` \u2717 ${name}`);
|
|
console.log(` Error: ${error.message}`);
|
|
return false;
|
|
}
|
|
}
|
|
|
|
function runTests() {
|
|
console.log('\n=== Testing manual hook install docs ===\n');
|
|
|
|
let passed = 0;
|
|
let failed = 0;
|
|
|
|
const readme = fs.readFileSync(README, 'utf8');
|
|
const hooksReadme = fs.readFileSync(HOOKS_README, 'utf8');
|
|
|
|
if (test('README warns against raw hook file copying', () => {
|
|
assert.ok(
|
|
readme.includes('Do not copy the raw repo `hooks/hooks.json` into `~/.claude/settings.json` or `~/.claude/hooks/hooks.json`'),
|
|
'README should warn against unsupported raw hook copying'
|
|
);
|
|
assert.ok(
|
|
readme.includes('bash ./install.sh --target claude --modules hooks-runtime --enable-hooks'),
|
|
'README should document the supported Bash hook install path'
|
|
);
|
|
assert.ok(
|
|
readme.includes('pwsh -File .\\install.ps1 --target claude --modules hooks-runtime --enable-hooks'),
|
|
'README should document the supported PowerShell hook install path'
|
|
);
|
|
assert.ok(
|
|
readme.includes('%USERPROFILE%\\\\.claude'),
|
|
'README should call out the correct Windows Claude config root'
|
|
);
|
|
})) passed++; else failed++;
|
|
|
|
if (test('hooks/README mirrors supported manual install guidance', () => {
|
|
assert.ok(
|
|
hooksReadme.includes('do not paste the raw repo `hooks.json` into `~/.claude/settings.json` or copy it directly into `~/.claude/hooks/hooks.json`'),
|
|
'hooks/README should warn against unsupported raw hook copying'
|
|
);
|
|
assert.ok(
|
|
hooksReadme.includes('bash ./install.sh --target claude --modules hooks-runtime --enable-hooks'),
|
|
'hooks/README should document the supported Bash hook install path'
|
|
);
|
|
assert.ok(
|
|
hooksReadme.includes('pwsh -File .\\install.ps1 --target claude --modules hooks-runtime --enable-hooks'),
|
|
'hooks/README should document the supported PowerShell hook install path'
|
|
);
|
|
})) passed++; else failed++;
|
|
|
|
console.log(`\nResults: Passed: ${passed}, Failed: ${failed}`);
|
|
process.exit(failed > 0 ? 1 : 0);
|
|
}
|
|
|
|
runTests();
|