mirror of https://github.com/affaan-m/ECC.git synced 2026-08-17 21:15:40 +02:00

Files

T

haelyraandGitHub 569b1d5b32 fix: disable Claude co-author attribution by default (#2758 )

* fix: disable Claude co-author attribution by default

* fix: harden default co-author opt-out and correct the docs

Follow-up on the co-author default in this PR.

- Remove the existsSync/writeFileSync race in the installer settings write
  (CodeQL js/file-system-race, high). A single guarded read now covers the
  fresh-install case, and unreadable or non-object settings are left untouched.
- Respect `attribution` as an explicit user choice. It supersedes
  `includeCoAuthoredBy` in Claude Code 2.1.x, so a user who configured it would
  otherwise have had a dead key written into their settings.
- Share one opt-out rule via scripts/lib/claude-commit-attribution.js instead of
  duplicating it across the installer and plugin setup.
- Update the git-workflow rule and its nine mirrors and translations, which
  still told users ECC does not ship this setting.

We keep writing the deprecated `includeCoAuthoredBy` key rather than
`attribution`: unknown keys fail Claude Code settings validation, so writing
`attribution` would break users on older versions.

2026-08-12 00:43:58 -04:00

988 B

Raw Blame History

Git 워크플로우

커밋 메시지 형식

<type>: <description>

<선택적 본문>

타입: feat, fix, refactor, docs, test, chore, perf, ci

참고: ECC가 관리하는 설치는 ~/.claude/settings.json에 "includeCoAuthoredBy": false를 설정하므로 커밋에 기본적으로 Co-Authored-By가 붙지 않습니다. Claude 표기를 유지하려면 "includeCoAuthoredBy": true를 설정하거나 attribution을 구성하세요. ECC는 명시적인 선택을 덮어쓰지 않습니다.

Pull Request 워크플로우

PR을 만들 때:

전체 커밋 히스토리를 분석 (최신 커밋만이 아닌)
git diff [base-branch]...HEAD로 모든 변경사항 확인
포괄적인 PR 요약 작성
TODO가 포함된 테스트 계획 포함
새 브랜치인 경우 -u 플래그와 함께 push

git 작업 전 전체 개발 프로세스(계획, TDD, 코드 리뷰)는 development-workflow.md를 참고하세요.

988 B Raw Blame History

Git 워크플로우

커밋 메시지 형식

Pull Request 워크플로우

988 B

Raw Blame History