Files
ECC/AGENTS.md
T
JongHyeok ParkGitHubAffaan Mustafadevin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com>affaanBoube
914a58a716 feat(workflows): re-land orch-review workflow + add /orch-review command (#2400)
* feat(workflows): re-land orch-review workflow + add /orch-review command

Re-lands #2363 (reverted by #2393 to unbreak main's lint) and fixes the
root cause so it stays green:

- Restore workflows/orch-review.workflow.js + workflows/README.md.
- eslint.config.js: ignore 'workflows/**/*.workflow.*' and '.claude/workflows/**'
  per the maintainer's note in #2393. Workflow DSL scripts use both top-level
  export (ESM) and top-level return (the runtime wraps them in an async fn),
  which no single eslint sourceType can parse — they must be excluded, not
  lint-fixed. 'npx eslint .' is green with this ignore.
- Add commands/orch-review.md (the /orch-review surface) + regenerate
  docs/COMMAND-REGISTRY.json.

Supersedes #2397 (command-only), which referenced the reverted workflow.

* fix(workflows): address orch-review bot review findings

- Verifier uncertainty no longer demotes blockers (Greptile P1 + CodeRabbit):
  isReal=false only refutes when confidence >= 0.8; low-confidence 'false'
  is treated as uncertain and kept blocking (fail closed).
- Treat the diff (and finding text) as untrusted input in both review and
  verify prompts; ignore embedded directives (prompt-injection hardening).
- Validate changedFiles entries are strings, not just that it is an array.
- Enforce proof for HIGH/CRITICAL in FINDINGS_SCHEMA, not only in the prompt.
- Remove in-place mutation in dimension build + dedup merge (immutable).
- /orch-review: extract & validate a numeric PR id before shelling out to gh.
- Docs: complete the stats example, soften wording, refresh follow-up list.

* style(workflows): apply formatter to orch-review assembly

* fix(plan-orchestrate): detect ecc@ecc marketplace + emit ecc: agent prefix (#2316) (#2409)

* fix(plan-orchestrate): detect ecc@ecc marketplace + emit ecc: agent prefix (#2316)

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>

* fix(ci): resync lockfiles with package.json (eslint 10) + migrate yarn.lock to Yarn 4 format

package.json requires eslint@^10.6.0 but the committed locks pinned 9.39.2, so
npm ci aborted and Yarn 4 hardened mode rejected the stale v1-classic yarn.lock
(YN0028). Regenerate package-lock.json and rewrite yarn.lock in Yarn 4 (berry)
format so npm ci and immutable yarn installs both pass.

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>

* fix(ci): require clean probe exit for Windows shell/bash detection; add pyyaml dev dep

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>

---------

Co-authored-by: affaan <affaan@itomarkets.com>
Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>

* refactor: consolidate duplicated hook-root resolver into shared resolveEccRoot() (#2368) (#2410)

* fix(ci): resync lockfiles with package.json (eslint 10) + migrate yarn.lock to Yarn 4 format

package.json requires eslint@^10.6.0 but the committed locks pinned 9.39.2, so
npm ci aborted and Yarn 4 hardened mode rejected the stale v1-classic yarn.lock
(YN0028). Regenerate package-lock.json and rewrite yarn.lock in Yarn 4 (berry)
format so npm ci and immutable yarn installs both pass.

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>

* fix(ci): require clean probe exit for Windows shell/bash detection; add pyyaml dev dep

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>

* refactor: consolidate duplicated hook-root resolver into shared resolveEccRoot() (#2368)

The inline node -e resolver blob was duplicated ~60x across hooks.json,
command docs, and translations. Each copy inlined the full ~700-char
plugin-root search using a spread over nested array literals
(p.join(d,'plugins',...s) over [['ecc'],...]), which breaks Windows hook
execution due to shell quoting (#2368).

Collapse every copy to a 250-char locator that loads the committed
resolve-ecc-root module and delegates to resolveEccRoot() — no spread, no
nested array literals, no escaped double quotes. The real search logic now
lives in one tested module. Also route session-start-bootstrap.js through
resolveEccRoot() instead of its own duplicated reimplementation, and fix
the auto-update.md 'marketplace' (singular) typo along the way.

Guard tests updated: discovery behavior is asserted against resolveEccRoot();
the inline is asserted to delegate and to contain no Windows-fragile
constructs.

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>

* fix(resolve-ecc-root): restore full env-unset discovery in inline resolver

Address Greptile review on #2410: when CLAUDE_PLUGIN_ROOT is unset the
delegating inline could only load the resolver module from ~/.claude,
returning ~/.claude without ever reaching the plugin/cache search. Restore
the old inline's discovery breadth (exact plugin roots + versioned cache)
Windows-safely (no spread, nested arrays, or escaped quotes), then delegate
the authoritative decision to resolveEccRoot(). Add regression tests for
plugin-subdir and versioned-cache bootstrap with env unset.

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>

---------

Co-authored-by: affaan <affaan@itomarkets.com>
Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>

* fix: docs/COMMAND-REGISTRY.json check fails on fresh Windows clone (missing .gitattributes) (#2437)

* fix: add .gitattributes to force LF line endings for text files

npm run command-registry:check (part of npm test) fails on a fresh clone
on Windows with the common core.autocrlf=true setting: git checks out
docs/COMMAND-REGISTRY.json with CRLF, but generate-command-registry.js
always writes LF, so the strict string comparison in checkRegistry()
never matches. Forcing LF via .gitattributes makes checkouts consistent
across platforms regardless of a contributor's local autocrlf setting.

* fix: normalize CRLF line endings to LF per .gitattributes

pyproject.toml, src/llm/__init__.py, src/llm/prompt/builder.py,
src/llm/providers/claude.py, and tests/test_builder.py had CRLF line
endings committed to the repo, inconsistent with the rest of the
codebase. Renormalized via 'git add --renormalize .' now that
.gitattributes enforces eol=lf.

---------

Co-authored-by: Affaan Mustafa <me@affaanmustafa.com>

* chore(catalog): sync command counts (92->93) + register orch-review in agent.yaml surface

---------

Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: affaan <affaan@itomarkets.com>
Co-authored-by: Boube <109886533+Cb2i@users.noreply.github.com>
Co-authored-by: Affaan Mustafa <me@affaanmustafa.com>
2026-07-03 20:26:40 -07:00

8.4 KiB

Everything Claude Code (ECC) — Agent Instructions

This is a production-ready AI coding plugin providing 67 specialized agents, 277 skills, 93 commands, and automated hook workflows for software development.

Version: 2.0.0

Core Principles

  1. Agent-First — Delegate to specialized agents for domain tasks
  2. Test-Driven — Write tests before implementation, 80%+ coverage required
  3. Security-First — Never compromise on security; validate all inputs
  4. Immutability — Always create new objects, never mutate existing ones
  5. Plan Before Execute — Plan complex features before writing code

Available Agents

Agent Purpose When to Use
planner Implementation planning Complex features, refactoring
architect System design and scalability Architectural decisions
tdd-guide Test-driven development New features, bug fixes
code-reviewer Code quality and maintainability After writing/modifying code
security-reviewer Vulnerability detection Before commits, sensitive code
spec-miner Brownfield spec extraction Onboarding brownfield projects to spec-driven development
build-error-resolver Fix build/type errors When build fails
e2e-runner End-to-end Playwright testing Critical user flows
refactor-cleaner Dead code cleanup Code maintenance
doc-updater Documentation and codemaps Updating docs
cpp-reviewer C/C++ code review C and C++ projects
cpp-build-resolver C/C++ build errors C and C++ build failures
fsharp-reviewer F# functional code review F# projects
docs-lookup Documentation lookup via Context7 API/docs questions
go-reviewer Go code review Go projects
go-build-resolver Go build errors Go build failures
kotlin-reviewer Kotlin code review Kotlin/Android/KMP projects
kotlin-build-resolver Kotlin/Gradle build errors Kotlin build failures
database-reviewer PostgreSQL/Supabase specialist Schema design, query optimization
python-reviewer Python code review Python projects
django-reviewer Django code review Django apps, DRF APIs, ORM, migrations
django-build-resolver Django build, migration, and setup errors Django startup, dependency, migration, collectstatic failures
java-reviewer Java and Spring Boot code review Java/Spring Boot projects
java-build-resolver Java/Maven/Gradle build errors Java build failures
loop-operator Autonomous loop execution Run loops safely, monitor stalls, intervene
harness-optimizer Harness config tuning Reliability, cost, throughput
rust-reviewer Rust code review Rust projects
rust-build-resolver Rust build errors Rust build failures
pytorch-build-resolver PyTorch runtime/CUDA/training errors PyTorch build/training failures
mle-reviewer Production ML pipeline review ML pipelines, evals, serving, monitoring, rollback
typescript-reviewer TypeScript/JavaScript code review TypeScript/JavaScript projects

Agent Orchestration

Use agents proactively without user prompt:

  • Complex feature requests → planner
  • Code just written/modified → code-reviewer
  • Bug fix or new feature → tdd-guide
  • Architectural decision → architect
  • Security-sensitive code → security-reviewer
  • Brownfield project onboarding → spec-miner
  • Autonomous loops / loop monitoring → loop-operator
  • Harness config reliability and cost → harness-optimizer

Use parallel execution for independent operations — launch multiple agents simultaneously.

Security Guidelines

Before ANY commit:

  • No hardcoded secrets (API keys, passwords, tokens)
  • All user inputs validated
  • SQL injection prevention (parameterized queries)
  • XSS prevention (sanitized HTML)
  • CSRF protection enabled
  • Authentication/authorization verified
  • Rate limiting on all endpoints
  • Error messages don't leak sensitive data

Secret management: NEVER hardcode secrets. Use environment variables or a secret manager. Validate required secrets at startup. Rotate any exposed secrets immediately.

If security issue found: STOP → use security-reviewer agent → fix CRITICAL issues → rotate exposed secrets → review codebase for similar issues.

Coding Style

Immutability (CRITICAL): Always create new objects, never mutate. Return new copies with changes applied.

File organization: Many small files over few large ones. 200-400 lines typical, 800 max. Organize by feature/domain, not by type. High cohesion, low coupling.

Error handling: Handle errors at every level. Provide user-friendly messages in UI code. Log detailed context server-side. Never silently swallow errors.

Input validation: Validate all user input at system boundaries. Use schema-based validation. Fail fast with clear messages. Never trust external data.

Code quality checklist:

  • Functions small (<50 lines), files focused (<800 lines)
  • No deep nesting (>4 levels)
  • Proper error handling, no hardcoded values
  • Readable, well-named identifiers

Testing Requirements

Minimum coverage: 80%

Test types (all required):

  1. Unit tests — Individual functions, utilities, components
  2. Integration tests — API endpoints, database operations
  3. E2E tests — Critical user flows

TDD workflow (mandatory):

  1. Write test first (RED) — test should FAIL
  2. Write minimal implementation (GREEN) — test should PASS
  3. Refactor (IMPROVE) — verify coverage 80%+

Troubleshoot failures: check test isolation → verify mocks → fix implementation (not tests, unless tests are wrong).

Development Workflow

  1. Plan — Use planner agent, identify dependencies and risks, break into phases
  2. TDD — Use tdd-guide agent, write tests first, implement, refactor
  3. Review — Use code-reviewer agent immediately, address CRITICAL/HIGH issues
  4. Capture knowledge in the right place
    • Personal debugging notes, preferences, and temporary context → auto memory
    • Team/project knowledge (architecture decisions, API changes, runbooks) → the project's existing docs structure
    • If the current task already produces the relevant docs or code comments, do not duplicate the same information elsewhere
    • If there is no obvious project doc location, ask before creating a new top-level file
  5. Commit — Conventional commits format, comprehensive PR summaries

Workflow Surface Policy

  • skills/ is the canonical workflow surface.
  • New workflow contributions should land in skills/ first.
  • commands/ is a legacy slash-entry compatibility surface and should only be added or updated when a shim is still required for migration or cross-harness parity.

Git Workflow

Commit format: <type>: <description> — Types: feat, fix, refactor, docs, test, chore, perf, ci

PR workflow: Analyze full commit history → draft comprehensive summary → include test plan → push with -u flag.

Architecture Patterns

API response format: Consistent envelope with success indicator, data payload, error message, and pagination metadata.

Repository pattern: Encapsulate data access behind standard interface (findAll, findById, create, update, delete). Business logic depends on abstract interface, not storage mechanism.

Skeleton projects: Search for battle-tested templates, evaluate with parallel agents (security, extensibility, relevance), clone best match, iterate within proven structure.

Performance

Context management: Avoid last 20% of context window for large refactoring and multi-file features. Lower-sensitivity tasks (single edits, docs, simple fixes) tolerate higher utilization.

Build troubleshooting: Use build-error-resolver agent → analyze errors → fix incrementally → verify after each fix.

Project Structure

agents/          — 67 specialized subagents
skills/          — 277 workflow skills and domain knowledge
commands/        — 93 slash commands
hooks/           — Trigger-based automations
rules/           — Always-follow guidelines (common + per-language)
scripts/         — Cross-platform Node.js utilities
mcp-configs/     — 14 MCP server configurations
tests/           — Test suite

commands/ remains in the repo for compatibility, but the long-term direction is skills-first.

Success Metrics

  • All tests pass with 80%+ coverage
  • No security vulnerabilities
  • Code is readable and maintainable
  • Performance is acceptable
  • User requirements are met