From 08df708b06ac44d71da5f9ec6807f4e37d1f82ef Mon Sep 17 00:00:00 2001
From: Martin Hoffmann <martin@nlnetlabs.nl>
Date: Fri, 27 Mar 2026 13:58:25 +0100
Subject: [PATCH] Fix issues flagged during review.

---
 README.md                                            | 3 +--
 src/commons/crypto/signing/signers/pkcs11/context.rs | 2 +-
 src/daemon/start.rs                                  | 1 -
 src/server/ca/child.rs                               | 2 +-
 src/server/ca/keys.rs                                | 2 +-
 src/server/taproxy.rs                                | 1 -
 tests/auth_check.rs                                  | 3 ---
 7 files changed, 4 insertions(+), 10 deletions(-)

diff --git a/README.md b/README.md
index a4277807..443a8a79 100644
--- a/README.md
+++ b/README.md
@@ -13,8 +13,7 @@ Krill is a Resource Public Key Infrastructure (RPKI) daemon, featuring a
 Certificate Authority (CA) and publication server, written in Rust.  If you have
 any feedback, we would love to hear from you. Don’t hesitate to [create an issue
 on Github](https://github.com/NLnetLabs/krill/issues/new) or post a message on
-our [RPKI mailing list](https://lists.nlnetlabs.nl/mailman/listinfo/rpki) or
-[Discord server](https://discord.gg/8dvKB5Ykhy). 
+our [forum](https://community.nlnetlabs.nl/c/rpki/11).
 
 For more information please refer to the [documentation](https://krill.docs.nlnetlabs.nl/en/stable/).
 
diff --git a/src/commons/crypto/signing/signers/pkcs11/context.rs b/src/commons/crypto/signing/signers/pkcs11/context.rs
index 3869dbdf..b249f5fd 100644
--- a/src/commons/crypto/signing/signers/pkcs11/context.rs
+++ b/src/commons/crypto/signing/signers/pkcs11/context.rs
@@ -262,7 +262,7 @@ impl Pkcs11Context {
         })
     }
 
-    fn finalize(&mut self) -> Result<(), Pkcs11Error>{
+    fn finalize(&mut self) -> Result<(), Pkcs11Error> {
         self.logged_cryptoki_call_with_take("Finalize", |cryptoki| {
             cryptoki.finalize()
         })
diff --git a/src/daemon/start.rs b/src/daemon/start.rs
index 482f77c4..42402c71 100644
--- a/src/daemon/start.rs
+++ b/src/daemon/start.rs
@@ -110,7 +110,6 @@ pub fn start_krill_daemon(
         properties_manager.init(KrillVersion::code_version())?;
     }
 
-    // XXX TODO This may need some configuration.
     let tokio = tokio::runtime::Runtime::new().map_err(|err| {
         KrillError::custom(
             format!("Failed to create Tokio runtime: {err}")
diff --git a/src/server/ca/child.rs b/src/server/ca/child.rs
index af8b6d51..06b3fcd5 100644
--- a/src/server/ca/child.rs
+++ b/src/server/ca/child.rs
@@ -396,7 +396,7 @@ pub struct ChildCertificateUpdates {
     #[serde(skip_serializing_if = "Vec::is_empty", default)]
     pub suspended: Vec<SuspendedCert>,
 
-    /// The certificats that have been unsuspended.
+    /// The certificates that have been unsuspended.
     ///
     /// This is no longer used as of Krill 0.16.0, but kept because it is in
     /// stored state.
diff --git a/src/server/ca/keys.rs b/src/server/ca/keys.rs
index a7405621..3cd7ee03 100644
--- a/src/server/ca/keys.rs
+++ b/src/server/ca/keys.rs
@@ -79,7 +79,7 @@ impl CertifiedKey {
     /// Updates the certificate received for the key.
     pub fn set_incoming_cert(&mut self, cert: ReceivedCert) {
         self.request = None;
-        self.incoming_cert = cert
+        self.incoming_cert = cert;
     }
 
     /// Returns the certified key info for this certified key.
diff --git a/src/server/taproxy.rs b/src/server/taproxy.rs
index ea6e8bf5..7b61b494 100644
--- a/src/server/taproxy.rs
+++ b/src/server/taproxy.rs
@@ -784,7 +784,6 @@ impl TrustAnchorProxy {
 /// a simple call to `into`.
 #[derive(Clone, Copy)]
 pub struct TrustAnchorProxyContext<'a> {
-    #[allow(dead_code)] // XXX remove!!
     tasks: &'a TaskQueue,
     signer: &'a KrillSigner,
 }
diff --git a/tests/auth_check.rs b/tests/auth_check.rs
index 24d0f5e7..dc3b76f9 100644
--- a/tests/auth_check.rs
+++ b/tests/auth_check.rs
@@ -12,8 +12,6 @@ mod common;
 async fn auth_check() {
     let server = common::KrillServer::start().await;
 
-    eprintln!("server is up.");
-
     // Get a client with a changed auth token.
     let client = KrillClient::new(
         server.server_uri().clone(), 
@@ -33,7 +31,6 @@ async fn auth_check() {
             )
         )
     );
-    eprintln!("back.");
 }
 
 #[tokio::test]