fix: handle uncaught err of file storage and email adapter

apps/OpenSignServer/cloud/customRoute/uploadFile.js

@@ -47,53 +47,78 @@ async function uploadFile(req, res) {
     const DO_ACCESS_KEY_ID = process.env.DO_ACCESS_KEY_ID;
     const DO_SECRET_ACCESS_KEY = process.env.DO_SECRET_ACCESS_KEY;
     const DO_SPACE = process.env.DO_SPACE;
-    const spacesEndpoint = new aws.Endpoint(DO_ENDPOINT);
-    const s3 = new aws.S3({
-      endpoint: spacesEndpoint,
-      accessKeyId: DO_ACCESS_KEY_ID,
-      secretAccessKey: DO_SECRET_ACCESS_KEY,
-      signatureVersion: 'v4',
-      region: process.env.DO_REGION,
-    });
 
     const parseBaseUrl = process.env.SERVER_URL;
     const parseAppId = process.env.APP_ID;
-
-    if (process.env.USE_LOCAL == "TRUE") {
-      var fileStorage = multer.diskStorage({
-        destination: function(req, file, cb) {
-          cb(null, "files/files");
+    let fileStorage;
+    if (process.env.USE_LOCAL == 'TRUE') {
+      fileStorage = multer.diskStorage({
+        destination: function (req, file, cb) {
+          cb(null, 'files/files');
         },
         metadata: function (req, file, cb) {
           cb(null, { fieldName: 'OPENSIGN_METADATA' });
         },
-        filename: function(req, file, cb) {
+        filename: function (req, file, cb) {
           let filename = file.originalname;
           let newFileName = filename.split('.')[0];
           let extension = filename.split('.')[1];
-          newFileName = sanitizeFileName(newFileName + '_' + new Date().toISOString() + '.' + extension)
+          newFileName = sanitizeFileName(
+            newFileName + '_' + new Date().toISOString() + '.' + extension
+          );
           console.log(newFileName);
           cb(null, newFileName);
-        }
+        },
       });
     } else {
-      var fileStorage = multerS3({
-        acl: 'public-read',
-        s3,
-        bucket: DO_SPACE,
-        metadata: function (req, file, cb) {
-          cb(null, { fieldName: 'OPENSIGN_METADATA' });
-        },
-        key: function (req, file, cb) {
-          //console.log(file);
-          let filename = file.originalname;
-          let newFileName = filename.split('.')[0];
-          let extension = filename.split('.')[1];
-          newFileName = sanitizeFileName(newFileName + '_' + new Date().toISOString() + '.' + extension)
-          console.log(newFileName);
-          cb(null, newFileName);
-        }
-      });
+      try {
+        const spacesEndpoint = new aws.Endpoint(DO_ENDPOINT);
+        const s3 = new aws.S3({
+          endpoint: spacesEndpoint,
+          accessKeyId: DO_ACCESS_KEY_ID,
+          secretAccessKey: DO_SECRET_ACCESS_KEY,
+          signatureVersion: 'v4',
+          region: process.env.DO_REGION,
+        });
+        fileStorage = multerS3({
+          acl: 'public-read',
+          s3,
+          bucket: DO_SPACE,
+          metadata: function (req, file, cb) {
+            cb(null, { fieldName: 'OPENSIGN_METADATA' });
+          },
+          key: function (req, file, cb) {
+            //console.log(file);
+            let filename = file.originalname;
+            let newFileName = filename.split('.')[0];
+            let extension = filename.split('.')[1];
+            newFileName = sanitizeFileName(
+              newFileName + '_' + new Date().toISOString() + '.' + extension
+            );
+            console.log(newFileName);
+            cb(null, newFileName);
+          },
+        });
+      } catch (err) {
+        fileStorage = multer.diskStorage({
+          destination: function (req, file, cb) {
+            cb(null, 'files/files');
+          },
+          metadata: function (req, file, cb) {
+            cb(null, { fieldName: 'OPENSIGN_METADATA' });
+          },
+          filename: function (req, file, cb) {
+            let filename = file.originalname;
+            let newFileName = filename.split('.')[0];
+            let extension = filename.split('.')[1];
+            newFileName = sanitizeFileName(
+              newFileName + '_' + new Date().toISOString() + '.' + extension
+            );
+            console.log(newFileName);
+            cb(null, newFileName);
+          },
+        });
+      }
     }
 
     // const s3 = new aws.S3();
@@ -122,7 +147,7 @@ async function uploadFile(req, res) {
       const status = 'Success';
       //res.header("Access-Control-Allow-Headers", "Content-Type");
       //res.setHeader("Access-Control-Allow-Origin", "*");
-      if (process.env.USE_LOCAL == "TRUE") {
+      if (process.env.USE_LOCAL == 'TRUE') {
         console.log(req.file);
         var fileUrl = `${parseBaseUrl}/files/${parseAppId}/${req.file.filename}`;
       } else {

apps/OpenSignServer/cloud/parsefunction/sendMail.js

@@ -4,30 +4,29 @@ import formData from 'form-data';
 import Mailgun from 'mailgun.js';
 import { createTransport } from 'nodemailer';
 
-let transporterSMTP;
-let mailgunClient;
-let mailgunDomain;
-if (process.env.SMTP_ENABLE) {
-  transporterSMTP = createTransport({
-    host: process.env.SMTP_HOST,
-    port: process.env.SMTP_PORT || 465,
-    secure: process.env.SMTP_SECURE || true,
-    auth: {
-      user: process.env.SMTP_USER_EMAIL,
-      pass: process.env.SMTP_PASS,
-    },
-  });
-} else {
-  const mailgun = new Mailgun(formData);
-  mailgunClient = mailgun.client({
-    username: 'api',
-    key: process.env.MAILGUN_API_KEY,
-  });
-  mailgunDomain = process.env.MAILGUN_DOMAIN;
-}
-
 async function sendmail(req) {
   try {
+    let transporterSMTP;
+    let mailgunClient;
+    let mailgunDomain;
+    if (process.env.SMTP_ENABLE) {
+      transporterSMTP = createTransport({
+        host: process.env.SMTP_HOST,
+        port: process.env.SMTP_PORT || 465,
+        secure: process.env.SMTP_SECURE || true,
+        auth: {
+          user: process.env.SMTP_USER_EMAIL,
+          pass: process.env.SMTP_PASS,
+        },
+      });
+    } else {
+      const mailgun = new Mailgun(formData);
+      mailgunClient = mailgun.client({
+        username: 'api',
+        key: process.env.MAILGUN_API_KEY,
+      });
+      mailgunDomain = process.env.MAILGUN_DOMAIN;
+    }
     if (req.params.url) {
       let Pdf = fs.createWriteStream('test.pdf');
       const writeToLocalDisk = () => {

apps/OpenSignServer/index.js

@@ -21,24 +21,32 @@ import { exec } from 'child_process';
 import { createTransport } from 'nodemailer';
 import { app as v1 } from './cloud/customRoute/v1/apiV1.js';
 import { PostHog } from 'posthog-node';
-const spacesEndpoint = new AWS.Endpoint(process.env.DO_ENDPOINT);
 // console.log("configuration ", configuration);
+let fsAdapter;
 if (process.env.USE_LOCAL !== 'TRUE') {
-  const s3Options = {
-    bucket: process.env.DO_SPACE, // globalConfig.S3FilesAdapter.bucket,
-    baseUrl: process.env.DO_BASEURL,
-    region: process.env.DO_REGION,
-    directAccess: true,
-    preserveFileName: true,
-    s3overrides: {
-      accessKeyId: process.env.DO_ACCESS_KEY_ID,
-      secretAccessKey: process.env.DO_SECRET_ACCESS_KEY,
-      endpoint: spacesEndpoint,
-    },
-  };
-  var fsAdapter = new S3Adapter(s3Options);
+  try {
+    const spacesEndpoint = new AWS.Endpoint(process.env.DO_ENDPOINT);
+    const s3Options = {
+      bucket: process.env.DO_SPACE, // globalConfig.S3FilesAdapter.bucket,
+      baseUrl: process.env.DO_BASEURL,
+      region: process.env.DO_REGION,
+      directAccess: true,
+      preserveFileName: true,
+      s3overrides: {
+        accessKeyId: process.env.DO_ACCESS_KEY_ID,
+        secretAccessKey: process.env.DO_SECRET_ACCESS_KEY,
+        endpoint: spacesEndpoint,
+      },
+    };
+    fsAdapter = new S3Adapter(s3Options);
+  } catch (err) {
+    console.log('err ', err);
+    fsAdapter = new FSFilesAdapter({
+      filesSubDirectory: 'files', // optional, defaults to ./files
+    });
+  }
 } else {
-  var fsAdapter = new FSFilesAdapter({
+  fsAdapter = new FSFilesAdapter({
     filesSubDirectory: 'files', // optional, defaults to ./files
   });
 }
@@ -78,14 +86,14 @@ export const config = {
   masterKey: process.env.MASTER_KEY || '', //Add your master key here. Keep it secret!
   masterKeyIps: ['0.0.0.0/0', '::1'], // '::1'
   serverURL: process.env.SERVER_URL || 'http://localhost:8080/app', // Don't forget to change to https if needed
-  verifyUserEmails: true,
+  verifyUserEmails: process.env.SMTP_ENABLE || process.env.MAILGUN_API_KEY ? true : false,
   publicServerURL: process.env.SERVER_URL || 'http://localhost:8080/app',
   // Your apps name. This will appear in the subject and body of the emails that are sent.
   appName: 'Open Sign',
   allowClientClassCreation: false,
-  emailAdapter:
-    process.env.SMTP_ENABLE || process.env.MAILGUN_API_KEY
-      ? {
+  ...(process.env.SMTP_ENABLE || process.env.MAILGUN_API_KEY
+    ? {
+        emailAdapter: {
           module: 'parse-server-api-mail-adapter',
           options: {
             // The email address from which emails are sent.
@@ -116,8 +124,9 @@ export const config = {
               } else if (transporterMail) await transporterMail.sendMail(payload);
             },
           },
-        }
-      : null,
+        },
+      }
+    : {}),
   filesAdapter: fsAdapter,
   auth: {
     google: {
@@ -170,9 +179,13 @@ app.use('/public', express.static(path.join(__dirname, '/public')));
 // Serve the Parse API on the /parse URL prefix
 if (!process.env.TESTING) {
   const mountPath = process.env.PARSE_MOUNT || '/app';
-  const server = new ParseServer(config);
-  await server.start();
-  app.use(mountPath, server.app);
+  try {
+    const server = new ParseServer(config);
+    await server.start();
+    app.use(mountPath, server.app);
+  } catch (err) {
+    console.log('Err ', err);
+  }
 }
 // Mount your custom express app
 app.use('/', customRoute);