From a1a84b692834c75ce4bd7b906331b87677012e76 Mon Sep 17 00:00:00 2001
From: prafull-opensignlabs <prafull.navkar@nxglabs.com>
Date: Tue, 16 Jan 2024 18:09:10 +0530
Subject: [PATCH] fix: userId missing in aftersave of doucment and template cls

---
 .../cloud/customRoute/v1/routes/createTemplate.js      |  5 +++--
 .../cloud/parsefunction/DocumentAftersave.js           |  2 +-
 .../cloud/parsefunction/TemplateAfterSave.js           | 10 +++++++---
 3 files changed, 11 insertions(+), 6 deletions(-)

diff --git a/apps/OpenSignServer/cloud/customRoute/v1/routes/createTemplate.js b/apps/OpenSignServer/cloud/customRoute/v1/routes/createTemplate.js
index ab8b70596..c477cdf9d 100644
--- a/apps/OpenSignServer/cloud/customRoute/v1/routes/createTemplate.js
+++ b/apps/OpenSignServer/cloud/customRoute/v1/routes/createTemplate.js
@@ -1,3 +1,4 @@
+const randomId = () => Math.floor(1000 + Math.random() * 9000);
 export default async function createTemplate(request, response) {
   const name = request.body.Title;
   const note = request.body.Note;
@@ -44,10 +45,10 @@ export default async function createTemplate(request, response) {
       object.set('CreatedBy', userId);
       object.set('ExtUserPtr', extUserPtr);
       if (signers) {
-        const placeholders = signers.map(x => ({
+        const placeholders = signers.map((x, i) => ({
           email: x,
           Id: randomId(),
-          Role: '',
+          Role: 'User ' + (i + 1),
           blockColor: '',
           signerObjId: '',
           signerPtr: {},
diff --git a/apps/OpenSignServer/cloud/parsefunction/DocumentAftersave.js b/apps/OpenSignServer/cloud/parsefunction/DocumentAftersave.js
index cd9964640..701ebd608 100644
--- a/apps/OpenSignServer/cloud/parsefunction/DocumentAftersave.js
+++ b/apps/OpenSignServer/cloud/parsefunction/DocumentAftersave.js
@@ -43,7 +43,7 @@ async function DocumentAftersave(request) {
       if (signers && signers.length > 0) {
         await updateAclDoc(request.object.id);
       } else {
-        if (request?.object?.id) {
+        if (request?.object?.id && request.user) {
           await updateSelfDoc(request.object.id);
         }
       }
diff --git a/apps/OpenSignServer/cloud/parsefunction/TemplateAfterSave.js b/apps/OpenSignServer/cloud/parsefunction/TemplateAfterSave.js
index 7d22ccb86..d5bcc168a 100644
--- a/apps/OpenSignServer/cloud/parsefunction/TemplateAfterSave.js
+++ b/apps/OpenSignServer/cloud/parsefunction/TemplateAfterSave.js
@@ -8,7 +8,9 @@ export default async function TemplateAfterSave(request) {
       if (signers && signers.length > 0) {
         await updateAclDoc(request.object.id);
       } else {
-        await updateSelfDoc(request.object.id);
+        if (request?.object?.id && request.user) {
+          await updateSelfDoc(request.object.id);
+        }
       }
     } else {
       if (request.user) {
@@ -16,7 +18,9 @@ export default async function TemplateAfterSave(request) {
         if (signers && signers.length > 0) {
           await updateAclDoc(request.object.id);
         } else {
-          await updateSelfDoc(request.object.id);
+          if (request?.object?.id) {
+            await updateSelfDoc(request.object.id);
+          }
         }
       }
     }
@@ -66,7 +70,7 @@ export default async function TemplateAfterSave(request) {
 
   async function updateSelfDoc(objId) {
     // console.log("Inside updateSelfDoc func")
-    
+
     const Query = new Parse.Query('contracts_Template');
     const updateACL = await Query.get(objId, { useMasterKey: true });
     // const res = JSON.parse(JSON.stringify(updateACL));