From a64e4d943ada71e29c8708557ea9a3aadcb90d2a Mon Sep 17 00:00:00 2001 From: prafull-opensignlabs Date: Fri, 3 Nov 2023 19:53:12 +0530 Subject: [PATCH 1/2] change build scripts to run microfrontend properly --- apps/OpenSign/package.json | 2 +- microfrontends/SignDocuments/.gitignore | 2 +- microfrontends/SignDocuments/package.json | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/apps/OpenSign/package.json b/apps/OpenSign/package.json index b66a18ca9..7d3fb2b3d 100644 --- a/apps/OpenSign/package.json +++ b/apps/OpenSign/package.json @@ -41,7 +41,7 @@ }, "scripts": { "start": "mf-cra start", - "build": "rm -rf public/mfbuild/* && npm run micro && CI=false && mf-cra build", + "build": "rm -rf public/mfbuild && npm run micro && CI=false && mf-cra build", "micro": "cd ../../microfrontends/SignDocuments && npm install && npm run build", "test": "react-scripts test", "eject": "react-scripts eject", diff --git a/microfrontends/SignDocuments/.gitignore b/microfrontends/SignDocuments/.gitignore index 4d29575de..944d54495 100644 --- a/microfrontends/SignDocuments/.gitignore +++ b/microfrontends/SignDocuments/.gitignore @@ -9,7 +9,7 @@ /coverage # production -/build +/mfbuild # misc .DS_Store diff --git a/microfrontends/SignDocuments/package.json b/microfrontends/SignDocuments/package.json index 348d629eb..3c8e28903 100644 --- a/microfrontends/SignDocuments/package.json +++ b/microfrontends/SignDocuments/package.json @@ -35,7 +35,7 @@ }, "scripts": { "start": "mf-cra start", - "build": "CI=false && mf-cra build && mv build/* ../../apps/OpenSign/public/mfbuild", + "build": "CI=false && BUILD_PATH='./mfbuild' mf-cra build && mv mfbuild ../../apps/OpenSign/public", "test": "react-scripts test", "eject": "react-scripts eject" }, From 86a4ee7f56de12d75c5c765b127e1413e633a637 Mon Sep 17 00:00:00 2001 From: prafull-opensignlabs Date: Fri, 3 Nov 2023 19:59:37 +0530 Subject: [PATCH 2/2] add start-prod to run production build --- apps/OpenSign/package.json | 1 + 1 file changed, 1 insertion(+) diff --git a/apps/OpenSign/package.json b/apps/OpenSign/package.json index 7d3fb2b3d..0b354b9c7 100644 --- a/apps/OpenSign/package.json +++ b/apps/OpenSign/package.json @@ -41,6 +41,7 @@ }, "scripts": { "start": "mf-cra start", + "start-prod": "serve -s build", "build": "rm -rf public/mfbuild && npm run micro && CI=false && mf-cra build", "micro": "cd ../../microfrontends/SignDocuments && npm install && npm run build", "test": "react-scripts test",