refactor: resolve warnings

apps/OpenSignServer/cloud/parsefunction/DocumentBeforesave.js

@@ -1,6 +1,24 @@
+import { MAX_DESCRIPTION_LENGTH, MAX_NAME_LENGTH, MAX_NOTE_LENGTH } from '../../Utils.js';
+
 async function DocumentBeforesave(request) {
   if (!request.original) {
-    const TimeToCompleteDays = request.object.get('TimeToCompleteDays') || 15;
+    const validations = [
+      { field: 'Name', max: MAX_NAME_LENGTH },
+      { field: 'Note', max: MAX_NOTE_LENGTH },
+      { field: 'Description', max: MAX_DESCRIPTION_LENGTH },
+    ];
+
+    for (const { field, max } of validations) {
+      const value = request?.object?.get(field);
+      if (value && value.length > max) {
+        throw new Parse.Error(
+          Parse.Error.VALIDATION_ERROR,
+          `The "${field}" field must be at most ${max} characters long.`
+        );
+      }
+    }
+
+    const TimeToCompleteDays = request?.object?.get('TimeToCompleteDays') || 15;
     const RemindOnceInEvery = request?.object?.get('RemindOnceInEvery') || 5;
     const AutoReminder = request?.object?.get('AutomaticReminders') || false;
     const reminderCount = TimeToCompleteDays / RemindOnceInEvery;
@@ -36,7 +54,6 @@ async function DocumentBeforesave(request) {
       }
       if (document?.get('Signers') && document.get('Signers').length > 0) {
         document.set('DocSentAt', new Date());
-        document.save(null, { useMasterKey: true });
       }
     }
   } catch (err) {

apps/OpenSignServer/cloud/parsefunction/GetTemplate.js

@@ -1,112 +1,82 @@
 import axios from 'axios';
-import {
-  cloudServerUrl,
-} from '../../Utils.js';
+import { cloudServerUrl } from '../../Utils.js';
 
 export default async function GetTemplate(request) {
   const serverUrl = cloudServerUrl; //process.env.SERVER_URL;
   const templateId = request.params.templateId;
-  const ispublic = request.params.ispublic;
   const sessiontoken = request.headers?.sessiontoken;
   try {
-    if (!ispublic) {
-      let userEmail;
-      if (sessiontoken) {
-        const userRes = await axios.get(serverUrl + '/users/me', {
-          headers: {
-            'X-Parse-Application-Id': process.env.APP_ID,
-            'X-Parse-Session-Token': sessiontoken,
-          },
-        });
-        userEmail = userRes.data && userRes.data.email;
-      }
-      if (templateId && userEmail) {
-        try {
-          let template = new Parse.Query('contracts_Template');
-          template.equalTo('objectId', templateId);
-          template.include('ExtUserPtr');
-          template.include('Signers');
-          template.include('CreatedBy');
-          template.include('ExtUserPtr.TenantId');
-          template.include('Bcc');
-          const extUserQuery = new Parse.Query('contracts_Users');
-          extUserQuery.equalTo('Email', userEmail);
-          extUserQuery.include('TeamIds');
-          const extUser = await extUserQuery.first({ useMasterKey: true });
-          if (extUser) {
-            const _extUser = JSON.parse(JSON.stringify(extUser));
-            if (_extUser?.TeamIds && _extUser.TeamIds?.length > 0) {
-              let teamsArr = [];
-              _extUser?.TeamIds?.forEach(x => (teamsArr = [...teamsArr, ...x.Ancestors]));
-              // Create the first query
-              const sharedWithQuery = new Parse.Query('contracts_Template');
-              sharedWithQuery.containedIn('SharedWith', teamsArr);
-
-              // Create the second query
-              const createdByQuery = new Parse.Query('contracts_Template');
-              createdByQuery.equalTo('ExtUserPtr', {
-                __type: 'Pointer',
-                className: 'contracts_Users',
-                objectId: extUser.id,
-              });
-              template = Parse.Query.or(sharedWithQuery, createdByQuery);
-              template.equalTo('objectId', templateId);
-              template.include('ExtUserPtr');
-              template.include('Signers');
-              template.include('CreatedBy');
-              template.include('ExtUserPtr.TenantId');
-              template.include('Placeholders.signerPtr');
-              template.include('Bcc');
-            }
-          }
-          const res = await template.first({ useMasterKey: true });
-          if (res) {
-            const templateRes = JSON.parse(JSON.stringify(res));
-            delete templateRes?.ExtUserPtr?.TenantId?.FileAdapters;
-            delete templateRes?.ExtUserPtr?.TenantId?.PfxFile;
-            return templateRes;
-          } else {
-            return { error: "You don't have access of this document!" };
-          }
-        } catch (err) {
-          console.log('err', err);
-          return err;
-        }
-      } else {
-        return { error: "You don't have access of this document!" };
-      }
-    } else if (templateId && ispublic) {
+    let userEmail;
+    if (sessiontoken) {
+      const userRes = await axios.get(serverUrl + '/users/me', {
+        headers: {
+          'X-Parse-Application-Id': process.env.APP_ID,
+          'X-Parse-Session-Token': sessiontoken,
+        },
+      });
+      userEmail = userRes.data && userRes.data.email;
+    }
+    if (templateId && userEmail) {
       try {
-        const template = new Parse.Query('contracts_Template');
+        let template = new Parse.Query('contracts_Template');
         template.equalTo('objectId', templateId);
         template.include('ExtUserPtr');
         template.include('Signers');
         template.include('CreatedBy');
         template.include('ExtUserPtr.TenantId');
         template.include('Bcc');
+        const extUserQuery = new Parse.Query('contracts_Users');
+        extUserQuery.equalTo('Email', userEmail);
+        extUserQuery.include('TeamIds');
+        const extUser = await extUserQuery.first({ useMasterKey: true });
+        if (extUser) {
+          const _extUser = JSON.parse(JSON.stringify(extUser));
+          if (_extUser?.TeamIds && _extUser.TeamIds?.length > 0) {
+            let teamsArr = [];
+            _extUser?.TeamIds?.forEach(x => (teamsArr = [...teamsArr, ...x.Ancestors]));
+            // Create the first query
+            const sharedWithQuery = new Parse.Query('contracts_Template');
+            sharedWithQuery.containedIn('SharedWith', teamsArr);
+
+            // Create the second query
+            const createdByQuery = new Parse.Query('contracts_Template');
+            createdByQuery.equalTo('ExtUserPtr', {
+              __type: 'Pointer',
+              className: 'contracts_Users',
+              objectId: extUser.id,
+            });
+            template = Parse.Query.or(sharedWithQuery, createdByQuery);
+            template.equalTo('objectId', templateId);
+            template.include('ExtUserPtr');
+            template.include('Signers');
+            template.include('CreatedBy');
+            template.include('ExtUserPtr.TenantId');
+            template.include('Placeholders.signerPtr');
+            template.include('Bcc');
+          }
+        }
         const res = await template.first({ useMasterKey: true });
-        // console.log("res ", res)
         if (res) {
           const templateRes = JSON.parse(JSON.stringify(res));
           delete templateRes?.ExtUserPtr?.TenantId?.FileAdapters;
           delete templateRes?.ExtUserPtr?.TenantId?.PfxFile;
           return templateRes;
         } else {
-          return { error: "You don't have access of this document!" };
+          return { error: "You don't have access of this template!" };
         }
       } catch (err) {
         console.log('err', err);
         return err;
       }
     } else {
-      return { error: 'Please pass required parameters!' };
+      return { error: "You don't have access of this template!" };
     }
   } catch (err) {
     console.log('err', err);
     if (err?.response?.data?.code === 209 || err.code == 209) {
       return { error: 'Invalid session token' };
     } else {
-      return { error: "You don't have access of this document!" };
+      return { error: "You don't have access of this template!" };
     }
   }
 }

apps/OpenSignServer/cloud/parsefunction/SendMailOTPv1.js

@@ -19,7 +19,6 @@ async function getDocument(docId) {
 }
 async function sendMailOTPv1(request) {
   try {
-    //--for elearning app side
     let code = Math.floor(1000 + Math.random() * 9000);
     let email = request.params.email;
     let TenantId = request.params.TenantId ? request.params.TenantId : undefined;
@@ -30,14 +29,14 @@ async function sendMailOTPv1(request) {
       const mailsender = smtpenable ? process.env.SMTP_USER_EMAIL : process.env.MAILGUN_SENDER;
       try {
         await Parse.Cloud.sendEmail({
-          from: AppName + ' <' + mailsender + '>',
+          sender: AppName + ' <' + mailsender + '>',
           recipient: recipient,
           subject: `Your ${AppName} OTP`,
-          text: 'This email is a test.',
+          text: 'otp email',
           html:
-            `<html><head><meta http-equiv='Content-Type' content='text/html; charset=UTF-8' /></head><body><div style='background-color:#f5f5f5;padding:20px'><div style='box-shadow: rgba(0, 0, 0, 0.1) 0px 4px 12px;background-color:white;'><div style='background-color:red;padding:2px;font-family:system-ui; background-color:#47a3ad;'>    <p style='font-size:20px;font-weight:400;color:white;padding-left:20px',>OTP Verification</p></div><div style='padding:20px'><p style='font-family:system-ui;font-size:14px'>Your OTP for ${AppName} verification is:</p><p style=' text-decoration: none; font-weight: bolder; color:blue;font-size:45px;margin:20px'>` +
+            `<html><head><meta http-equiv='Content-Type' content='text/html;charset=UTF-8' /></head><body><div style='background-color:#f5f5f5;padding:20px'><div style='background-color:white;'><div style='background-color:red;padding:2px;font-family:system-ui;background-color:#47a3ad;'><p style='font-size:20px;font-weight:400;color:white;padding-left:20px;'>OTP Verification</p></div><div style='padding:20px;'><p style='font-family:system-ui;font-size:14px;'>Your OTP for ${AppName} verification is:</p><p style='text-decoration:none;font-weight:bolder;color:blue;font-size:45px;margin:20px;'>` +
             code +
-            '</p></div> </div> </div></body></html>',
+            '</p></div></div></div></body></html>',
         });
         console.log('OTP sent', code);
         if (request.params?.docId) {

apps/OpenSignServer/cloud/parsefunction/TemplateBeforesave.js

@@ -1,5 +1,23 @@
+import { MAX_DESCRIPTION_LENGTH, MAX_NAME_LENGTH, MAX_NOTE_LENGTH } from '../../Utils.js';
+
 async function TemplateBeforeSave(request) {
   if (!request.original) {
+    const validations = [
+      { field: 'Name', max: MAX_NAME_LENGTH },
+      { field: 'Note', max: MAX_NOTE_LENGTH },
+      { field: 'Description', max: MAX_DESCRIPTION_LENGTH },
+    ];
+
+    for (const { field, max } of validations) {
+      const value = request.object?.get(field);
+      if (value && value.length > max) {
+        throw new Parse.Error(
+          Parse.Error.VALIDATION_ERROR,
+          `The "${field}" field must be at most ${max} characters long.`
+        );
+      }
+    }
+
     const TimeToCompleteDays = request.object.get('TimeToCompleteDays') || 15;
     const RemindOnceInEvery = request?.object?.get('RemindOnceInEvery') || 5;
     const AutoReminder = request?.object?.get('AutomaticReminders') || false;

apps/OpenSignServer/cloud/parsefunction/createBatchDocs.js

@@ -182,6 +182,15 @@ async function batchQuery(userId, Documents, Ip, parseConfig, type, publicUrl) {
             ...(x?.RedirectUrl ? { RedirectUrl: x?.RedirectUrl } : {}),
             ...(mailBody ? { RequestBody: mailBody } : {}),
             ...(mailSubject ? { RequestSubject: mailSubject } : {}),
+            ...(x?.objectId
+              ? {
+                  TemplateId: {
+                    __type: 'Pointer',
+                    className: 'contracts_Template',
+                    objectId: x?.objectId,
+                  },
+                }
+              : {}),
           },
         };
       });

apps/OpenSignServer/cloud/parsefunction/reportsJson.js

@@ -25,9 +25,9 @@ export default function reportJson(id, userId) {
           'Signers.Phone',
           'Placeholders',
           'IsSignyourself',
+          'TemplateId',
         ],
       };
-
     // Need your sign report
     case '4Hhwbp482K':
       return {
@@ -61,6 +61,7 @@ export default function reportJson(id, userId) {
           'AuditTrail',
           'Placeholders',
           'SignedUrl',
+          'TemplateId',
           'ExpiryDate',
         ],
       };
@@ -94,6 +95,7 @@ export default function reportJson(id, userId) {
           'SendMail',
           'Placeholders',
           'SignedUrl',
+          'TemplateId',
         ],
       };
     // completed documents report
@@ -140,6 +142,7 @@ export default function reportJson(id, userId) {
           'Placeholders',
           'IsSignyourself',
           'IsCompleted',
+          'TemplateId',
         ],
       };
     //  declined documents report
@@ -164,6 +167,7 @@ export default function reportJson(id, userId) {
           'Placeholders',
           'DeclineReason',
           'SignedUrl',
+          'TemplateId',
         ],
       };
     //  Expired Documents report
@@ -190,6 +194,7 @@ export default function reportJson(id, userId) {
           'Signers.Phone',
           'Placeholders',
           'SignedUrl',
+          'TemplateId',
           'ExpiryDate',
         ],
       };
@@ -221,6 +226,7 @@ export default function reportJson(id, userId) {
           'ExpiryDate',
           'Placeholders',
           'SignedUrl',
+          'TemplateId',
         ],
       };
     //  Recent signature requests report show on dashboard
@@ -254,6 +260,7 @@ export default function reportJson(id, userId) {
           'Signers.Phone',
           'Placeholders',
           'SignedUrl',
+          'TemplateId',
           'ExpiryDate',
         ],
       };
@@ -279,6 +286,7 @@ export default function reportJson(id, userId) {
           'Signers.Email',
           'Signers.Phone',
           'Placeholders',
+          'TemplateId',
         ],
       };
     // contact book report