From 9b9de421392b337c7ed5fa63cac4e88700942d59 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ga=C3=ABl=20M=C3=A9tais?= Date: Fri, 29 May 2015 17:01:51 +0200 Subject: [PATCH 1/2] Fix test on headersSize --- test/core/weightCheckerTest.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/core/weightCheckerTest.js b/test/core/weightCheckerTest.js index 61bf429..e45585d 100644 --- a/test/core/weightCheckerTest.js +++ b/test/core/weightCheckerTest.js @@ -75,7 +75,7 @@ describe('weightChecker', function() { newEntry.weightCheck.bodySize.should.equal(93636); newEntry.weightCheck.uncompressedSize.should.equal(newEntry.weightCheck.bodySize); newEntry.weightCheck.isCompressed.should.equal(false); - newEntry.weightCheck.headersSize.should.be.above(300).and.below(350); + newEntry.weightCheck.headersSize.should.be.above(200).and.below(400); newEntry.weightCheck.body.should.have.string('1.8.3'); done(); From fe7de2db9963158903a7d5628b7bb429d09bb6ee Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ga=C3=ABl=20M=C3=A9tais?= Date: Fri, 29 May 2015 22:56:07 +0200 Subject: [PATCH 2/2] Fix rare bug with domComplete never triggered --- lib/tools/jsExecutionTransformer.js | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/lib/tools/jsExecutionTransformer.js b/lib/tools/jsExecutionTransformer.js index 1015a09..a215341 100644 --- a/lib/tools/jsExecutionTransformer.js +++ b/lib/tools/jsExecutionTransformer.js @@ -38,7 +38,7 @@ var jsExecutionTransformer = function() { javascriptExecutionTree = JSON.parse(data.toolsResults.phantomas.offenders.javascriptExecutionTree[0]); if (javascriptExecutionTree.children) { - javascriptExecutionTree.children.forEach(function(node) { + javascriptExecutionTree.children.forEach(function(node, index) { var contextLength = (node.data.callDetails && node.data.callDetails.context) ? node.data.callDetails.context.length : null; @@ -90,6 +90,10 @@ var jsExecutionTransformer = function() { break; } } + // Fix rare bug when domComplete was never triggered + if (index === javascriptExecutionTree.children.length - 1 && !javascriptExecutionTree.data.domComplete) { + javascriptExecutionTree.data.domComplete = node.data.timestamp + 1000; + } // Transform domPaths into objects changeListOfDomPaths(node);