From 5bf3bd7ce5a980895d5e925784fc5dadfc4c4d9c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ga=C3=ABl=20M=C3=A9tais?= Date: Mon, 23 Nov 2020 13:49:04 +0100 Subject: [PATCH] Fix a potential divided by O error --- lib/screenshotHandler.js | 27 ++++++++++++++++----------- 1 file changed, 16 insertions(+), 11 deletions(-) diff --git a/lib/screenshotHandler.js b/lib/screenshotHandler.js index 6c9629f..29d68a8 100644 --- a/lib/screenshotHandler.js +++ b/lib/screenshotHandler.js @@ -54,19 +54,24 @@ var screenshotHandler = function() { var deferred = Q.defer(); var currentWidth = image.bitmap.width; - var ratio = newWidth / currentWidth; - image.scale(ratio, function(err, image){ - if (err) { - debug('Could not resize image'); - debug(err); + if (currentWidth > 0) { + var ratio = newWidth / currentWidth; - deferred.reject(err); - } else { - debug('Image correctly resized'); - deferred.resolve(image); - } - }); + image.scale(ratio, function(err, image){ + if (err) { + debug('Could not resize image'); + debug(err); + + deferred.reject(err); + } else { + debug('Image correctly resized'); + deferred.resolve(image); + } + }); + } else { + deferred.reject('Could not resize an empty image'); + } return deferred.promise; };