From 701530ef04f42d59e1ecc8b27666cc82e7de2e3c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ga=C3=ABl=20M=C3=A9tais?= Date: Fri, 22 May 2015 11:16:18 +0200 Subject: [PATCH] Be cooler on global variables --- lib/metadata/policies.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/metadata/policies.js b/lib/metadata/policies.js index 5285096..cb1caec 100644 --- a/lib/metadata/policies.js +++ b/lib/metadata/policies.js @@ -351,9 +351,9 @@ var policies = { "tool": "phantomas", "label": "Global variables", "message": "

It is a bad practice because they clutter up the global namespace. If two scripts use the same variable name in the global scope, it can cause conflicts and it is generally hard to debug.

Global variables also take a (very) little bit longer to be accessed than variables in the local scope of a function.

", - "isOkThreshold": 10, - "isBadThreshold": 50, - "isAbnormalThreshold": 200, + "isOkThreshold": 30, + "isBadThreshold": 100, + "isAbnormalThreshold": 400, "hasOffenders": true, "offendersTransformFn": function(offenders) { return {