From 7e9b12f818844d717ca03d9d3388bb6911ad21ed Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Ga=C3=ABl=20M=C3=A9tais?= <gael.metais@gmail.com>
Date: Wed, 30 Dec 2020 00:52:18 +0100
Subject: [PATCH] Adjust scoring

---
 front/src/views/rule.html             | 5 ++++-
 lib/metadata/scoreProfileGeneric.json | 2 +-
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/front/src/views/rule.html b/front/src/views/rule.html
index 7effe8b..98b3bb3 100644
--- a/front/src/views/rule.html
+++ b/front/src/views/rule.html
@@ -22,9 +22,12 @@
                 <span ng-if="rule.policy.isOkThreshold > rule.policy.isBadThreshold">or more</span>
                 to get the 100/100 score on this issue.
             </div>
-            <div class="okThreshold" ng-if="rule.globalScoreIfFixed > result.scoreProfiles.generic.globalScore && rule.globalScoreIfFixed > 0">
+            <div class="okThreshold" ng-if="rule.globalScoreIfFixed > result.scoreProfiles.generic.globalScore && rule.globalScoreIfFixed > 0 && result.scoreProfiles.generic.globalScore >= 0">
                 Your new global would increase by {{rule.globalScoreIfFixed - result.scoreProfiles.generic.globalScore}} points ({{rule.globalScoreIfFixed}}/100).
             </div>
+            <div class="okThreshold" ng-if="rule.globalScoreIfFixed > result.scoreProfiles.generic.globalScore && rule.globalScoreIfFixed > 0 && result.scoreProfiles.generic.globalScore < 0">
+                Your new global would increase by {{rule.globalScoreIfFixed}} points ({{rule.globalScoreIfFixed}}/100).
+            </div>
             <div class="okThreshold" ng-if="rule.globalScoreIfFixed > result.scoreProfiles.generic.globalScore && rule.globalScoreIfFixed <= 0">
                 Your new global score would increase, but still not enough to reach 0/100. That's embarassing...
             </div>
diff --git a/lib/metadata/scoreProfileGeneric.json b/lib/metadata/scoreProfileGeneric.json
index 953b2f8..080a18c 100644
--- a/lib/metadata/scoreProfileGeneric.json
+++ b/lib/metadata/scoreProfileGeneric.json
@@ -15,7 +15,7 @@
             "policies": {
                 "totalRequests": 2,
                 "domains": 3,
-                "notFound": 3,
+                "notFound": 2,
                 "identicalFiles": 2,
                 "emptyRequests": 3,
                 "lazyLoadableImagesBelowTheFold": 2,