From a8af5915e3b58eba9dc47ad14d1ab7ecc0015068 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ga=C3=ABl=20M=C3=A9tais?= Date: Thu, 4 Sep 2014 14:15:38 +0200 Subject: [PATCH] jsHint --- app/lib/testQueue.js | 2 +- app/public/scripts/resultsCtrl.js | 48 +++++++++---------- .../modules/eventListYLT/eventListYLT.js | 5 +- .../modules/windowPerfYLT/windowPerfYLT.js | 3 +- 4 files changed, 30 insertions(+), 28 deletions(-) diff --git a/app/lib/testQueue.js b/app/lib/testQueue.js index 8164bb1..f271ccb 100644 --- a/app/lib/testQueue.js +++ b/app/lib/testQueue.js @@ -57,7 +57,7 @@ var testQueue = function() { this.testFailed = function(testId) { self.emit('testFailed', testId); - } + }; }; // extend the EventEmitter class diff --git a/app/public/scripts/resultsCtrl.js b/app/public/scripts/resultsCtrl.js index 8cd5dca..3980012 100644 --- a/app/public/scripts/resultsCtrl.js +++ b/app/public/scripts/resultsCtrl.js @@ -73,9 +73,9 @@ app.controller('ResultsCtrl', function ($scope) { jQueryLoading: 'A' }; - var domComplexityScore = $scope.phantomasResults.metrics.DOMelementsCount - + Math.pow($scope.phantomasResults.metrics.DOMelementMaxDepth, 2) - + $scope.phantomasResults.metrics.iframesCount * 50; + var domComplexityScore = $scope.phantomasResults.metrics.DOMelementsCount + + Math.pow($scope.phantomasResults.metrics.DOMelementMaxDepth, 2) + + $scope.phantomasResults.metrics.iframesCount * 50; if (domComplexityScore > 1000) { $scope.notations.domComplexity = 'B'; } @@ -92,9 +92,9 @@ app.controller('ResultsCtrl', function ($scope) { $scope.notations.domComplexity = 'F'; } - var domManipulationsScore = $scope.phantomasResults.metrics.DOMinserts - + $scope.phantomasResults.metrics.DOMqueries * 0.5 - + $scope.totalJSTime; + var domManipulationsScore = $scope.phantomasResults.metrics.DOMinserts + + $scope.phantomasResults.metrics.DOMqueries * 0.5 + + $scope.totalJSTime; if (domManipulationsScore > 100) { $scope.notations.domManipulations = 'B'; } @@ -145,10 +145,10 @@ app.controller('ResultsCtrl', function ($scope) { $scope.notations.eventsBound = 'F'; } - var badPracticesScore = $scope.phantomasResults.metrics.documentWriteCalls * 3 - + $scope.phantomasResults.metrics.evalCalls * 3 - + $scope.phantomasResults.metrics.jsErrors * 10 - + $scope.phantomasResults.metrics.consoleMessages; + var badPracticesScore = $scope.phantomasResults.metrics.documentWriteCalls * 3 + + $scope.phantomasResults.metrics.evalCalls * 3 + + $scope.phantomasResults.metrics.jsErrors * 10 + + $scope.phantomasResults.metrics.consoleMessages; if (badPracticesScore > 5) { $scope.notations.badPractices = 'B'; } @@ -186,24 +186,24 @@ app.controller('ResultsCtrl', function ($scope) { if ($scope.phantomasResults.metrics.jQueryDifferentVersions > 1) { $scope.notations.jQueryLoading = 'F'; } else if ($scope.phantomasResults.metrics.jQueryVersion) { - if ($scope.phantomasResults.metrics.jQueryVersion.indexOf('1.10.') === 0 - || $scope.phantomasResults.metrics.jQueryVersion.indexOf('1.11.') === 0 - || $scope.phantomasResults.metrics.jQueryVersion.indexOf('1.12.') === 0 - || $scope.phantomasResults.metrics.jQueryVersion.indexOf('2.0.') === 0 - || $scope.phantomasResults.metrics.jQueryVersion.indexOf('2.1.') === 0 - || $scope.phantomasResults.metrics.jQueryVersion.indexOf('2.2.') === 0) { + if ($scope.phantomasResults.metrics.jQueryVersion.indexOf('1.10.') === 0 || + $scope.phantomasResults.metrics.jQueryVersion.indexOf('1.11.') === 0 || + $scope.phantomasResults.metrics.jQueryVersion.indexOf('1.12.') === 0 || + $scope.phantomasResults.metrics.jQueryVersion.indexOf('2.0.') === 0 || + $scope.phantomasResults.metrics.jQueryVersion.indexOf('2.1.') === 0 || + $scope.phantomasResults.metrics.jQueryVersion.indexOf('2.2.') === 0) { $scope.notations.jQueryLoading = 'A'; - } else if ($scope.phantomasResults.metrics.jQueryVersion.indexOf('1.8.') === 0 - || $scope.phantomasResults.metrics.jQueryVersion.indexOf('1.9.') === 0) { + } else if ($scope.phantomasResults.metrics.jQueryVersion.indexOf('1.8.') === 0 || + $scope.phantomasResults.metrics.jQueryVersion.indexOf('1.9.') === 0) { $scope.notations.jQueryLoading = 'B'; - } else if ($scope.phantomasResults.metrics.jQueryVersion.indexOf('1.6.') === 0 - || $scope.phantomasResults.metrics.jQueryVersion.indexOf('1.7.') === 0) { + } else if ($scope.phantomasResults.metrics.jQueryVersion.indexOf('1.6.') === 0 || + $scope.phantomasResults.metrics.jQueryVersion.indexOf('1.7.') === 0) { $scope.notations.jQueryLoading = 'C'; - } else if ($scope.phantomasResults.metrics.jQueryVersion.indexOf('1.4.') === 0 - || $scope.phantomasResults.metrics.jQueryVersion.indexOf('1.5.') === 0) { + } else if ($scope.phantomasResults.metrics.jQueryVersion.indexOf('1.4.') === 0 || + $scope.phantomasResults.metrics.jQueryVersion.indexOf('1.5.') === 0) { $scope.notations.jQueryLoading = 'D'; - } else if ($scope.phantomasResults.metrics.jQueryVersion.indexOf('1.2.') === 0 - || $scope.phantomasResults.metrics.jQueryVersion.indexOf('1.3.') === 0) { + } else if ($scope.phantomasResults.metrics.jQueryVersion.indexOf('1.2.') === 0 || + $scope.phantomasResults.metrics.jQueryVersion.indexOf('1.3.') === 0) { $scope.notations.jQueryLoading = 'E'; } } diff --git a/phantomas_custom/modules/eventListYLT/eventListYLT.js b/phantomas_custom/modules/eventListYLT/eventListYLT.js index 92dbaaf..b85e7fe 100644 --- a/phantomas_custom/modules/eventListYLT/eventListYLT.js +++ b/phantomas_custom/modules/eventListYLT/eventListYLT.js @@ -2,12 +2,13 @@ * Analyzes events bound to DOM elements */ /* global Document: true, Element: true, window: true */ -'use strict'; exports.version = '0.2.a'; exports.module = function(phantomas) { - phantomas.setMetric('eventsBound'); // @desc number of EventTarget.addEventListener calls + 'use strict'; + + phantomas.setMetric('eventsBound'); // @desc number of EventTarget.addEventListener calls // spy calls to EventTarget.addEventListener // @see https://developer.mozilla.org/en-US/docs/Web/API/EventTarget.addEventListener diff --git a/phantomas_custom/modules/windowPerfYLT/windowPerfYLT.js b/phantomas_custom/modules/windowPerfYLT/windowPerfYLT.js index e32339d..656614d 100644 --- a/phantomas_custom/modules/windowPerfYLT/windowPerfYLT.js +++ b/phantomas_custom/modules/windowPerfYLT/windowPerfYLT.js @@ -5,11 +5,12 @@ * @see https://developers.google.com/web/fundamentals/performance/critical-rendering-path/measure-crp */ /* global document: true, window: true */ -'use strict'; exports.version = '1.0.a'; exports.module = function(phantomas) { + 'use strict'; + // times below are calculated relative to performance.timing.responseEnd (#117) phantomas.setMetric('domInteractive'); // @desc time it took to parse the HTML and construct the DOM phantomas.setMetric('domContentLoaded'); // @desc time it took to construct both DOM and CSSOM, no stylesheets that are blocking JavaScript execution (i.e. onDOMReady)