WEBDIENSTE/YellowLabTools
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge phantomas 1.7.0 new functionnalities

Browse Source
This commit is contained in:
Gaël Métais
2014-11-11 23:29:54 +01:00
parent 9249b7ae3e
commit aa34f60ce9
3 changed files with 13 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/node_views/results.html
+2 -2
View File
@@ -132,10 +132,10 @@
</modal-dialog>
</div>
</div>
<div ng-if="duplicatedQueriesCountAll" ng-class="{'warning': duplicatedQueriesCountAll > 500}">
<div ng-if="phantomasResults.metrics.DOMqueriesAvoidable" ng-class="{'warning': phantomasResults.metrics.DOMqueriesAvoidable > 500}">
<div class="label">Avoidable queries</div>
<div class="result">
{{duplicatedQueriesCountAll}}
{{phantomasResults.metrics.DOMqueriesAvoidable}}
<show-offenders modal-title="Duplicated DOM queries" metric-name="DOMqueriesDuplicated" phantomas-results="phantomasResults"></show-offenders>
</div>
<div class="info">
app/public/scripts/resultsCtrl.js
+1 -13
View File
@@ -64,18 +64,6 @@ app.controller('ResultsCtrl', function ($scope) {
}
});
// Read all the duplicated queries and calculate a more appropriated score
$scope.duplicatedQueriesCountAll = 0;
if ($scope.phantomasResults.offenders.DOMqueriesDuplicated) {
var regex = /\): *(\d+) queries$/;
$scope.phantomasResults.offenders.DOMqueriesDuplicated.forEach(function(query) {
var regexResult = regex.exec(query);
if (regexResult) {
$scope.duplicatedQueriesCountAll += parseInt(regexResult[1], 10) - 1;
}
});
}
// Grab the notes
$scope.notations = {
domComplexity: getDomComplexityScore(),
@@ -192,7 +180,7 @@ app.controller('ResultsCtrl', function ($scope) {
var note = 'A';
var score = $scope.phantomasResults.metrics.DOMinserts * 2 +
$scope.phantomasResults.metrics.DOMqueries +
$scope.duplicatedQueriesCountAll * 2 +
$scope.phantomasResults.metrics.DOMqueriesAvoidable * 2 +
$scope.phantomasResults.metrics.eventsBound;
if (score > 300) {
note = 'B';