From acb1b72036d19e6186719cdad989cb6195114884 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Ga=C3=ABl=20M=C3=A9tais?= <gael.metais@gmail.com>
Date: Mon, 1 Feb 2021 16:22:17 +0000
Subject: [PATCH] Remove the CSS Expressions metric, too rare

---
 front/src/views/rule.html             |  5 ----
 lib/metadata/policies.js              | 34 ---------------------------
 lib/metadata/scoreProfileGeneric.json |  1 -
 3 files changed, 40 deletions(-)

diff --git a/front/src/views/rule.html b/front/src/views/rule.html
index 71325d9..1161dd7 100644
--- a/front/src/views/rule.html
+++ b/front/src/views/rule.html
@@ -234,11 +234,6 @@
                         <span ng-if="offender.line !== null && offender.column !== null"> @ {{offender.line}}:{{offender.column}}</span>
                     </div>
 
-                    <div ng-if="policyName === 'cssExpressions'">
-                        {{offender.rule}} {{ '{' + offender.property}}: <b>expression(</b>{{offender.expression}}<b>)</b>}
-                        <span ng-if="offender.line !== null && offender.column !== null"> @ {{offender.line}}:{{offender.column}}</span>
-                    </div>
-
                     <div ng-if="policyName === 'cssImportants'">
                         {{offender.rule}} {{ '{' + offender.property}}: {{offender.value}} <b>!important</b>}
                         <span ng-if="offender.line !== null && offender.column !== null"> @ {{offender.line}}:{{offender.column}}</span>
diff --git a/lib/metadata/policies.js b/lib/metadata/policies.js
index 3f41d5f..8c5d380 100644
--- a/lib/metadata/policies.js
+++ b/lib/metadata/policies.js
@@ -532,40 +532,6 @@ var policies = {
             return offendersHelpers.orderByFile(parsedOffenders);
         }
     },
-    "cssExpressions": {
-        "tool": "phantomas",
-        "label": "CSS expressions",
-        "message": "<p>Such as: expression( document.body.clientWidth > 600 ? \"600px\" : \"auto\" )</p><p>This is a bad practice as it slows down browsers. There are some simpler CSS3 methods for doing this.</p>",
-        "isOkThreshold": 0,
-        "isBadThreshold": 1,
-        "isAbnormalThreshold": 20,
-        "hasOffenders": true,
-        "offendersTransformFn": function(offenders) {
-            var parsedOffenders = offenders.map(function(offender) {
-                var splittedOffender = offendersHelpers.cssOffenderPattern(offender);
-
-                var parts = /^(.*) {([^ ]+): expression\((.*)\)}$/.exec(splittedOffender.css);
-
-                if (!parts) {
-                    debug('cssExpressions offenders transform function error with "%s"', offender);
-                    return {
-                        parseError: offender
-                    };
-                }
-
-                return {
-                    rule: parts[1],
-                    property: parts[2],
-                    expression: parts[3],
-                    file: splittedOffender.file,
-                    line: splittedOffender.line,
-                    column: splittedOffender.column
-                };
-            });
-
-            return offendersHelpers.orderByFile(parsedOffenders);
-        }
-    },
     "cssImportants": {
         "tool": "phantomas",
         "label": "Uses of !important",
diff --git a/lib/metadata/scoreProfileGeneric.json b/lib/metadata/scoreProfileGeneric.json
index 080a18c..14dfd0f 100644
--- a/lib/metadata/scoreProfileGeneric.json
+++ b/lib/metadata/scoreProfileGeneric.json
@@ -74,7 +74,6 @@
                 "cssDuplicatedSelectors": 2,
                 "cssDuplicatedProperties": 1,
                 "cssEmptyRules": 2,
-                "cssExpressions": 1,
                 "cssImportants": 2,
                 "cssOldIEFixes": 1,
                 "cssOldPropertyPrefixes": 1,