From cb46274288f242e008c93f0588ef261227484b02 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Ga=C3=ABl=20M=C3=A9tais?= <gael.metais@gmail.com>
Date: Mon, 25 May 2015 13:33:26 +0200
Subject: [PATCH] New rule: jQuery calls on empty objects

---
 front/src/views/rule.html             | 5 +++++
 lib/metadata/policies.js              | 9 +++++++++
 lib/metadata/scoreProfileGeneric.json | 5 +++--
 3 files changed, 17 insertions(+), 2 deletions(-)

diff --git a/front/src/views/rule.html b/front/src/views/rule.html
index 9014439..72635fa 100644
--- a/front/src/views/rule.html
+++ b/front/src/views/rule.html
@@ -204,6 +204,11 @@
         Please open the <a href="/result/{{runId}}/timeline#filter=queryWithoutResults">JS timeline, filtered by "Queries without results"</a>
     </div>
 
+    <div ng-if="policyName === 'jQueryCallsOnEmptyObject'">
+        <h3>{{rule.value}} offenders</h3>
+        Please open the <a href="/result/{{runId}}/timeline#filter=jQueryCallOnEmptyObject">JS timeline, filtered by "jQuery calls on empty object"</a>
+    </div>
+
     <div ng-if="policyName === 'jQueryNotDelegatedEvents'">
         <h3>{{rule.value}} offenders</h3>
         Please open the <a href="/result/{{runId}}/timeline#filter=eventNotDelegated">JS timeline, filtered by "Events not delegated"</a>
diff --git a/lib/metadata/policies.js b/lib/metadata/policies.js
index e54169b..6cc6045 100644
--- a/lib/metadata/policies.js
+++ b/lib/metadata/policies.js
@@ -351,6 +351,15 @@ var policies = {
         "isAbnormalThreshold": 0,
         "hasOffenders": true
     },
+    "jQueryCallsOnEmptyObject": {
+        "tool": "jsExecutionTransformer",
+        "label": "Calls on empty objects",
+        "message": "<p>This metric counts the number of jQuery functions called on an empty jQuery object. The call was useless.</p><p>This can be helpful to detect dead or unused code.</p>",
+        "isOkThreshold": 1,
+        "isBadThreshold": 100,
+        "isAbnormalThreshold": 180,
+        "hasOffenders": false
+    },
     "jQueryNotDelegatedEvents": {
         "tool": "jsExecutionTransformer",
         "label": "Events not delegated",
diff --git a/lib/metadata/scoreProfileGeneric.json b/lib/metadata/scoreProfileGeneric.json
index 77af6ee..c5def7f 100644
--- a/lib/metadata/scoreProfileGeneric.json
+++ b/lib/metadata/scoreProfileGeneric.json
@@ -36,9 +36,10 @@
         "jQuery": {
             "label": "jQuery",
             "policies": {
-                "jQueryVersion": 1,
-                "jQueryVersionsLoaded": 1,
+                "jQueryVersion": 2,
+                "jQueryVersionsLoaded": 2,
                 "jQueryFunctionsUsed": 1,
+                "jQueryCallsOnEmptyObject": 1,
                 "jQueryNotDelegatedEvents": 1
             }
         },