Fix jsError on an exception inside an eval

2014-12-30 11:19:31 +01:00
parent 5c80f3197a
commit dbde3de8e8
3 changed files with 58 additions and 1 deletions
@@ -0,0 +1,56 @@
+/**
+ * Reports the use of functions known to be serious performance bottlenecks in JS
+ *
+ * @see http://www.nczonline.net/blog/2013/06/25/eval-isnt-evil-just-misunderstood/
+ * @see http://www.quirksmode.org/blog/archives/2005/06/three_javascrip_1.html
+ * @see http://www.stevesouders.com/blog/2012/04/10/dont-docwrite-scripts/
+ */
+/* global document: true, window: true */
+'use strict';
+
+exports.version = '0.1';
+
+exports.module = function(phantomas) {
+    phantomas.setMetric('documentWriteCalls'); //@desc number of calls to either document.write or document.writeln
+    phantomas.setMetric('evalCalls'); // @desc number of calls to eval (either direct or via setTimeout / setInterval)
+
+    phantomas.once('init', function() {
+        phantomas.evaluate(function() {
+            (function(phantomas) {
+                function report(msg, caller, backtrace, metric) {
+                    phantomas.log(msg + ': from ' + caller + '!');
+                    phantomas.log('Backtrace: ' + backtrace);
+                    phantomas.incrMetric(metric);
+                }
+
+                // spy calls to eval()
+                phantomas.spy(window, 'eval', function(code) {
+                    report('eval() called directly', phantomas.getCaller(), phantomas.getBacktrace(), 'evalCalls');
+                    phantomas.log('eval\'ed code: ' + (code || '').substring(0, 150) + '(...)');
+                });
+
+                // spy calls to setTimeout / setInterval with string passed instead of a function
+                phantomas.spy(window, 'setTimeout', function(fn, interval) {
+                    if (typeof fn !== 'string') return;
+
+                    report('eval() called via setTimeout("' + fn + '")', phantomas.getCaller(), phantomas.getBacktrace(), 'evalCalls');
+                });
+
+                phantomas.spy(window, 'setInterval', function(fn, interval) {
+                    if (typeof fn !== 'string') return;
+
+                    report('eval() called via setInterval("' + fn + '")', phantomas.getCaller(), phantomas.getBacktrace(), 'evalCalls');
+                });
+
+                // spy document.write(ln)
+                phantomas.spy(document, 'write', function(arg) {
+                    report('document.write() used', phantomas.getCaller(), phantomas.getBacktrace(), 'documentWriteCalls');
+                });
+
+                phantomas.spy(document, 'writeln', function(arg) {
+                    report('document.writeln() used', phantomas.getCaller(), phantomas.getBacktrace(), 'documentWriteCalls');
+                });
+            })(window.__phantomas);
+        });
+    });
+};