diff --git a/lib/metadata/policies.js b/lib/metadata/policies.js index 44c2fcf..dd51fdf 100644 --- a/lib/metadata/policies.js +++ b/lib/metadata/policies.js @@ -267,7 +267,7 @@ var policies = { }, "jQueryVersion": { "label": "jQuery version", - "message": "
Current latest versions of jQuery are 1.12 (with support for old IE versions) and 2.2 (without).
Each new version of jQuery optimizes performances. Do not keep an old version of jQuery. Updating can sometimes break a few things, but it is generally quite easy to fix them up. So don't hesitate.
", + "message": "The current latest version of jQuery is 3.0
Each new version of jQuery optimizes performances. Do not keep an old version of jQuery. Updating can sometimes break a few things, but it is generally quite easy to fix them up. So don't hesitate.
", "hasOffenders": false, "scoreFn": function(data) { var differentVersions = data.toolsResults.phantomas.metrics.jQueryVersionsLoaded; @@ -279,34 +279,31 @@ var policies = { var value = data.toolsResults.phantomas.metrics.jQueryVersion; var score; - if (value.indexOf('1.12.') === 0 || - value.indexOf('2.2.') === 0 || - value.indexOf('1.13.') === 0 || - value.indexOf('2.3.') === 0 || - value.indexOf('3.0.') === 0 || - value.indexOf('3.1.') === 0) { + if (value.indexOf('3.0.') === 0 || + value.indexOf('3.1.') === 0 || + value.indexOf('3.2.') === 0) { score = 100; + } else if (value.indexOf('1.12.') === 0 || + value.indexOf('2.2.') === 0) { + score = 90; } else if (value.indexOf('1.11.') === 0 || value.indexOf('2.1.') === 0) { - score = 90; + score = 70; } else if (value.indexOf('1.10.') === 0 || value.indexOf('2.0.') === 0) { - score = 70; - } else if (value.indexOf('1.9.') === 0) { score = 50; - } else if (value.indexOf('1.8.') === 0) { + } else if (value.indexOf('1.9.') === 0) { score = 40; - } else if (value.indexOf('1.7') === 0) { + } else if (value.indexOf('1.8.') === 0) { score = 30; - } else if (value.indexOf('1.6') === 0) { + } else if (value.indexOf('1.7') === 0) { score = 20; - } else if (value.indexOf('1.5') === 0) { + } else if (value.indexOf('1.6') === 0) { score = 10; - } else if (value.indexOf('1.4') === 0) { - score = 0; - } else if (value.indexOf('1.3') === 0) { - score = 0; - } else if (value.indexOf('1.2') === 0) { + } else if (value.indexOf('1.5') === 0 || + value.indexOf('1.4') === 0 || + value.indexOf('1.3') === 0 || + value.indexOf('1.2') === 0) { score = 0; } else { debug('Unknown jQuery version "%s"', value); diff --git a/test/core/customPoliciesTest.js b/test/core/customPoliciesTest.js index 2f517cd..a506781 100644 --- a/test/core/customPoliciesTest.js +++ b/test/core/customPoliciesTest.js @@ -184,18 +184,20 @@ describe('customPolicies', function() { var versions = { '1.2.9': 0, '1.4.4': 0, - '1.5.0': 10, - '1.6.3': 20, - '1.7.0': 30, - '1.8.3a': 40, - '1.9.2': 50, - '1.10.1': 70, - '2.0.0-rc1': 70, - '1.11.1': 90, - '2.1.1-beta1': 90, - '1.12.1': 100, - '2.3.1': 100, - '3.1.0': 100 + '1.5.0': 0, + '1.6.3': 10, + '1.7.0': 20, + '1.8.3a': 30, + '1.9.2': 40, + '1.10.1': 50, + '2.0.0-rc1': 50, + '1.11.1': 70, + '2.1.1-beta1': 70, + '1.12.1': 90, + '2.2.1': 90, + '3.0.1': 100, + '3.1.0': 100, + '3.2.1': 100 }; for (var version in versions) {