From f2f27ac6390b70bb1a1781fc3dce0b5e3a91c9cf Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Ga=C3=ABl=20M=C3=A9tais?= <gael.metais@gmail.com>
Date: Tue, 20 Dec 2016 15:20:16 +0800
Subject: [PATCH] Removing the jQuery Usage rule

---
 lib/metadata/policies.js              |  9 ---------
 lib/metadata/scoreProfileGeneric.json |  1 -
 lib/tools/jsExecutionTransformer.js   | 18 ------------------
 3 files changed, 28 deletions(-)

diff --git a/lib/metadata/policies.js b/lib/metadata/policies.js
index 9fc69bf..281e5b8 100644
--- a/lib/metadata/policies.js
+++ b/lib/metadata/policies.js
@@ -343,15 +343,6 @@ var policies = {
         "isAbnormalThreshold": 2,
         "hasOffenders": true
     },
-    "jQueryFunctionsUsed": {
-        "tool": "jsExecutionTransformer",
-        "label": "jQuery usage",
-        "message": "<p>This is the number of different core jQuery functions called on load. This rule is not trying to blame you for using jQuery too much, but the opposite.</p><p>If only a few functions are used, why not trying to get rid of jQuery? Have a look at <a href=\"http://youmightnotneedjquery.com/\" target=\"_blank\">http://youmightnotneedjquery.com</a>.</p>",
-        "isOkThreshold": 15,
-        "isBadThreshold": 6,
-        "isAbnormalThreshold": 0,
-        "hasOffenders": true
-    },
     "jQueryCallsOnEmptyObject": {
         "tool": "jsExecutionTransformer",
         "label": "Calls on empty objects",
diff --git a/lib/metadata/scoreProfileGeneric.json b/lib/metadata/scoreProfileGeneric.json
index 23ce229..de49a41 100644
--- a/lib/metadata/scoreProfileGeneric.json
+++ b/lib/metadata/scoreProfileGeneric.json
@@ -61,7 +61,6 @@
             "policies": {
                 "jQueryVersion": 2,
                 "jQueryVersionsLoaded": 2,
-                "jQueryFunctionsUsed": 1,
                 "jQueryCallsOnEmptyObject": 1,
                 "jQueryNotDelegatedEvents": 1
             }
diff --git a/lib/tools/jsExecutionTransformer.js b/lib/tools/jsExecutionTransformer.js
index 2a6214e..a28cff6 100644
--- a/lib/tools/jsExecutionTransformer.js
+++ b/lib/tools/jsExecutionTransformer.js
@@ -25,11 +25,8 @@ var jsExecutionTransformer = function() {
         var hasjQuery = (data.toolsResults.phantomas.metrics.jQueryVersionsLoaded > 0);
         if (hasjQuery) {
             metrics.jQueryCalls = 0;
-            metrics.jQueryFunctionsUsed = 0;
             metrics.jQueryCallsOnEmptyObject = 0;
             metrics.jQueryNotDelegatedEvents = 0;
-
-            offenders.jQueryFunctionsUsed = [];
         }
 
         try {
@@ -102,21 +99,6 @@ var jsExecutionTransformer = function() {
                     metrics.DOMaccesses += countTreeLeafs(node);
                 });
 
-                // Count the number of different jQuery functions called
-                if (hasjQuery) {
-
-                    jQueryFunctionsCollection.sort().forEach(function(fnName, cnt) {
-                        if (fnName === 'jQuery - find') {
-                            fnName = 'jQuery - $';
-                        }
-                        metrics.jQueryFunctionsUsed ++;
-                        offenders.jQueryFunctionsUsed.push({
-                            functionName: fnName.substring(9),
-                            count: cnt
-                        });
-                    });
-                }
-
             }
             debug('JS execution transformation complete');