chore: Conservative dependency updates for Jinja2 security fix (#14792)

* chore: Conservative dependency updates for security

- Update Ansible from 9.1.0 to 9.2.0 (one minor version bump only)
- Update Jinja2 to ~3.1.6 to fix CVE-2025-27516 (critical security fix)
- Pin netaddr to 1.3.0 (current stable version)

This is a minimal, conservative update focused on:
1. Critical security fix for Jinja2
2. Minor ansible update for bug fixes
3. Pinning netaddr to prevent surprises

No changes to Ansible collections - keeping them unpinned for now.

* fix: Address linter issues (ruff, yamllint, shellcheck)

- Fixed ruff configuration by moving linter settings to [tool.ruff.lint] section
- Fixed ruff code issues:
  - Moved imports to top of files (E402)
  - Removed unused variables or commented them out
  - Updated string formatting from % to .format()
  - Replaced dict() calls with literals
  - Fixed assert False usage in tests
- Fixed yamllint issues:
  - Added missing newlines at end of files
  - Removed trailing spaces
  - Added document start markers (---) to YAML files
  - Fixed 'on:' truthy warnings in GitHub workflows
- Fixed shellcheck issues:
  - Properly quoted variables in shell scripts
  - Fixed A && B || C pattern with proper if/then/else
  - Improved FreeBSD rc script quoting

All linters now pass without errors related to our code changes.

* fix: Additional yamllint fixes for GitHub workflows

- Added document start markers (---) to test-effectiveness.yml
- Fixed 'on:' truthy warning by quoting as 'on:'
- Removed trailing spaces from main.yml
- Added missing newline at end of test-effectiveness.yml

library/digital_ocean_floating_ip.py

@@ -138,9 +138,8 @@ def wait_action(module, rest, ip, action_id, timeout=10):
     end_time = time.time() + 10
     while time.time() < end_time:
         response = rest.get(f'floating_ips/{ip}/actions/{action_id}')
-        status_code = response.status_code
+        # status_code = response.status_code  # TODO: check status_code == 200?
         status = response.json['action']['status']
-        # TODO: check status_code == 200?
         if status == 'completed':
             return True
         elif status == 'errored':
@@ -150,7 +149,7 @@ def wait_action(module, rest, ip, action_id, timeout=10):
 
 
 def core(module):
-    api_token = module.params['oauth_token']
+    # api_token = module.params['oauth_token']  # unused for now
     state = module.params['state']
     ip = module.params['ip']
     droplet_id = module.params['droplet_id']
@@ -185,7 +184,7 @@ def get_floating_ip_details(module, rest):
     if status_code == 200:
         return json_data['floating_ip']
     else:
-        module.fail_json(msg="Error assigning floating ip [{0}: {1}]".format(
+        module.fail_json(msg="Error assigning floating ip [{}: {}]".format(
             status_code, json_data["message"]), region=module.params['region'])
 
 
@@ -205,7 +204,7 @@ def assign_floating_id_to_droplet(module, rest):
 
         module.exit_json(changed=True, data=json_data)
     else:
-        module.fail_json(msg="Error creating floating ip [{0}: {1}]".format(
+        module.fail_json(msg="Error creating floating ip [{}: {}]".format(
             status_code, json_data["message"]), region=module.params['region'])
 
 
@@ -247,26 +246,26 @@ def create_floating_ips(module, rest):
         if status_code == 202:
             module.exit_json(changed=True, data=json_data)
         else:
-            module.fail_json(msg="Error creating floating ip [{0}: {1}]".format(
+            module.fail_json(msg="Error creating floating ip [{}: {}]".format(
                 status_code, json_data["message"]), region=module.params['region'])
 
 
 def main():
     module = AnsibleModule(
-        argument_spec=dict(
-            state=dict(choices=['present', 'absent'], default='present'),
-            ip=dict(aliases=['id'], required=False),
-            region=dict(required=False),
-            droplet_id=dict(required=False, type='int'),
-            oauth_token=dict(
-                no_log=True,
+        argument_spec={
+            'state': {'choices': ['present', 'absent'], 'default': 'present'},
+            'ip': {'aliases': ['id'], 'required': False},
+            'region': {'required': False},
+            'droplet_id': {'required': False, 'type': 'int'},
+            'oauth_token': {
+                'no_log': True,
                 # Support environment variable for DigitalOcean OAuth Token
-                fallback=(env_fallback, ['DO_API_TOKEN', 'DO_API_KEY', 'DO_OAUTH_TOKEN']),
-                required=True,
-            ),
-            validate_certs=dict(type='bool', default=True),
-            timeout=dict(type='int', default=30),
-        ),
+                'fallback': (env_fallback, ['DO_API_TOKEN', 'DO_API_KEY', 'DO_OAUTH_TOKEN']),
+                'required': True,
+            },
+            'validate_certs': {'type': 'bool', 'default': True},
+            'timeout': {'type': 'int', 'default': 30},
+        },
         required_if=[
             ('state', 'delete', ['ip'])
         ],

library/gcp_compute_location_info.py

@@ -2,26 +2,23 @@
 
 
 
+import json
+
+from ansible.module_utils.gcp_utils import GcpModule, GcpSession, navigate_hash
+
 ################################################################################
 # Documentation
 ################################################################################
 
 ANSIBLE_METADATA = {'metadata_version': '1.1', 'status': ["preview"], 'supported_by': 'community'}
 
-################################################################################
-# Imports
-################################################################################
-import json
-
-from ansible.module_utils.gcp_utils import GcpModule, GcpSession, navigate_hash
-
 ################################################################################
 # Main
 ################################################################################
 
 
 def main():
-    module = GcpModule(argument_spec=dict(filters=dict(type='list', elements='str'), scope=dict(required=True, type='str')))
+    module = GcpModule(argument_spec={'filters': {'type': 'list', 'elements': 'str'}, 'scope': {'required': True, 'type': 'str'}})
 
     if module._name == 'gcp_compute_image_facts':
         module.deprecate("The 'gcp_compute_image_facts' module has been renamed to 'gcp_compute_regions_info'", version='2.13')
@@ -59,7 +56,7 @@ def query_options(filters):
         for f in filters:
             # For multiple queries, all queries should have ()
             if f[0] != '(' and f[-1] != ')':
-                queries.append("(%s)" % ''.join(f))
+                queries.append("({})".format(''.join(f)))
             else:
                 queries.append(f)
 
@@ -79,7 +76,7 @@ def return_if_object(module, response):
         module.raise_for_status(response)
         result = response.json()
     except getattr(json.decoder, 'JSONDecodeError', ValueError) as inst:
-        module.fail_json(msg="Invalid JSON response with error: %s" % inst)
+        module.fail_json(msg="Invalid JSON response with error: {}".format(inst))
 
     if navigate_hash(result, ['error', 'errors']):
         module.fail_json(msg=navigate_hash(result, ['error', 'errors']))