Files
algo/roles/common/tasks/ubuntu.yml
T
984831bcab fix: add explicit bool filters for Ansible 12 jinja2_native compatibility (#14963)
* fix: add explicit bool filters for Ansible 12 jinja2_native compatibility

Ansible 12 enables jinja2_native by default, which means string values
like "true"/"false" are no longer automatically coerced to booleans in
when: conditions and Jinja2 if statements. Add | bool filters to all
boolean variable references in tasks, templates, and handlers.

Also reformats long single-line Jinja2 conditionals into multi-line for
readability, fixes GCE default() calls for native mode, adds help
command to the algo script, and updates test fixtures to register the
bool filter.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* ci: add j2lint for Jinja2 template linting

Add j2lint (aristanetworks/j2lint) to catch syntax errors, spacing
issues, and operator formatting in Jinja2 templates. Integrated into
pre-commit hooks, lint.yml CI, and smart-tests.yml.

Rules S3/S5/S6/S7/V1 are ignored — they enforce conventions
incompatible with Ansible's config-file-embedded templates.

Also fixes int+1 → int + 1 operator spacing in server.conf.j2.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* fix: resolve all ansible-lint warnings and enforce zero-tolerance policy

Fix 18 jinja[spacing] errors across 12 files by moving Jinja2 block
delimiters to prevent YAML >- folding from introducing trailing spaces.

Fix 27 key-order[task] warnings across 17 files by reordering task keys
to canonical order (name → when → tags → environment → become → block).

Promote key-order[task] and yaml[line-length] from warn_list to hard
errors by removing warn_list entirely from .ansible-lint.

Add zero-tolerance warning policy to CLAUDE.md explaining why warnings
are unacceptable in a security tool and documenting resolution order.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
2026-02-08 11:21:56 -05:00

186 lines
5.2 KiB
YAML

---
- name: Gather facts
setup:
- name: Cloud only tasks
when: algo_provider != "local"
block:
- name: Install software updates
apt:
update_cache: true
install_recommends: true
upgrade: dist
register: result
until: result is succeeded
retries: 30
delay: 10
- name: Check if reboot is required
shell: |
set -o pipefail
if [[ -e /var/run/reboot-required ]]; then
# Check if kernel was updated (most critical reboot reason)
if grep -q "linux-image\|linux-generic\|linux-headers" /var/log/dpkg.log.1 /var/log/dpkg.log 2>/dev/null; then
echo "kernel-updated"
else
echo "optional"
fi
else
echo "no"
fi
args:
executable: /bin/bash
register: reboot_required
changed_when: false
- name: Reboot (kernel updated or performance optimization disabled)
shell: sleep 2 && shutdown -r now "Ansible updates triggered"
async: 1
poll: 0
when: >
reboot_required is defined and (
reboot_required.stdout == 'kernel-updated' or
(reboot_required.stdout == 'optional' and not performance_skip_optional_reboots|default(false))
)
changed_when: true
failed_when: false
- name: Skip reboot (performance optimization enabled)
debug:
msg: "Skipping reboot - performance optimization enabled. No kernel updates detected."
when: >
reboot_required is defined and
reboot_required.stdout == 'optional' and
performance_skip_optional_reboots|default(false)
- name: Wait until the server becomes ready...
wait_for_connection:
delay: 20
timeout: 320
when: >
reboot_required is defined and (
reboot_required.stdout == 'kernel-updated' or
(reboot_required.stdout == 'optional' and not performance_skip_optional_reboots|default(false))
)
become: false
- name: Include unattended upgrades configuration
import_tasks: unattended-upgrades.yml
- name: Disable MOTD on login and SSHD
replace: dest="{{ item.file }}" regexp="{{ item.regexp }}" replace="{{ item.line }}"
become: true
loop:
- { regexp: ^session.*optional.*pam_motd.so.*, line: "# MOTD DISABLED", file: /etc/pam.d/login }
- { regexp: ^session.*optional.*pam_motd.so.*, line: "# MOTD DISABLED", file: /etc/pam.d/sshd }
- name: Ensure fallback resolvers are set
ini_file:
path: /etc/systemd/resolved.conf
section: Resolve
option: FallbackDNS
value: "{{ dns_servers.ipv4 | join(' ') }}"
mode: '0644'
notify:
- restart systemd-resolved
- name: Loopback for services configured
template:
src: 10-algo-lo100.network.j2
dest: /etc/systemd/network/10-algo-lo100.network
mode: '0644'
notify:
- restart systemd-networkd
- name: systemd services enabled and started
systemd:
name: "{{ item }}"
state: started
enabled: true
daemon_reload: true
loop:
- systemd-networkd
- systemd-resolved
- meta: flush_handlers
- name: Check apparmor support
command: apparmor_status
failed_when: false
changed_when: false
register: apparmor_status
- name: Set fact if apparmor enabled
set_fact:
apparmor_enabled: true
when: '"profiles are in enforce mode" in apparmor_status.stdout'
- name: Gather additional facts
import_tasks: facts.yml
- name: Set OS specific facts
set_fact:
tools:
- git
- screen
- apparmor-utils
- uuid-runtime
- coreutils
- iptables
- iptables-persistent
- cgroup-tools
- openssl
- gnupg2
- cron
# yamllint disable-line rule:line-length
sysctl: "{{ [{'item': 'net.ipv4.ip_forward', 'value': 1}, {'item': 'net.ipv4.conf.all.forwarding', 'value': 1}, {'item': 'net.ipv4.conf.all.route_localnet', 'value': 1}] + ([{'item': 'net.ipv6.conf.all.forwarding', 'value': 1}] if ipv6_support | bool else []) }}"
- name: Install packages (batch optimization)
include_tasks: packages.yml
when: performance_parallel_packages | default(true)
- name: Install tools (legacy method)
apt:
name: "{{ tools | default([]) }}"
state: present
update_cache: true
when:
- not performance_parallel_packages | default(true)
- not performance_preinstall_packages | default(false)
- name: Install headers (legacy method)
apt:
name:
- linux-headers-generic
- linux-headers-{{ ansible_kernel }}
state: present
when:
- not performance_parallel_packages | default(true)
- install_headers | bool
- name: Configure the alternative ingress ip
include_tasks: aip/main.yml
when: alternative_ingress_ip | bool
- name: Ubuntu 22.04+ | Use iptables-legacy for compatibility
when: is_ubuntu_22_plus
tags: iptables
block:
- name: Install iptables packages
apt:
name:
- iptables
- iptables-persistent
state: present
update_cache: true
- name: Configure iptables-legacy as default
alternatives:
name: "{{ item }}"
path: "/usr/sbin/{{ item }}-legacy"
loop:
- iptables
- ip6tables
- include_tasks: iptables.yml
tags: iptables