WEBDIENSTE/appointment-booking-software
1
0
Fork 0
mirror of https://github.com/open-reception/appointment-booking-software.git synced 2026-08-17 21:25:52 +02:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #299 from open-reception/fix/passkeys-work-with-plain-array-prf-response

Browse Source 
Passkeys now work with plain Array prf responses
This commit is contained in:
Karl Ludwig Weise
2026-06-19 16:01:25 +02:00
committed by GitHub
parent 6ccfb5c6b4 b0d6b2b4b8
commit a03102b433
1 changed files with 24 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/lib/utils/passkey.ts
+24 -32
View File
@@ -251,21 +251,31 @@ export const getPRFOutputAfterRegistration = async ({
}
// PRF output is BufferSource, ensure we return ArrayBuffer
const prfOutput = prfResults.results.first;
if (prfOutput instanceof ArrayBuffer) {
return prfOutput;
} else {
// Convert ArrayBufferView to ArrayBuffer
console.log("⚠️ Detected non-ArrayBuffer PRF output, trying to convert manually");
return prfOutput.buffer.slice(
prfOutput.byteOffset,
prfOutput.byteOffset + prfOutput.byteLength,
) as ArrayBuffer;
return getPrfOutput(prfResults.results);
};
const getPrfOutput = (results: AuthenticationExtensionsPRFValues): ArrayBuffer => {
const first = prfResultsToArrayBuffer(results.first);
return first.buffer;
};
const prfResultsToArrayBuffer = (result: BufferSource): Uint8Array<ArrayBuffer> => {
if (result instanceof ArrayBuffer) {
return new Uint8Array(result);
}
if (ArrayBuffer.isView(result)) {
return new Uint8Array(result.buffer as ArrayBuffer, result.byteOffset, result.byteLength);
}
if (Array.isArray(result)) {
console.log("⚠️ Detected non-ArrayBuffer PRF output, trying to convert manually");
return Uint8Array.from(result as number[]);
}
throw Error("PRF result is not convertible");
};
export type GetCredentialResponse = PublicKeyCredential & {
prfOutput?: ArrayBuffer; // PRF output if enablePRF was true
prfOutput?: ArrayBuffer;
};
export const getCredential = async ({
@@ -320,27 +330,9 @@ export const getCredential = async ({
// Extract PRF output if it was enabled
if (enablePRF) {
const extensionResults = credential.getClientExtensionResults() as {
prf?: {
enabled?: boolean;
results?: {
first?: BufferSource;
};
};
};
if (extensionResults.prf?.results?.first) {
const prfResult = extensionResults.prf.results.first;
// Convert BufferSource to ArrayBuffer
if (prfResult instanceof ArrayBuffer) {
prfOutput = prfResult;
} else {
console.log("⚠️ Detected non-ArrayBuffer PRF output, trying to convert manually");
prfOutput = prfResult.buffer.slice(
prfResult.byteOffset,
prfResult.byteOffset + prfResult.byteLength,
) as ArrayBuffer;
}
const extensionResults = credential.getClientExtensionResults();
if (extensionResults.prf?.results) {
prfOutput = getPrfOutput(extensionResults.prf.results);
}
}