qfix: ensure target mappings are not undefined (#7936)

Signed-off-by: Alexander Onnikov <Alexander.Onnikov@xored.com>
This commit is contained in:
Alexander Onnikov
2025-02-05 22:43:25 +07:00
committed by GitHub
parent 62dfae97cb
commit 30839b6ba5
2 changed files with 5 additions and 5 deletions
@@ -214,7 +214,7 @@ export abstract class IssueSyncManagerBase {
const target: IssueSyncTarget | undefined =
milestone !== undefined
? {
mappings: milestone.mappings,
mappings: milestone.mappings ?? [],
project: prj,
target: milestone
}
@@ -1161,7 +1161,7 @@ export abstract class IssueSyncManagerBase {
}
return {
project,
mappings: milestone.mappings,
mappings: milestone.mappings ?? [],
target: milestone,
prjData: external.projectItems.nodes.find((it) => it.project.id === milestone.projectNodeId)
}
@@ -1172,7 +1172,7 @@ export abstract class IssueSyncManagerBase {
getProjectIssueTarget (project: GithubProject, external?: IssueExternalData): IssueSyncTarget {
return {
project,
mappings: project.mappings,
mappings: project.mappings ?? [],
target: project,
prjData: external?.projectItems.nodes.find((it) => it.project.id === project.projectNodeId)
}
@@ -608,7 +608,7 @@ export class ProjectsSyncManager implements DocSyncManager {
okit: Octokit
): Promise<{ projectStructure: GithubProjectV2, wasUpdates: boolean, mappings: GithubFieldMapping[] }> {
let projectStructure = await this.queryProjectStructure(integration, target)
let mappings = target.mappings
let mappings = target.mappings ?? []
if (projectStructure === undefined) {
if (this.client.getHierarchy().isDerived(tracker.class.Project, target._class)) {
@@ -651,7 +651,7 @@ export class ProjectsSyncManager implements DocSyncManager {
const mHash = JSON.stringify(mappings)
// Create any platform field into matching github field
for (const [, f] of allFields.entries()) {
const existingField = (mappings ?? []).find((it) => it._id === f._id)
const existingField = mappings.find((it) => it._id === f._id)
if (f.hidden === true) {
continue
}