From 3910f2d1f969f61c3c2ef0f86b6451deb94d386e Mon Sep 17 00:00:00 2001 From: Denis Bykhov Date: Tue, 30 May 2023 14:42:02 +0600 Subject: [PATCH] UBER-316 Date picker is not editable by keyboard (#3283) Signed-off-by: Denis Bykhov --- .../ui/src/components/calendar/DateInputBox.svelte | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/packages/ui/src/components/calendar/DateInputBox.svelte b/packages/ui/src/components/calendar/DateInputBox.svelte index 2625e0928d..1e2752b862 100644 --- a/packages/ui/src/components/calendar/DateInputBox.svelte +++ b/packages/ui/src/components/calendar/DateInputBox.svelte @@ -105,8 +105,10 @@ edits = edits } - export const isNull = (currentDate: Date | null, full: boolean = false): boolean => { - dateToEdits(currentDate) + export const isNull = (currentDate: Date | null | undefined = undefined, full: boolean = false): boolean => { + if (currentDate !== undefined) { + dateToEdits(currentDate) + } let result: boolean = false edits.forEach((edit, i) => { if (edit.value === -1 && full && i > 2) result = true @@ -134,7 +136,7 @@ } else { edits[index].value = edits[index].value * 10 + num } - if (!isNull(currentDate, false) && !startTyping) { + if (!isNull() && !startTyping) { fixEdits() currentDate = setValue(edits[index].value, currentDate, ed) dateToEdits(currentDate) @@ -148,7 +150,7 @@ else if (selected === 'hour' && (shouldNext || edits[3].value > 2)) selected = 'min' } if (ev.code === 'Enter') { - if (!isNull(currentDate, false)) dispatch('close') + if (!isNull(currentDate)) dispatch('close') } if (ev.code === 'Backspace') { edits[index].value = -1