WEBDIENSTE/huly-platform
1
0
Fork 0
mirror of https://github.com/hcengineering/platform.git synced 2026-08-21 11:52:23 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fix null error in getReviewers (#10229)

Browse Source 
* Fix null error in getReviewers

Signed-off-by: Artem Savchenko <armisav@gmail.com>

* Fix validate

Signed-off-by: Artem Savchenko <armisav@gmail.com>

* Fix code style

Signed-off-by: Artem Savchenko <armisav@gmail.com>

---------

Signed-off-by: Artem Savchenko <armisav@gmail.com>
This commit is contained in:
Artyom Savchenko
2025-11-19 15:18:15 +07:00
committed by GitHub
parent 1150f0c0b1
commit 400e9e9fcf
2 changed files with 246 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
services/github/pod-github/src/sync/pullrequests.ts
+8 -2
View File
@@ -317,7 +317,10 @@ export class PullRequestSyncManager extends IssueSyncManagerBase implements DocS
async getReviewers (issue: PullRequestExternalData): Promise<PersonId[]> {
// Find Assignees and reviewers
const ids: UserInfo[] = (issue.reviewRequests.nodes ?? []).map((it: any) => it.requestedReviewer)
const ids: UserInfo[] = (issue.reviewRequests?.nodes ?? [])
.filter((it: any) => it != null)
.map((it: any) => it.requestedReviewer)
.filter((id: any) => id != null)
const values: PersonId[] = []
@@ -328,7 +331,10 @@ export class PullRequestSyncManager extends IssueSyncManagerBase implements DocS
}
}
for (const n of issue.latestReviews.nodes ?? []) {
for (const n of issue.latestReviews?.nodes ?? []) {
if (n?.author == null) {
continue
}
const acc = await this.provider.getAccount(n.author)
if (acc !== undefined) {
values.push(acc)