From ba9131545d2841a73b7586ee53e50652520bcec1 Mon Sep 17 00:00:00 2001 From: Andrey Sobolev Date: Mon, 16 Jun 2025 19:30:11 +0700 Subject: [PATCH] QFIX: Empty comments in github (#9258) Signed-off-by: Andrey Sobolev --- services/github/pod-github/src/sync/comments.ts | 5 +++-- services/github/pod-github/src/worker.ts | 7 ++++++- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/services/github/pod-github/src/sync/comments.ts b/services/github/pod-github/src/sync/comments.ts index f2f8594b87..9db66c2883 100644 --- a/services/github/pod-github/src/sync/comments.ts +++ b/services/github/pod-github/src/sync/comments.ts @@ -420,13 +420,14 @@ export class CommentSyncManager implements DocSyncManager { url: (result?.data.url ?? '').toLowerCase(), external: result?.data as CommentExternalData, current: result?.data, - repository: repo._id + repository: repo._id, + needSync: githubSyncVersion } // We need to update in current promise, to prevent event changes. await derivedClient.update(info, upd) } - return {} + return { needSync: githubSyncVersion } } catch (err: any) { Analytics.handleError(err) this.ctx.error(err) diff --git a/services/github/pod-github/src/worker.ts b/services/github/pod-github/src/worker.ts index b7fc5f1433..cf9356be24 100644 --- a/services/github/pod-github/src/worker.ts +++ b/services/github/pod-github/src/worker.ts @@ -1476,7 +1476,12 @@ export class GithubWorker implements IntegrationManager { 'sync doc', {}, (ctx) => mapper.sync(existing, info, parent, derivedClient), - { url: info.url.toLowerCase(), workspace: this.workspace.uuid, existing: existing !== undefined } + { + url: info.url.toLowerCase(), + workspace: this.workspace.uuid, + existing: existing !== undefined, + objectClass: info.objectClass + } ) if (docUpdate !== undefined) { await derivedClient.update(info, docUpdate)