From d4517bbbdb50b90db1535dcf559974477d4976a5 Mon Sep 17 00:00:00 2001
From: Victor Ilyushchenko <alt13ri@gmail.com>
Date: Mon, 21 Apr 2025 12:25:27 +0300
Subject: [PATCH] EQMS-1484: Fixed permission checks when sending a QMS
 document for approval from the Workflow Validation tab (#8628)

Signed-off-by: Victor Ilyushchenko <alt13ri@gmail.com>
---
 .../right-panel/DocumentApprovalGuideItem.svelte   |  7 +++++--
 .../right-panel/DocumentApprovalsTab.svelte        |  6 ++++--
 .../stores/editors/document/canSendForApproval.ts  | 14 ++++++++++++--
 .../stores/editors/document/canSendForReview.ts    |  5 +++--
 4 files changed, 24 insertions(+), 8 deletions(-)

diff --git a/plugins/controlled-documents-resources/src/components/document/right-panel/DocumentApprovalGuideItem.svelte b/plugins/controlled-documents-resources/src/components/document/right-panel/DocumentApprovalGuideItem.svelte
index 49a007d959..75f66fb04c 100644
--- a/plugins/controlled-documents-resources/src/components/document/right-panel/DocumentApprovalGuideItem.svelte
+++ b/plugins/controlled-documents-resources/src/components/document/right-panel/DocumentApprovalGuideItem.svelte
@@ -1,5 +1,5 @@
 <script lang="ts">
-  import documents from '@hcengineering/controlled-documents'
+  import documents, { ControlledDocumentState } from '@hcengineering/controlled-documents'
   import { Label, Button, showPopup } from '@hcengineering/ui'
 
   import TeamPopup from '../../TeamPopup.svelte'
@@ -15,9 +15,12 @@
       return
     }
 
+    const isReviewed = $controlledDocument.controlledState === ControlledDocumentState.Reviewed
+
     const teamPopupData: TeamPopupData = {
       controlledDoc: $controlledDocument,
-      requestClass: documents.class.DocumentApprovalRequest
+      requestClass: documents.class.DocumentApprovalRequest,
+      requireSignature: !isReviewed
     }
 
     showPopup(TeamPopup, teamPopupData, 'center')
diff --git a/plugins/controlled-documents-resources/src/components/document/right-panel/DocumentApprovalsTab.svelte b/plugins/controlled-documents-resources/src/components/document/right-panel/DocumentApprovalsTab.svelte
index 7dd4ae3d06..28dab8f387 100644
--- a/plugins/controlled-documents-resources/src/components/document/right-panel/DocumentApprovalsTab.svelte
+++ b/plugins/controlled-documents-resources/src/components/document/right-panel/DocumentApprovalsTab.svelte
@@ -15,7 +15,8 @@
   import documentsRes from '../../../plugin'
   import {
     $controlledDocument as controlledDocument,
-    $documentSnapshots as documentSnapshots
+    $documentSnapshots as documentSnapshots,
+    $isDocumentOwner as isDocumentOwner
   } from '../../../stores/editors/document'
   import DocumentApprovalGuideItem from './DocumentApprovalGuideItem.svelte'
   import DocumentApprovalItem from './DocumentApprovalItem.svelte'
@@ -61,7 +62,8 @@
     ControlledDocumentState.Rejected,
     ControlledDocumentState.InApproval
   ]
-  $: hasGuide = doc && doc.state === DocumentState.Draft && !noGuideStates.includes(doc.controlledState)
+  $: hasGuide =
+    doc && doc.state === DocumentState.Draft && !noGuideStates.includes(doc.controlledState) && $isDocumentOwner
 </script>
 
 <RightPanelTabHeader>
diff --git a/plugins/controlled-documents-resources/src/stores/editors/document/canSendForApproval.ts b/plugins/controlled-documents-resources/src/stores/editors/document/canSendForApproval.ts
index da89eedd2f..34d4257aa1 100644
--- a/plugins/controlled-documents-resources/src/stores/editors/document/canSendForApproval.ts
+++ b/plugins/controlled-documents-resources/src/stores/editors/document/canSendForApproval.ts
@@ -17,7 +17,14 @@ import { ControlledDocumentState, DocumentState } from '@hcengineering/controlle
 import { TrainingState } from '@hcengineering/training'
 import { combine } from 'effector'
 import { $documentComments } from './documentComments'
-import { $controlledDocument, $documentState, $isLatestVersion, $reviewRequestHistory, $training } from './editor'
+import {
+  $controlledDocument,
+  $documentState,
+  $isDocumentOwner,
+  $isLatestVersion,
+  $reviewRequestHistory,
+  $training
+} from './editor'
 
 export const $canSendForApproval = combine(
   $controlledDocument,
@@ -26,7 +33,10 @@ export const $canSendForApproval = combine(
   $documentComments,
   $training,
   $reviewRequestHistory,
-  (document, isLatestVersion, state, comments, training, reviewHistory) => {
+  $isDocumentOwner,
+  (document, isLatestVersion, state, comments, training, reviewHistory, isDocumentOwner) => {
+    if (!isDocumentOwner) return false
+
     let haveBeenReviewedOnce = false
     if (document !== null) {
       const reviews = (reviewHistory ?? []).filter((review) => review.attachedTo === document._id)
diff --git a/plugins/controlled-documents-resources/src/stores/editors/document/canSendForReview.ts b/plugins/controlled-documents-resources/src/stores/editors/document/canSendForReview.ts
index 6203507e2e..b91b107e02 100644
--- a/plugins/controlled-documents-resources/src/stores/editors/document/canSendForReview.ts
+++ b/plugins/controlled-documents-resources/src/stores/editors/document/canSendForReview.ts
@@ -15,10 +15,11 @@
 
 import { DocumentState } from '@hcengineering/controlled-documents'
 import { combine } from 'effector'
-import { $documentState, $isLatestVersion } from './editor'
+import { $documentState, $isDocumentOwner, $isLatestVersion } from './editor'
 
 export const $canSendForReview = combine(
   $isLatestVersion,
   $documentState,
-  (isLatestVersion, state) => isLatestVersion && state === DocumentState.Draft
+  $isDocumentOwner,
+  (isLatestVersion, state, isDocumentOwner) => isLatestVersion && state === DocumentState.Draft && isDocumentOwner
 )