From d7fa8c3800ca803e999276cd7d0775f2ddff5185 Mon Sep 17 00:00:00 2001
From: Alexander Platov <sas_lord@mail.ru>
Date: Wed, 6 Sep 2023 14:41:51 +0300
Subject: [PATCH] Activity: remove inline from presenters. DoneStatesPopup fix.
 (#3664)

Signed-off-by: Alexander Platov <sas_lord@mail.ru>
---
 .../src/components/TxView.svelte              | 24 +++++++++----------
 .../src/components/TxViewTx.svelte            |  8 +++----
 .../activity/TxBacklinkReference.svelte       |  2 +-
 .../components/state/DoneStatesPopup.svelte   |  2 ++
 .../components/activity/TxIssueCreated.svelte |  2 +-
 5 files changed, 20 insertions(+), 18 deletions(-)

diff --git a/plugins/activity-resources/src/components/TxView.svelte b/plugins/activity-resources/src/components/TxView.svelte
index af8e3a344d..c3c7d69ffa 100644
--- a/plugins/activity-resources/src/components/TxView.svelte
+++ b/plugins/activity-resources/src/components/TxView.svelte
@@ -247,7 +247,7 @@
                     {#if value.isObjectAdded}
                       <ObjectPresenter value={cvalue} inline accent />
                     {:else}
-                      <svelte:component this={m.presenter} value={cvalue} inline accent />
+                      <svelte:component this={m.presenter} value={cvalue} accent />
                     {/if}
                   {/each}
                 {:else if value.removed.length}
@@ -256,9 +256,9 @@
                   <span class="lower"><Label label={m.label} /></span>
                   {#each value.removed as cvalue}
                     {#if value.isObjectRemoved}
-                      <ObjectPresenter value={cvalue} inline accent />
+                      <ObjectPresenter value={cvalue} accent />
                     {:else}
-                      <svelte:component this={m.presenter} value={cvalue} inline accent />
+                      <svelte:component this={m.presenter} value={cvalue} accent />
                     {/if}
                   {/each}
                 {:else if value.set === null || value.set === undefined || value.set === ''}
@@ -272,9 +272,9 @@
                     <span class="lower"><Label label={activity.string.To} /></span>
                     <span class="strong overflow-label">
                       {#if value.isObjectSet}
-                        <ObjectPresenter value={value.set} inline accent />
+                        <ObjectPresenter value={value.set} accent />
                       {:else}
-                        <svelte:component this={m.presenter} value={value.set} inline accent />
+                        <svelte:component this={m.presenter} value={value.set} accent />
                       {/if}
                     </span>
                   {:else}
@@ -300,9 +300,9 @@
                   {#if !hasMessageType}
                     <div class="strong overflow-label">
                       {#if value.isObjectSet}
-                        <ObjectPresenter value={value.set} inline accent />
+                        <ObjectPresenter value={value.set} accent />
                       {:else}
-                        <svelte:component this={m.presenter} value={value.set} inline accent />
+                        <svelte:component this={m.presenter} value={value.set} accent />
                       {/if}
                     </div>
                   {/if}
@@ -313,9 +313,9 @@
             {#if tx.collectionAttribute !== undefined && (tx.txDocIds?.size ?? 0) > 1}
               <TxViewTx {tx} {onCancelEdit} {edit} {viewlet} />
             {:else if typeof viewlet.component === 'string'}
-              <Component is={viewlet.component} {props} on:close={onCancelEdit} inline />
+              <Component is={viewlet.component} {props} on:close={onCancelEdit} />
             {:else}
-              <svelte:component this={viewlet.component} {...props} on:close={onCancelEdit} inline />
+              <svelte:component this={viewlet.component} {...props} on:close={onCancelEdit} />
             {/if}
           {/if}
         </div>
@@ -355,9 +355,9 @@
           <div class="activity-content content" class:indent={isAttached} class:contentHidden>
             <ShowMore ignore={edit || prevValue !== undefined}>
               {#if value.isObjectSet}
-                <ObjectPresenter value={value.set} inline />
+                <ObjectPresenter value={value.set} />
               {:else if showDiff}
-                <svelte:component this={model[0].presenter} value={value.set} inline {prevValue} showOnlyDiff />
+                <svelte:component this={model[0].presenter} value={value.set} {prevValue} showOnlyDiff />
               {/if}
             </ShowMore>
           </div>
@@ -410,7 +410,7 @@
       }
       .msgactivity-content__title {
         display: inline-flex;
-        align-items: baseline;
+        align-items: center;
         flex-grow: 1;
         min-width: 0;
       }
diff --git a/plugins/activity-resources/src/components/TxViewTx.svelte b/plugins/activity-resources/src/components/TxViewTx.svelte
index 61cdcde672..ae35e73f1f 100644
--- a/plugins/activity-resources/src/components/TxViewTx.svelte
+++ b/plugins/activity-resources/src/components/TxViewTx.svelte
@@ -27,9 +27,9 @@
     <IconAdd size={'x-small'} fill={'var(--theme-trans-color)'} />
   {/if}
   {#if typeof viewlet?.component === 'string'}
-    <Component is={viewlet?.component} props={getProps(ctx, edit)} disabled inline on:close={onCancelEdit} />
+    <Component is={viewlet?.component} props={getProps(ctx, edit)} disabled on:close={onCancelEdit} />
   {:else}
-    <svelte:component this={viewlet?.component} {...getProps(ctx, edit)} disabled inline on:close={onCancelEdit} />
+    <svelte:component this={viewlet?.component} {...getProps(ctx, edit)} disabled on:close={onCancelEdit} />
   {/if}
   <div class="antiHSpacer" />
 {/each}
@@ -38,9 +38,9 @@
     <IconDelete size={'x-small'} fill={'var(--theme-trans-color)'} />
   {/if}
   {#if typeof viewlet?.component === 'string'}
-    <Component is={viewlet?.component} props={getProps(ctx, edit)} disabled inline on:close={onCancelEdit} />
+    <Component is={viewlet?.component} props={getProps(ctx, edit)} disabled on:close={onCancelEdit} />
   {:else}
-    <svelte:component this={viewlet?.component} {...getProps(ctx, edit)} disabled inline on:close={onCancelEdit} />
+    <svelte:component this={viewlet?.component} {...getProps(ctx, edit)} disabled on:close={onCancelEdit} />
   {/if}
   <div class="antiHSpacer" />
 {/each}
diff --git a/plugins/chunter-resources/src/components/activity/TxBacklinkReference.svelte b/plugins/chunter-resources/src/components/activity/TxBacklinkReference.svelte
index 191760459b..c006868121 100644
--- a/plugins/chunter-resources/src/components/activity/TxBacklinkReference.svelte
+++ b/plugins/chunter-resources/src/components/activity/TxBacklinkReference.svelte
@@ -47,6 +47,6 @@
 
 {#if presenter}
   <span class="labels-row">
-    <svelte:component this={presenter.presenter} value={doc} inline disabled />
+    <svelte:component this={presenter.presenter} value={doc} disabled />
   </span>
 {/if}
diff --git a/plugins/task-resources/src/components/state/DoneStatesPopup.svelte b/plugins/task-resources/src/components/state/DoneStatesPopup.svelte
index 1c0d3362e9..63b00684c2 100644
--- a/plugins/task-resources/src/components/state/DoneStatesPopup.svelte
+++ b/plugins/task-resources/src/components/state/DoneStatesPopup.svelte
@@ -54,6 +54,7 @@
 </script>
 
 <div class="selectPopup" use:resizeObserver={() => dispatch('changeContent')}>
+  <div class="menu-space" />
   <div class="scroll">
     <div class="box">
       {#each states as state}
@@ -80,4 +81,5 @@
       </button>
     </div>
   </div>
+  <div class="menu-space" />
 </div>
diff --git a/plugins/tracker-resources/src/components/activity/TxIssueCreated.svelte b/plugins/tracker-resources/src/components/activity/TxIssueCreated.svelte
index aa6863d598..6c74355ee2 100644
--- a/plugins/tracker-resources/src/components/activity/TxIssueCreated.svelte
+++ b/plugins/tracker-resources/src/components/activity/TxIssueCreated.svelte
@@ -28,5 +28,5 @@
   <Label label={isSub ? tracker.string.CreatedSubIssue : tracker.string.CreatedIssue} />
 </div>
 {#if !isOwnTx}
-  <IssuePresenter {value} inline />
+  <IssuePresenter {value} />
 {/if}