From e7b6522e801134ca2851968c47d49dc20e364ba2 Mon Sep 17 00:00:00 2001 From: Alexander Platov Date: Thu, 6 Jul 2023 10:01:27 +0300 Subject: [PATCH] UBER-142: update buttons. Cleaning CSS. (#3482) Signed-off-by: Alexander Platov --- dev/storybook/stories/Button.stories.ts | 8 +- models/tracker/src/index.ts | 10 +- .../kanban/src/components/KanbanRow.svelte | 2 +- .../presentation/src/components/Card.svelte | 7 +- .../src/components/DocPopup.svelte | 2 +- .../InlineAttributeBarEditor.svelte | 2 +- .../src/components/MessageBox.svelte | 2 +- .../src/components/PDFViewer.svelte | 6 +- .../src/components/SpaceCreateCard.svelte | 2 +- .../src/components/SpacesMultiPopup.svelte | 6 +- .../src/components/message/Nodes.svelte | 2 +- .../src/components/ReferenceInput.svelte | 20 +- .../src/components/StyleButton.svelte | 2 +- packages/theme/styles/_colors.scss | 85 +++-- packages/theme/styles/_layouts.scss | 8 +- packages/theme/styles/button.scss | 356 +++++++----------- packages/theme/styles/common.scss | 2 +- packages/theme/styles/components.scss | 24 +- packages/theme/styles/global.scss | 2 +- packages/theme/styles/popups.scss | 2 +- packages/theme/styles/prose.scss | 4 +- packages/ui/src/components/ActionIcon.svelte | 2 +- packages/ui/src/components/Button.svelte | 16 +- packages/ui/src/components/CheckBox.svelte | 16 +- .../components/CheckBoxWithLabel.svelte.txt | 2 +- .../ui/src/components/CircleButton.svelte | 22 +- packages/ui/src/components/Dialog.svelte | 2 +- .../src/components/DropdownRecordPopup.svelte | 2 +- .../ui/src/components/EditWithIcon.svelte | 2 +- packages/ui/src/components/Like.svelte | 6 +- packages/ui/src/components/MiniToggle.svelte | 4 +- packages/ui/src/components/Panel.svelte | 8 +- .../ui/src/components/PanelInstance.svelte | 1 + .../ui/src/components/ProgressCircle.svelte | 4 +- packages/ui/src/components/Scroller.svelte | 2 +- packages/ui/src/components/StepsDialog.svelte | 6 +- packages/ui/src/components/StylishEdit.svelte | 2 +- packages/ui/src/components/TabList.svelte | 12 +- packages/ui/src/components/TextArea.svelte | 2 +- packages/ui/src/components/Toggle.svelte | 4 +- .../components/calendar/DateInputBox.svelte | 8 +- .../src/components/calendar/DatePopup.svelte | 2 +- .../components/calendar/DatePresenter.svelte | 8 +- .../calendar/DateRangePresenter.svelte | 10 +- .../ui/src/components/calendar/Month.svelte | 8 +- .../components/calendar/MonthCalendar.svelte | 2 +- .../components/calendar/MonthSquare.svelte | 8 +- .../components/calendar/RangeDatePopup.svelte | 2 +- .../components/calendar/WeekCalendar.svelte | 2 +- packages/ui/src/types.ts | 14 +- .../src/components/AccordionEditor.svelte | 2 +- .../src/components/AddAttachment.svelte | 2 +- .../AttachmentGalleryPresenter.svelte | 4 +- .../src/components/AttachmentPresenter.svelte | 6 +- .../src/components/AttachmentStyledBox.svelte | 2 +- .../src/components/Attachments.svelte | 2 +- .../src/components/FileBrowserFilters.svelte | 8 +- .../src/components/Photos.svelte | 3 +- .../src/components/AddActionTrigger.svelte | 2 +- .../src/components/AddAutomation.svelte | 2 +- .../src/components/AutomationActions.svelte | 2 +- .../AutomationSettingsElement.svelte | 2 +- .../src/components/AutomationTrigger.svelte | 2 +- .../actions/ContentActionCreate.svelte | 2 +- .../components/selectors/IconChooser.svelte | 2 +- .../CreateHRApplicationMapping.svelte | 6 +- .../src/components/AddPanel.svelte | 2 +- .../src/components/BoardHeader.svelte | 2 +- .../src/components/BoardMenu.svelte | 4 +- .../src/components/EditCard.svelte | 2 +- .../src/components/KanbanCard.svelte | 6 +- .../src/components/ListHeader.svelte | 2 +- .../src/components/add-card/AddCard.svelte | 2 +- .../components/editor/CardChecklist.svelte | 8 +- .../components/popups/CardCoverPicker.svelte | 2 +- .../components/popups/DateRangePicker.svelte | 2 +- .../presenters/ChecklistsPresenter.svelte | 2 +- .../presenters/DatePresenter.svelte | 4 +- .../src/components/CalendarView.svelte | 6 +- .../src/components/CreateEvent.svelte | 6 +- .../src/components/CreateReminder.svelte | 4 +- .../src/components/Day.svelte | 8 +- .../src/components/DocReminder.svelte | 2 +- .../src/components/DocRemindersPopup.svelte | 2 +- .../src/components/Events.svelte | 2 +- .../src/components/ChunterBrowser.svelte | 8 +- .../activity/TxCommentCreate.svelte | 2 +- .../src/components/AssigneeBox.svelte | 2 +- .../src/components/ChannelEditor.svelte | 10 +- .../src/components/Contacts.svelte | 2 +- .../src/components/CreateEmployee.svelte | 2 +- .../src/components/CreateMember.svelte | 2 +- .../src/components/CreateOrganization.svelte | 4 +- .../src/components/CreatePerson.svelte | 2 +- .../src/components/EditAvatarPopup.svelte | 2 +- .../src/components/EditOrganization.svelte | 4 +- .../components/EmployeeRefPresenter.svelte | 2 +- .../src/components/Members.svelte | 4 +- .../src/components/PersonContent.svelte | 2 +- .../src/components/UserBoxItems.svelte | 2 +- .../src/components/CreateDocument.svelte | 8 +- .../src/components/EditDoc.svelte | 6 +- .../src/components/NewDocumentHeader.svelte | 2 +- .../src/components/Chats.svelte | 6 +- .../src/components/Configure.svelte | 2 +- .../src/components/Connect.svelte | 2 +- .../src/components/FullMessage.svelte | 4 +- .../src/components/Main.svelte | 2 +- .../src/components/Message.svelte | 4 +- .../src/components/NewMessage.svelte | 6 +- .../src/components/NewMessages.svelte | 6 +- .../src/components/CreateDepartment.svelte | 6 +- .../src/components/CreateRequest.svelte | 6 +- .../src/components/DepartmentCard.svelte | 4 +- .../src/components/DepartmentStaff.svelte | 6 +- .../src/components/Schedule.svelte | 8 +- .../src/components/Structure.svelte | 2 +- .../schedule/CreatePublicHoliday.svelte | 2 +- .../src/components/schedule/YearView.svelte | 2 +- .../src/components/Categories.svelte | 2 +- .../src/components/CreateCategory.svelte | 2 +- .../src/components/CreateProduct.svelte | 4 +- .../src/components/Variants.svelte | 2 +- .../src/components/CreateCustomer.svelte | 4 +- .../src/components/CreateLead.svelte | 8 +- .../src/components/Leads.svelte | 2 +- .../src/components/MyLeads.svelte | 2 +- .../src/components/NewItemsHeader.svelte | 2 +- .../src/components/InviteLink.svelte | 4 +- .../src/components/SelectWorkspace.svelte | 2 +- .../src/components/StatusControl.svelte | 4 +- .../src/components/EmployeeInbox.svelte | 2 +- .../src/components/Applications.svelte | 10 +- .../src/components/CreateApplication.svelte | 2 +- .../src/components/CreateCandidate.svelte | 12 +- .../src/components/CreateVacancy.svelte | 6 +- .../src/components/EditVacancy.svelte | 24 +- .../src/components/NewCandidateHeader.svelte | 2 +- .../src/components/Organizations.svelte | 2 +- .../src/components/Vacancies.svelte | 2 +- .../src/components/VacancyApplications.svelte | 10 +- .../components/VacancyItemPresenter.svelte | 1 + .../src/components/VacancyList.svelte | 2 +- .../components/VacancyTemplateEditor.svelte | 2 +- .../src/components/review/CreateReview.svelte | 12 +- .../src/components/review/Opinions.svelte | 2 +- .../src/components/review/Reviews.svelte | 2 +- .../src/components/RequestLabel.svelte | 7 +- .../src/components/Configure.svelte | 2 +- .../src/components/InviteSetting.svelte | 2 +- .../src/components/Owners.svelte | 2 +- .../src/components/Password.svelte | 2 +- .../src/components/PluginCard.svelte | 8 +- .../src/components/statuses/Folders.svelte | 2 +- .../src/components/CategoryBar.svelte | 2 +- .../src/components/CollapsedTags.svelte | 2 +- .../src/components/CreateTagElement.svelte | 2 +- .../src/components/TagFilterPresenter.svelte | 2 +- .../components/TagReferencePresenter.svelte | 2 +- .../src/components/TagsCategoryPopup.svelte | 6 +- .../src/components/TagsEditor.svelte | 3 +- .../src/components/TagsPopup.svelte | 4 +- .../components/TagsReferencePresenter.svelte | 2 +- .../src/components/TagsView.svelte | 2 +- .../src/components/state/StatesEditor.svelte | 2 +- .../src/components/todos/Todos.svelte | 2 +- .../src/components/Chat.svelte | 8 +- .../src/components/Connect.svelte | 2 +- .../src/components/Date.svelte | 2 +- .../src/components/Message.svelte | 2 +- .../src/components/PinPad.svelte | 4 +- .../src/components/Reconnect.svelte | 2 +- .../src/components/Templates.svelte | 4 +- .../src/components/AppItem.svelte | 4 +- .../src/components/CreateIssue.svelte | 24 +- .../src/components/FilterMenuSection.svelte | 2 +- .../src/components/NewIssueHeader.svelte | 2 +- .../src/components/SubIssues.svelte | 2 +- .../components/ComponentBrowser.svelte | 2 +- .../components/ComponentEditor.svelte | 6 +- .../DeleteComponentPresenter.svelte | 2 +- .../components/components/NewComponent.svelte | 4 +- .../issues/IssueNotification.svelte | 2 +- .../src/components/issues/IssuePreview.svelte | 6 +- .../src/components/issues/IssuesView.svelte | 2 +- .../src/components/issues/KanbanView.svelte | 2 +- .../src/components/issues/Move.svelte | 8 +- .../src/components/issues/ParentIssue.svelte | 2 +- .../issues/edit/CopyToClipboardButton.svelte | 2 +- .../components/issues/edit/EditIssue.svelte | 6 +- .../components/issues/edit/SubIssues.svelte | 8 +- .../issues/edit/SubIssuesSelector.svelte | 2 +- .../related/RelatedIssueSelector.svelte | 2 +- .../related/RelatedIssuesSection.svelte | 4 +- .../EstimationProgressCircle.svelte | 4 +- .../timereport/EstimationSubIssueList.svelte | 2 +- .../timereport/TimeSpendReportPopup.svelte | 6 +- .../timereport/TimeSpendReportsList.svelte | 4 +- .../milestones/MilestoneBrowser.svelte | 2 +- .../milestones/MilestoneDatePresenter.svelte | 2 +- .../milestones/MilestoneEditor.svelte | 6 +- .../milestones/MilestoneRefPresenter.svelte | 2 +- .../components/milestones/NewMilestone.svelte | 6 +- .../components/projects/CreateProject.svelte | 4 +- .../projects/ProjectIconChooser.svelte | 2 +- .../templates/CreateIssueTemplate.svelte | 14 +- .../templates/DraftIssueChildEditor.svelte | 2 +- .../templates/EditIssueTemplate.svelte | 4 +- .../templates/IssueTemplateChildEditor.svelte | 2 +- .../templates/IssueTemplateChilds.svelte | 4 +- .../templates/IssueTemplatesView.svelte | 4 +- .../components/workflow/RemoveStatus.svelte | 2 +- .../components/workflow/StatusEditor.svelte | 4 +- .../src/components/workflow/Statuses.svelte | 2 +- .../src/components/ActionsPopup.svelte | 2 +- .../src/components/BooleanEditorPopup.svelte | 6 +- .../src/components/ColorsPopup.svelte | 4 +- .../src/components/DateEditor.svelte | 2 +- .../src/components/EditDoc.svelte | 23 +- .../view-resources/src/components/Move.svelte | 2 +- .../src/components/NumberEditor.svelte | 2 +- .../src/components/ObjectBox.svelte | 2 +- .../src/components/SpaceHeader.svelte | 10 - .../src/components/Table.svelte | 2 +- .../src/components/UpDownNavigator.svelte | 4 +- .../src/components/ViewOptions.svelte | 6 +- .../src/components/ViewOptionsButton.svelte | 2 +- .../components/ViewletSettingButton.svelte | 2 +- .../src/components/filter/FilterBar.svelte | 2 +- .../filter/FilterRemovedNotification.svelte | 2 +- .../src/components/filter/FilterSave.svelte | 2 +- .../components/filter/FilterSection.svelte | 2 +- .../src/components/list/ListHeader.svelte | 9 +- .../src/components/list/ListPresenter.svelte | 1 - .../src/components/list/SortableList.svelte | 2 +- .../components/list/SortableListItem.svelte | 4 +- plugins/view/src/index.ts | 1 + .../src/components/AppItem.svelte | 2 +- .../src/components/HelpAndSupport.svelte | 4 +- .../src/components/Logo.svelte | 2 +- .../src/components/SpaceBrowser.svelte | 6 +- .../src/components/SpaceHeader.svelte | 2 +- .../src/components/SpecialView.svelte | 2 +- 243 files changed, 701 insertions(+), 778 deletions(-) diff --git a/dev/storybook/stories/Button.stories.ts b/dev/storybook/stories/Button.stories.ts index 2556b0cb3e..bf97c1bc1c 100644 --- a/dev/storybook/stories/Button.stories.ts +++ b/dev/storybook/stories/Button.stories.ts @@ -17,11 +17,11 @@ const meta = { }, kind: { control: 'select', - options: ['primary', 'secondary', 'no-border', 'transparent', 'link', 'link-bordered', 'dangerous', 'list', 'list-header'], + options: ['accented', 'regular', 'no-border', 'ghost', 'link', 'link-bordered', 'dangerous', 'list', 'list-header'], description: 'kind description', table: { type: { summary: 'ButtonKind' }, - defaultValue: { summary: '"secondary"' }, + defaultValue: { summary: '"regular"' }, } }, size: { @@ -109,7 +109,7 @@ type Story = StoryObj; export const Ok: Story = { args: { label: uiPlugin.string.Ok, - kind: 'primary', + kind: 'accented', size: 'medium', shape: undefined, justify: 'left', @@ -125,7 +125,7 @@ export const Ok: Story = { export const Cancel: Story = { args: { label: uiPlugin.string.Cancel, - kind: 'primary', + kind: 'accented', size: 'medium', shape: undefined, justify: 'left', diff --git a/models/tracker/src/index.ts b/models/tracker/src/index.ts index 4ec8ff1547..5494a020bc 100644 --- a/models/tracker/src/index.ts +++ b/models/tracker/src/index.ts @@ -496,12 +496,12 @@ export function createModel (builder: Builder): void { props: { kind: 'list', size: 'small', - shape: 'round', shouldShowPlaceholder: false }, displayProps: { key: 'milestone', excludeByKey: 'milestone', + compression: true, optional: true } }, @@ -512,12 +512,12 @@ export function createModel (builder: Builder): void { props: { kind: 'list', size: 'small', - shape: 'round', shouldShowPlaceholder: false }, displayProps: { key: 'component', excludeByKey: 'component', + compression: true, optional: true } }, @@ -629,11 +629,11 @@ export function createModel (builder: Builder): void { props: { kind: 'list', size: 'small', - shape: 'round', shouldShowPlaceholder: false }, displayProps: { excludeByKey: 'milestone', + compression: true, optional: true } }, @@ -703,7 +703,7 @@ export function createModel (builder: Builder): void { size: 'small', shouldShowPlaceholder: false }, - displayProps: { key: 'component', optional: true } + displayProps: { key: 'component', compression: true, optional: true } }, { key: '', @@ -714,7 +714,7 @@ export function createModel (builder: Builder): void { size: 'small', shouldShowPlaceholder: false }, - displayProps: { key: 'milestone', optional: true } + displayProps: { key: 'milestone', compression: true, optional: true } }, { key: '', diff --git a/packages/kanban/src/components/KanbanRow.svelte b/packages/kanban/src/components/KanbanRow.svelte index 201aac0758..c74a8c091c 100644 --- a/packages/kanban/src/components/KanbanRow.svelte +++ b/packages/kanban/src/components/KanbanRow.svelte @@ -146,7 +146,7 @@ } &.selection, &.checked.selection { - box-shadow: 0 0 1px 1px var(--primary-button-enabled); + box-shadow: 0 0 1px 1px var(--accented-button-default); animation: anim-border 1s ease-in-out; &:hover { diff --git a/packages/presentation/src/components/Card.svelte b/packages/presentation/src/components/Card.svelte index 3de22638c5..14a16f810d 100644 --- a/packages/presentation/src/components/Card.svelte +++ b/packages/presentation/src/components/Card.svelte @@ -68,9 +68,8 @@ id="card-close" focusIndex={10002} icon={IconClose} - iconSize={'medium'} - iconProps={{ fill: 'var(--theme-dark-color)' }} - kind={'transparent'} + iconProps={{ size: 'medium', fill: 'var(--theme-dark-color)' }} + kind={'ghost'} size={'small'} on:click={() => { if (onCancel) { @@ -116,7 +115,7 @@ focusIndex={10001} disabled={!canSave} label={okLabel} - kind={'primary'} + kind={'accented'} size={'large'} on:click={() => { if (okProcessing) { diff --git a/packages/presentation/src/components/DocPopup.svelte b/packages/presentation/src/components/DocPopup.svelte index ccdea5009b..e8acabb46d 100644 --- a/packages/presentation/src/components/DocPopup.svelte +++ b/packages/presentation/src/components/DocPopup.svelte @@ -178,7 +178,7 @@
diff --git a/packages/ui/src/components/calendar/WeekCalendar.svelte b/packages/ui/src/components/calendar/WeekCalendar.svelte index ceebfc699c..1eac6b34f6 100644 --- a/packages/ui/src/components/calendar/WeekCalendar.svelte +++ b/packages/ui/src/components/calendar/WeekCalendar.svelte @@ -100,7 +100,7 @@ width: calc(calc(100% - 50px) / 7); } .cell:hover:not(.wrongMonth) { - color: var(--primary-button-color); + color: var(--accented-button-color); background-color: var(--highlight-hover); } diff --git a/packages/ui/src/types.ts b/packages/ui/src/types.ts index fd5b20c2bc..ee8e4f6d2f 100644 --- a/packages/ui/src/types.ts +++ b/packages/ui/src/types.ts @@ -116,10 +116,13 @@ export interface TabItem { } export type ButtonKind = - | 'primary' - | 'secondary' + | 'accented' + | 'brand' + | 'positive' + | 'negative' + | 'regular' + | 'ghost' | 'no-border' - | 'transparent' | 'link' | 'link-bordered' | 'dangerous' @@ -203,6 +206,11 @@ export type IconSize = | 'x-large' | '2x-large' | 'full' +export interface IconProps { + icon?: number + size?: IconSize + fill?: string +} export function getIconSize2x (size: IconSize): IconSize { switch (size) { diff --git a/plugins/attachment-resources/src/components/AccordionEditor.svelte b/plugins/attachment-resources/src/components/AccordionEditor.svelte index 425d1231bd..56f3584d5f 100644 --- a/plugins/attachment-resources/src/components/AccordionEditor.svelte +++ b/plugins/attachment-resources/src/components/AccordionEditor.svelte @@ -102,7 +102,7 @@ /> {/if} -