From eb9150541bf8f96b1a8ea488239b9bdacf520d78 Mon Sep 17 00:00:00 2001
From: Denis Bykhov <bykhov.denis@gmail.com>
Date: Tue, 9 Sep 2025 20:52:16 +0500
Subject: [PATCH] ValueIsSet criteria mode (#9815)

Signed-off-by: Denis Bykhov <bykhov.denis@gmail.com>
---
 .../components/criterias/BaseCriteria.svelte  | 109 +++++++++---------
 .../criterias/BooleanCriteria.svelte          |   2 +-
 .../components/criterias/DateCriteria.svelte  |   2 +-
 .../components/criterias/EnumCriteria.svelte  |   2 +-
 .../criterias/NumberCriteria.svelte           |   2 +-
 .../components/criterias/RefCriteria.svelte   |   2 +-
 .../criterias/StringCriteria.svelte           |   2 +-
 .../UpdateAttributePresenter.svelte           |   2 +-
 plugins/process-resources/src/query.ts        |  14 ++-
 plugins/view-assets/lang/cs.json              |   3 +-
 plugins/view-assets/lang/de.json              |   3 +-
 plugins/view-assets/lang/en.json              |   3 +-
 plugins/view-assets/lang/es.json              |   3 +-
 plugins/view-assets/lang/fr.json              |   3 +-
 plugins/view-assets/lang/it.json              |   3 +-
 plugins/view-assets/lang/ja.json              |   3 +-
 plugins/view-assets/lang/pt.json              |   3 +-
 plugins/view-assets/lang/ru.json              |   3 +-
 plugins/view-assets/lang/zh.json              |   3 +-
 plugins/view-resources/src/plugin.ts          |   1 +
 20 files changed, 96 insertions(+), 72 deletions(-)

diff --git a/plugins/process-resources/src/components/criterias/BaseCriteria.svelte b/plugins/process-resources/src/components/criterias/BaseCriteria.svelte
index cccfe3cd7c..2f7a6e5241 100644
--- a/plugins/process-resources/src/components/criterias/BaseCriteria.svelte
+++ b/plugins/process-resources/src/components/criterias/BaseCriteria.svelte
@@ -28,7 +28,7 @@
     showPopup
   } from '@hcengineering/ui'
   import { createEventDispatcher } from 'svelte'
-  import { buildResult, Mode, Modes, parseValue } from '../../query'
+  import { buildResult, Mode, parseValue } from '../../query'
   import ContextSelectorPopup from '../attributeEditors/ContextSelectorPopup.svelte'
   import ContextValue from '../attributeEditors/ContextValue.svelte'
 
@@ -78,7 +78,7 @@
   $: presenterClass = getAttributePresenterClass(hierarchy, attribute.type)
 
   function changeResult () {
-    if (val === undefined || val === '') {
+    if (!selectedMode.withoutEditor && (val === undefined || val === '')) {
       dispatch('change', null)
       return
     }
@@ -103,60 +103,61 @@
       changeResult()
     }}
   />
-
-  <div class="text-input" class:context={contextValue}>
-    {#if contextValue}
-      <ContextValue
-        {process}
-        masterTag={process.masterTag}
-        {contextValue}
-        {context}
-        {attribute}
-        category={presenterClass.category}
-        attrClass={presenterClass.attrClass}
-        on:update={(e) => {
-          onSelect(e.detail)
-        }}
-      />
-    {:else}
-      <div class="w-full">
-        {#if baseEditor}
-          <Component
-            is={baseEditor}
-            props={{
-              label: attribute?.label,
-              placeholder: attribute?.label,
-              kind: 'ghost',
-              size: 'large',
-              width: '100%',
-              justify: 'left',
-              readonly,
-              type: attribute?.type,
-              value: val,
-              onChange,
-              focus
-            }}
-          />
-        {/if}
+  {#if !selectedMode.withoutEditor}
+    <div class="text-input" class:context={contextValue}>
+      {#if contextValue}
+        <ContextValue
+          {process}
+          masterTag={process.masterTag}
+          {contextValue}
+          {context}
+          {attribute}
+          category={presenterClass.category}
+          attrClass={presenterClass.attrClass}
+          on:update={(e) => {
+            onSelect(e.detail)
+          }}
+        />
+      {:else}
+        <div class="w-full">
+          {#if baseEditor}
+            <Component
+              is={baseEditor}
+              props={{
+                label: attribute?.label,
+                placeholder: attribute?.label,
+                kind: 'ghost',
+                size: 'large',
+                width: '100%',
+                justify: 'left',
+                readonly,
+                type: attribute?.type,
+                value: val,
+                onChange,
+                focus
+              }}
+            />
+          {/if}
+        </div>
+      {/if}
+      <div class="button flex-row-center">
+        <Button
+          icon={IconAdd}
+          kind="ghost"
+          on:click={(e) => {
+            selectContext(e)
+          }}
+        />
+        <Button
+          icon={IconClose}
+          kind="ghost"
+          on:click={() => {
+            dispatch('delete')
+          }}
+        />
       </div>
-    {/if}
-    <div class="button flex-row-center">
-      <Button
-        icon={IconAdd}
-        kind="ghost"
-        on:click={(e) => {
-          selectContext(e)
-        }}
-      />
-      <Button
-        icon={IconClose}
-        kind="ghost"
-        on:click={() => {
-          dispatch('delete')
-        }}
-      />
     </div>
-  </div>
+  {/if}
 </div>
 
 <style lang="scss">
diff --git a/plugins/process-resources/src/components/criterias/BooleanCriteria.svelte b/plugins/process-resources/src/components/criterias/BooleanCriteria.svelte
index c066dba5af..538ef8d874 100644
--- a/plugins/process-resources/src/components/criterias/BooleanCriteria.svelte
+++ b/plugins/process-resources/src/components/criterias/BooleanCriteria.svelte
@@ -27,7 +27,7 @@
   export let attribute: AnyAttribute
   export let baseEditor: AnyComponent | undefined
 
-  const modes: Mode[] = [Modes.Equal, Modes.NotEqual]
+  const modes: Mode[] = [Modes.Equal, Modes.NotEqual, Modes.Exists]
 </script>
 
 <BaseCriteria {readonly} {value} {process} {context} {attribute} {baseEditor} {modes} on:change on:delete />
diff --git a/plugins/process-resources/src/components/criterias/DateCriteria.svelte b/plugins/process-resources/src/components/criterias/DateCriteria.svelte
index 3d545599c1..35ddfb8f21 100644
--- a/plugins/process-resources/src/components/criterias/DateCriteria.svelte
+++ b/plugins/process-resources/src/components/criterias/DateCriteria.svelte
@@ -27,7 +27,7 @@
   export let attribute: AnyAttribute
   export let baseEditor: AnyComponent | undefined
 
-  const modes: Mode[] = [Modes.Equal, Modes.GT, Modes.LT]
+  const modes: Mode[] = [Modes.Equal, Modes.GT, Modes.LT, Modes.Exists]
 </script>
 
 <BaseCriteria {readonly} {value} {process} {context} {attribute} {baseEditor} {modes} on:change on:delete />
diff --git a/plugins/process-resources/src/components/criterias/EnumCriteria.svelte b/plugins/process-resources/src/components/criterias/EnumCriteria.svelte
index c066dba5af..538ef8d874 100644
--- a/plugins/process-resources/src/components/criterias/EnumCriteria.svelte
+++ b/plugins/process-resources/src/components/criterias/EnumCriteria.svelte
@@ -27,7 +27,7 @@
   export let attribute: AnyAttribute
   export let baseEditor: AnyComponent | undefined
 
-  const modes: Mode[] = [Modes.Equal, Modes.NotEqual]
+  const modes: Mode[] = [Modes.Equal, Modes.NotEqual, Modes.Exists]
 </script>
 
 <BaseCriteria {readonly} {value} {process} {context} {attribute} {baseEditor} {modes} on:change on:delete />
diff --git a/plugins/process-resources/src/components/criterias/NumberCriteria.svelte b/plugins/process-resources/src/components/criterias/NumberCriteria.svelte
index 3d545599c1..35ddfb8f21 100644
--- a/plugins/process-resources/src/components/criterias/NumberCriteria.svelte
+++ b/plugins/process-resources/src/components/criterias/NumberCriteria.svelte
@@ -27,7 +27,7 @@
   export let attribute: AnyAttribute
   export let baseEditor: AnyComponent | undefined
 
-  const modes: Mode[] = [Modes.Equal, Modes.GT, Modes.LT]
+  const modes: Mode[] = [Modes.Equal, Modes.GT, Modes.LT, Modes.Exists]
 </script>
 
 <BaseCriteria {readonly} {value} {process} {context} {attribute} {baseEditor} {modes} on:change on:delete />
diff --git a/plugins/process-resources/src/components/criterias/RefCriteria.svelte b/plugins/process-resources/src/components/criterias/RefCriteria.svelte
index c066dba5af..538ef8d874 100644
--- a/plugins/process-resources/src/components/criterias/RefCriteria.svelte
+++ b/plugins/process-resources/src/components/criterias/RefCriteria.svelte
@@ -27,7 +27,7 @@
   export let attribute: AnyAttribute
   export let baseEditor: AnyComponent | undefined
 
-  const modes: Mode[] = [Modes.Equal, Modes.NotEqual]
+  const modes: Mode[] = [Modes.Equal, Modes.NotEqual, Modes.Exists]
 </script>
 
 <BaseCriteria {readonly} {value} {process} {context} {attribute} {baseEditor} {modes} on:change on:delete />
diff --git a/plugins/process-resources/src/components/criterias/StringCriteria.svelte b/plugins/process-resources/src/components/criterias/StringCriteria.svelte
index 21325582aa..9791c454cc 100644
--- a/plugins/process-resources/src/components/criterias/StringCriteria.svelte
+++ b/plugins/process-resources/src/components/criterias/StringCriteria.svelte
@@ -27,7 +27,7 @@
   export let attribute: AnyAttribute
   export let baseEditor: AnyComponent | undefined
 
-  const modes: Mode[] = [Modes.Equal, Modes.StringContains]
+  const modes: Mode[] = [Modes.Equal, Modes.StringContains, Modes.Exists]
 </script>
 
 <BaseCriteria {readonly} {value} {process} {context} {attribute} {baseEditor} {modes} on:change on:delete />
diff --git a/plugins/process-resources/src/components/presenters/UpdateAttributePresenter.svelte b/plugins/process-resources/src/components/presenters/UpdateAttributePresenter.svelte
index 00a98547d9..9c06d0aeec 100644
--- a/plugins/process-resources/src/components/presenters/UpdateAttributePresenter.svelte
+++ b/plugins/process-resources/src/components/presenters/UpdateAttributePresenter.svelte
@@ -64,7 +64,7 @@
     <Label label={attribute.label} />
   </div>
   <Label label={selectedMode.label} />
-  {#if presenter}
+  {#if presenter && !selectedMode.withoutEditor}
     {#if contextValue && context}
       <ContextValuePresenter {contextValue} {context} {process} />
     {:else}
diff --git a/plugins/process-resources/src/query.ts b/plugins/process-resources/src/query.ts
index 03aea11ad9..97bbe7a163 100644
--- a/plugins/process-resources/src/query.ts
+++ b/plugins/process-resources/src/query.ts
@@ -20,6 +20,7 @@ export interface Mode {
   label: IntlString
   query: QuerySelector<any> | string
   parse?: (value: any) => any
+  withoutEditor?: boolean
 }
 
 const Equal: Mode = {
@@ -46,6 +47,13 @@ const LT: Mode = {
   query: { $lt: '$val' as any }
 }
 
+const Exists: Mode = {
+  id: 'exists',
+  label: view.string.ValueIsSet,
+  query: { $exists: true },
+  withoutEditor: true
+}
+
 const StringContains: Mode = {
   id: 'contains',
   label: view.string.Contains,
@@ -105,6 +113,7 @@ const ArraySizeLte: Mode = {
 }
 
 export const Modes: Record<string, Mode> = {
+  Exists,
   Equal,
   NotEqual,
   StringContains,
@@ -133,7 +142,10 @@ export function parseValue (modes: Mode[], value: any): [any, Mode] {
     while (typeof obj1 === 'object' && typeof obj2 === 'object' && Object.keys(obj1)[0] === Object.keys(obj2)[0]) {
       const key1 = Object.keys(obj1)[0]
       const key2 = Object.keys(obj2)[0]
-      if (typeof obj1[key1] === 'string' && (typeof obj2[key2] !== 'object' || Array.isArray(obj2[key2]))) {
+      if (
+        ['string', 'boolean'].includes(typeof obj1[key1]) &&
+        (typeof obj2[key2] !== 'object' || Array.isArray(obj2[key2]))
+      ) {
         if (mode.parse !== undefined) {
           return [mode.parse(obj2[key2]), mode]
         }
diff --git a/plugins/view-assets/lang/cs.json b/plugins/view-assets/lang/cs.json
index a3fa6c77a7..abf6949290 100644
--- a/plugins/view-assets/lang/cs.json
+++ b/plugins/view-assets/lang/cs.json
@@ -147,6 +147,7 @@
     "Icon": "Ikona",
     "Color": "Barva",
     "AutomationOnly": "Pouze automatizace",
-    "CopyLink": "Kopírovat odkaz"
+    "CopyLink": "Kopírovat odkaz",
+    "ValueIsSet": "Hodnota je nastavena"
   }
 }
diff --git a/plugins/view-assets/lang/de.json b/plugins/view-assets/lang/de.json
index 30faa135cc..970af37c99 100644
--- a/plugins/view-assets/lang/de.json
+++ b/plugins/view-assets/lang/de.json
@@ -147,6 +147,7 @@
     "Icon": "Symbol",
     "Color": "Farbe",
     "AutomationOnly": "Nur Automatisierung",
-    "CopyLink": "Link kopieren"
+    "CopyLink": "Link kopieren",
+    "ValueIsSet": "Wert ist gesetzt"
   }
 }
diff --git a/plugins/view-assets/lang/en.json b/plugins/view-assets/lang/en.json
index 400e2dbcda..da9dd3a846 100644
--- a/plugins/view-assets/lang/en.json
+++ b/plugins/view-assets/lang/en.json
@@ -147,6 +147,7 @@
     "Icon": "Icon",
     "Color": "Color",
     "AutomationOnly": "Automation only",
-    "CopyLink": "Copy link"
+    "CopyLink": "Copy link",
+    "ValueIsSet": "Value is set"
   }
 }
diff --git a/plugins/view-assets/lang/es.json b/plugins/view-assets/lang/es.json
index 08a36ff027..18ff2e46a1 100644
--- a/plugins/view-assets/lang/es.json
+++ b/plugins/view-assets/lang/es.json
@@ -142,6 +142,7 @@
     "Icon": "Icono",
     "Color": "Color",
     "AutomationOnly": "Solo automatización",
-    "CopyLink": "Copiar enlace"
+    "CopyLink": "Copiar enlace",
+    "ValueIsSet": "El valor está establecido"
   }
 }
diff --git a/plugins/view-assets/lang/fr.json b/plugins/view-assets/lang/fr.json
index 6e6e78b560..6bea876aba 100644
--- a/plugins/view-assets/lang/fr.json
+++ b/plugins/view-assets/lang/fr.json
@@ -142,6 +142,7 @@
     "Icon": "Icône",
     "Color": "Couleur",
     "AutomationOnly": "Automatisation uniquement",
-    "CopyLink": "Copier le lien"
+    "CopyLink": "Copier le lien",
+    "ValueIsSet": "La valeur est définie"
   }
 }
diff --git a/plugins/view-assets/lang/it.json b/plugins/view-assets/lang/it.json
index 1fd12b9afe..5b408a036e 100644
--- a/plugins/view-assets/lang/it.json
+++ b/plugins/view-assets/lang/it.json
@@ -142,6 +142,7 @@
     "Icon": "Icona",
     "Color": "Colore",
     "AutomationOnly": "Solo automazione",
-    "CopyLink": "Copia link"
+    "CopyLink": "Copia link",
+    "ValueIsSet": "Il valore è impostato"
   }
 }
diff --git a/plugins/view-assets/lang/ja.json b/plugins/view-assets/lang/ja.json
index 162e3323a2..128b837fc7 100644
--- a/plugins/view-assets/lang/ja.json
+++ b/plugins/view-assets/lang/ja.json
@@ -142,6 +142,7 @@
     "Icon": "アイコン",
     "Color": "色",
     "AutomationOnly": "自動化のみ",
-    "CopyLink": "リンクをコピー"
+    "CopyLink": "リンクをコピー",
+    "ValueIsSet": "値が設定されています"
   }
 }
diff --git a/plugins/view-assets/lang/pt.json b/plugins/view-assets/lang/pt.json
index ce2e3fd9d7..1d7ffbb016 100644
--- a/plugins/view-assets/lang/pt.json
+++ b/plugins/view-assets/lang/pt.json
@@ -142,6 +142,7 @@
     "Icon": "Ícone",
     "Color": "Cor",
     "AutomationOnly": "Apenas automação",
-    "CopyLink": "Copiar link"
+    "CopyLink": "Copiar link",
+    "ValueIsSet": "O valor está definido"
   }
 }
diff --git a/plugins/view-assets/lang/ru.json b/plugins/view-assets/lang/ru.json
index 9b4599045d..e57f894811 100644
--- a/plugins/view-assets/lang/ru.json
+++ b/plugins/view-assets/lang/ru.json
@@ -144,6 +144,7 @@
     "Icon": "Иконка",
     "Color": "Цвет",
     "AutomationOnly": "Только автоматизация",
-    "CopyLink": "Скопировать ссылку"
+    "CopyLink": "Скопировать ссылку",
+    "ValueIsSet": "Значение установлено"
   }
 }
diff --git a/plugins/view-assets/lang/zh.json b/plugins/view-assets/lang/zh.json
index b727a2b47c..3f41241c29 100644
--- a/plugins/view-assets/lang/zh.json
+++ b/plugins/view-assets/lang/zh.json
@@ -147,6 +147,7 @@
     "Icon": "图标",
     "Color": "颜色",
     "AutomationOnly": "仅限自动化",
-    "CopyLink": "复制链接"
+    "CopyLink": "复制链接",
+    "ValueIsSet": "值已设置"
   }
 }
diff --git a/plugins/view-resources/src/plugin.ts b/plugins/view-resources/src/plugin.ts
index 2fa68633e8..de2be89165 100644
--- a/plugins/view-resources/src/plugin.ts
+++ b/plugins/view-resources/src/plugin.ts
@@ -38,6 +38,7 @@ export default mergeIds(viewId, view, {
   string: {
     Contains: '' as IntlString,
     NotContains: '' as IntlString,
+    ValueIsSet: '' as IntlString,
     LabelYes: '' as IntlString,
     LabelNo: '' as IntlString,
     ChooseAColor: '' as IntlString,