Rename owners to members in workspace settings (#10729)

* Renamw owners to members in workspace settings

Signed-off-by: Artem Savchenko <armisav@gmail.com>

* Fix tests

Signed-off-by: Artem Savchenko <armisav@gmail.com>

* Try to fix tests

Signed-off-by: Artem Savchenko <armisav@gmail.com>

* Fix formatting

Signed-off-by: Artem Savchenko <armisav@gmail.com>

---------

Signed-off-by: Artem Savchenko <armisav@gmail.com>

tests/sanity/tests/custom-atributes/custom-attributes-page.ts

@@ -32,7 +32,7 @@ export class CustomAttributesPage {
     this.page = page
   }
 
-  member = (): Locator => this.page.getByRole('button', { name: 'Member' })
+  member = (): Locator => this.page.getByRole('button', { name: 'Member', exact: true })
   contact = (): Locator => this.page.getByRole('button', { name: 'Contact' })
   person = (): Locator => this.page.getByRole('button', { name: 'Person' })
   employee = (): Locator => this.page.getByRole('button', { name: 'Employee' })

tests/sanity/tests/model/workspace/classes-pages.ts

@@ -7,7 +7,7 @@ export class ClassesPage {
     this.page = page
   }
 
-  member = (): Locator => this.page.getByRole('button', { name: 'Member' })
+  member = (): Locator => this.page.getByRole('button', { name: 'Member', exact: true })
   contact = (): Locator => this.page.getByRole('button', { name: 'Contact' })
   person = (): Locator => this.page.getByRole('button', { name: 'Person' })
   employee = (): Locator => this.page.getByRole('button', { name: 'Employee' })

tests/sanity/tests/model/workspace/owner-pages.ts

@@ -9,7 +9,15 @@ export class OwnersPage {
 
   owner = (ownerName: string): Locator => this.page.getByRole('link', { name: ownerName })
   spacesAdminText = (): Locator => this.page.getByText('Admin Members')
-  addMemberButton = (): Locator => this.page.getByRole('button', { name: 'Members' })
+  // Sidebar "Members" nav item clashes with Spaces role pickers (label "Members"). Scope to settings content
+  // and the "Admin" role row — Spaces.svelte renders one AccountArrayEditor per role.
+  addMemberButton = (): Locator =>
+    this.page
+      .locator('.antiPanel-component.filledNav')
+      .locator('.antiGrid-row')
+      .filter({ has: this.page.locator('.antiGrid-row__header', { hasText: /^Admin$/ }) })
+      .getByRole('button', { name: 'Members' })
+
   selectMember = (memberName: string): Locator => this.page.getByRole('button', { name: memberName })
   workspaceLogo = (): Locator => this.page.locator('.hulyComponent .hulyAvatar-container')
   publicTemplate = (): Locator => this.page.getByText('Public templates')

tests/sanity/tests/model/workspace/workspace-settings-page.ts

@@ -2,7 +2,7 @@ import { type Locator, type Page } from '@playwright/test'
 
 export enum ButtonType {
   General,
-  Owners,
+  Members,
   Spaces,
   TextTemplate,
   RelatedIssues,
@@ -19,7 +19,7 @@ export class WorkspaceSettingsPage {
   }
 
   general = (): Locator => this.page.getByRole('button', { name: 'General' })
-  owners = (): Locator => this.page.getByRole('button', { name: 'Owners' })
+  members = (): Locator => this.page.getByRole('button', { name: 'Members' })
   spaces = (): Locator => this.page.getByRole('button', { name: 'Spaces', exact: true })
   textTemplate = (): Locator => this.page.getByRole('button', { name: 'Text Templates' })
   relatedIssues = (): Locator => this.page.getByRole('button', { name: 'Related issues' })
@@ -32,8 +32,8 @@ export class WorkspaceSettingsPage {
       case ButtonType.General:
         await this.general().click()
         break
-      case ButtonType.Owners:
-        await this.owners().click()
+      case ButtonType.Members:
+        await this.members().click()
         break
       case ButtonType.Spaces:
         await this.spaces().click()

tests/sanity/tests/recruiting/vacancies.spec.ts

@@ -28,8 +28,8 @@ test.describe('Vacancy tests', () => {
     await settingsPage.profileButton().click()
     await settingsPage.selectPopupAp('Settings')
     const wsPage: WorkspaceSettingsPage = new WorkspaceSettingsPage(page)
-    await wsPage.owners().click()
-    await settingsPage.checkOpened('Owners')
+    await wsPage.members().click()
+    await settingsPage.checkOpened('Members')
     const count = await page.locator('div[id="workbench:component:WorkbenchTabs"] div.container.main').count()
     for (let i = 1; i < count; i++) {
       await page.locator('div[id="workbench:component:WorkbenchTabs"] div.container.main:first-child button').click()

tests/sanity/tests/workspace/workspace-settings.spec.ts

@@ -44,7 +44,7 @@ test.describe('Workspace tests', () => {
     await selectWorkspacePage.createWorkspace(newWorkspaceName)
     await userProfilePage.openProfileMenu()
     await userProfilePage.clickSettings()
-    await workspaceSettingsPage.selectWorkspaceSettingsTab(ButtonType.Owners)
+    await workspaceSettingsPage.selectWorkspaceSettingsTab(ButtonType.Members)
     await ownersPage.checkIfOwnerExists(newUser.firstName)
   })