OnChatMessageCreated seeds a target doc's default collaborators when the doc
has none yet. The seed passed the ChatMessage create tx's own identity
(tx.objectId / tx.objectClass / tx.objectSpace) to getAddCollaboratTxes, so
the Collaborator records were attached to the ChatMessage instead of the
target doc. Two consequences:
- The target doc was never actually seeded: currentCollaborators stayed empty,
so the defaults were lost and the seed re-evaluated on the next message.
- For provideSecurity classes the seed re-fired on every message and littered
the message with Collaborator records.
Pass targetDoc._id / targetDoc._class / targetDoc.space instead.
This wrong-target is long-standing (pre-existing); #9217 only mechanically
inherited the line and did not introduce the bug.
Adds a from-scratch jest harness (chunter-resources shipped no tests). It
drives ChunterTrigger with a TxCreateDoc<ChatMessage> on an empty target and
asserts the seeded Collaborator attaches to the target doc
(attachedTo / attachedToClass / objectSpace). getAddCollaboratTxes runs for
real — only getDocCollaborators and createCollaboratorNotifications are
stubbed — so the assertion exercises the actual wiring: red before the fix
(attachedTo = message id), green after.
A sibling of this bug lives in server-notification-resources collectionCollabDoc
(the createCollabDocInfo seeding path); left out of scope here.
Signed-off-by: Michael Uray <michaeluray@users.noreply.github.com>
Co-authored-by: Michael Uray <michaeluray@users.noreply.github.com>
getCollaborators resolved the default collaborators of the parent doc (loaded via the triggering tx's attachedTo/attachedToClass) but seeded them onto tx.objectId — the attached child item (a comment/message create/update/remove tx). The parent's collaborators therefore landed on the child record instead of the parent.
Seed onto doc._id/doc._class/doc.space instead. Same class of bug as the chunter seed-target fix. The returned collaborator list is unchanged; only the target of the newly created Collaborator records changes.
Adds a unit test that drives getCollaborators directly: real getAddCollaboratTxes/getDocCollaborators, only getClassCollaborators stubbed. Parent and child are given distinct collaborators and spaces; it asserts the seed targets the parent (attachedTo/attachedToClass/objectSpace), never the child, while the returned collaborator list stays identical.
Signed-off-by: Michael Uray <michaeluray@users.noreply.github.com>
Co-authored-by: Michael Uray <michaeluray@users.noreply.github.com>
getCommonNotificationTxes() passed a hardcoded empty array as the `types`
argument to pushInboxNotifications(), so every notification created through
it was stored with `types: []`.
NotificationsHandler resolves the allowed providers per notification type.
With no types it matches no provider, logs "no notifications with email
provider, skipping" and returns, so these notifications can never be
delivered by email or any non-inbox provider.
This affects everything routed through this helper - ToDos, process
approvals (process:ids:ApproveRequestCreated), HR requests - while
activity-message notifications are unaffected because that path passes its
types through.
The types are already computed: isShouldNotifyTx() returns a NotifyResult
mapping each provider to the NotificationType docs that matched, and the
result is passed in as notifyResult. Forward the inbox provider's types
instead of discarding them.
* feat(tracker): Gantt chart for the issue tracker
Builds on the merged search/filter rework (#10998). Introduces @hcengineering/gantt, a dependency-free scheduling/zoom/drag/viewport engine package (with a neutral GanttDependency contract), and wires the tracker-specific adapter, Svelte UI, model schema, dependency-shift notifications and sanity coverage in tracker-resources.
Signed-off-by: Michael Uray <michaeluray@users.noreply.github.com>
* fix(tracker): source Gantt holidays from HR and scope confirm-gate per view
Follow-up to review feedback on #10992:
- Confirm-gate: the module-global flag is replaced by a createConfirmGate()
factory - one instance per mounted GanttView, so two Gantt views mounted at
once in the same JS context no longer block each other's pointer input. A
two-instance independence test guards the regression.
- Sidebar sorting: the stale deadline cast is dropped and issue.deadline is
read directly (the field was added to the Issue model in this PR).
- HR holidays: the per-project WorkingDaysConfig.holidays field duplicated the
workspace-wide hr.class.PublicHoliday concept and could drift from the real
HR calendar. It is removed. WorkingDaysConfig now carries only the weekday
mask and an optional holidayDepartment. The tracker adapter resolves holidays
for the selected department plus all ancestors up to hr.ids.Head, matching
HR's existing inheritance semantics (hr-resources ScheduleView). A missing or
invalid reference falls back to company-wide (root) holidays; unrelated
departments are never included. The ancestor walk is cycle/missing-parent
safe.
A small WorkingDaysEditor in the existing project create/edit dialog lets
users with the existing project permission enable the mode, choose weekdays,
and select an HR department (default: Company-wide). It persists through the
existing project create/update transaction paths (createDoc on create,
client.update on edit) and uses $unset when the mode is disabled. At least
one working day must stay active.
Calendar loading is explicit via a CalendarStateMachine: project-scoped drag,
resize, cascade, keyboard-shift and auto-schedule mutations stay disabled
until both the project config and the holiday data have loaded. A monotonic
generation ticket (bumped synchronously on project switch) is re-checked
immediately before every calendar-dependent date commit, so work started in
one project can never persist after a switch to another. The all-projects
view has no single project calendar, so calendar-dependent edits are
read-only there; display, selection, the context menu and the manual
date-picker (which does no calendar arithmetic and takes no mutation ticket)
stay available.
This depends on the lightweight @hcengineering/hr model package, but not on
hr-resources; the tracker adapter uses hr.class.* and hr.ids.Head at runtime,
and actual HR model presence is checked through the hierarchy - without the
HR model, holidays resolve to an empty set. The @hcengineering/gantt engine
package stays domain-neutral (no @hcengineering imports, no runtime deps).
Signed-off-by: Michael Uray <michaeluray@users.noreply.github.com>
* fix(gantt): measure FS gap-preservation floor in working days
The finish-to-start gap-preservation floor in the cascade scheduler mixed
two time measures: the FS snap anchor is working-calendar aware, but the
floor added a raw calendar-millisecond start-side delta. With an active
working calendar the two diverge, so dragging a predecessor over a weekend
over-shifted the successor across non-working days (a Fri->Mon body drag is
3 calendar days but only 1 working day, and could even land a successor on
a Saturday).
Measure the floor on the DUE side in working days instead: translate the
predecessor's shift via the new workingDayDelta helper and advance the
floor base with addWorkingDays over the calendar. A day-granular resize
gate (utcMidnight comparison, not a raw === 0 test) arms the floor only on
a start-DAY move, so a pure due-resize stays a pure snap even when the
stored issue carries a time-of-day on the cascade-commit path. The floor
base is normalized via utcMidnight(targetAnchor). The legacy path
(cfg === undefined) stays byte-identical to today's raw-ms floor. A
left-resize in working-days mode now correctly no-ops the floor (the due,
and thus the FS gap, did not move) instead of shifting on the raw start
delta.
Engine: add workingDayDelta (signed, half-open from-exclusive/to-inclusive
working-day step count) and export the previously-private utcMidnight from
packages/gantt/src/working-days.ts. The engine stays domain-neutral (no
@hcengineering imports, empty dependencies).
Adds engine and adapter test coverage: workingDayDelta cases and the full
FS floor matrix (right-resize no-push, weekend-spanner body drag, floor
wins over snap, holiday in the floor path, floor-dominant multi-hop chain,
negative delta, legacy no-cfg, SS pure-snap, raw time-of-day right-resize,
direct left-resize).
Signed-off-by: Michael Uray <michaeluray@users.noreply.github.com>
---------
Signed-off-by: Michael Uray <michaeluray@users.noreply.github.com>
Co-authored-by: Michael Uray <michaeluray@users.noreply.github.com>
* add readonly support to MarkupEditor and improve hierarchy-based attribute resolution and locking logic
Signed-off-by: Denis Bykhov <bykhov.denis@gmail.com>
* perf: implement caching for card lookups in process-resources functions
Signed-off-by: Denis Bykhov <bykhov.denis@gmail.com>
* refactor: update TagSelector to use tag IDs in selection set and optimize hierarchy access
Signed-off-by: Denis Bykhov <bykhov.denis@gmail.com>
---------
Signed-off-by: Denis Bykhov <bykhov.denis@gmail.com>
