From 6adaa6cf78c1227ad1d3f182421cf69f3909f508 Mon Sep 17 00:00:00 2001 From: Nuno Campos Date: Thu, 6 Feb 2025 11:33:54 -0800 Subject: [PATCH 1/2] Fix up --- libs/langgraph/langgraph/graph/message.py | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/libs/langgraph/langgraph/graph/message.py b/libs/langgraph/langgraph/graph/message.py index 60810bc41..6bbbf252a 100644 --- a/libs/langgraph/langgraph/graph/message.py +++ b/libs/langgraph/langgraph/graph/message.py @@ -176,18 +176,15 @@ def add_messages( for m in left: if m.id is None: m.id = str(uuid.uuid4()) - dedupe_map = {} for m in right: if m.id is None: m.id = str(uuid.uuid4()) - dedupe_map[m.id] = m - right = list(dedupe_map.values()) # merge - left_idx_by_id = {m.id: i for i, m in enumerate(left)} merged = left.copy() + merged_by_id = {m.id: i for i, m in enumerate(merged)} ids_to_remove = set() for m in right: - if (existing_idx := left_idx_by_id.get(m.id)) is not None: + if (existing_idx := merged_by_id.get(m.id)) is not None: if isinstance(m, RemoveMessage): ids_to_remove.add(m.id) else: @@ -198,6 +195,7 @@ def add_messages( f"Attempting to delete a message with an ID that doesn't exist ('{m.id}')" ) + merged_by_id[m.id] = len(merged) merged.append(m) merged = [m for m in merged if m.id not in ids_to_remove] From 55a3352e9b13bb5a1266e94617378e973a45de68 Mon Sep 17 00:00:00 2001 From: Nuno Campos Date: Thu, 6 Feb 2025 11:34:45 -0800 Subject: [PATCH 2/2] One more --- libs/langgraph/langgraph/graph/message.py | 1 + 1 file changed, 1 insertion(+) diff --git a/libs/langgraph/langgraph/graph/message.py b/libs/langgraph/langgraph/graph/message.py index 6bbbf252a..b6ed16131 100644 --- a/libs/langgraph/langgraph/graph/message.py +++ b/libs/langgraph/langgraph/graph/message.py @@ -188,6 +188,7 @@ def add_messages( if isinstance(m, RemoveMessage): ids_to_remove.add(m.id) else: + ids_to_remove.discard(m.id) merged[existing_idx] = m else: if isinstance(m, RemoveMessage):