WEBDIENSTE/langgraph
1
0
Fork 0
mirror of https://github.com/langchain-ai/langgraph.git synced 2026-09-24 02:25:07 +02:00
Code Issues Packages Projects Releases Wiki Activity

refactor(cli): drop listeners without an id and name the source arguments

Browse Source
This commit is contained in:
Hugo Durand
2026-09-22 15:28:20 -04:00
parent f89bf66d84
commit a3a2a2e33a
4 changed files with 48 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files
libs/cli/tests/unit_tests/cli/test_deploy_command.py
+18
View File
@@ -914,3 +914,21 @@ def test_a_truncated_listener_page_says_so(deploy_project: DeployProject) -> Non
assert result.exit_code != 0
assert "first 100" in result.output
def test_a_listener_without_an_id_is_ignored(deploy_project: DeployProject) -> None:
deploy_project.control_plane.listeners = [
{"compute_id": "broken", "compute_config": {"k8s_namespaces": ["agents"]}},
LISTENER,
]
result = deploy_project.run(
"--push-to", PUSH_REPOSITORY, host_url=CLOUD_CONTROL_PLANE_URL
)
assert result.exit_code == 0, result.output
assert deploy_project.control_plane.bodies[CREATE_DEPLOYMENT]["source_config"] == {
"resource_spec": {},
"listener_id": "listener-1",
"listener_config": {"k8s_namespace": "agents"},
}
libs/cli/tests/unit_tests/test_deploy_helpers.py
+17 -7
View File
@@ -626,7 +626,9 @@ class TestSelectSource:
{"push_to": REPOSITORY},
True,
CustomerRegistrySource(
ImageReference(REPOSITORY, "latest"), prebuilt_image=None
reference=ImageReference(REPOSITORY, "latest"),
prebuilt_image=None,
placement=RequestedPlacement(),
),
id="push_to_selects_the_external_source_with_the_default_tag",
),
@@ -634,7 +636,9 @@ class TestSelectSource:
{"push_to": f"{REPOSITORY}:v2"},
True,
CustomerRegistrySource(
ImageReference(REPOSITORY, "v2"), prebuilt_image=None
reference=ImageReference(REPOSITORY, "v2"),
prebuilt_image=None,
placement=RequestedPlacement(),
),
id="push_to_keeps_a_tag_given_in_the_reference",
),
@@ -642,7 +646,9 @@ class TestSelectSource:
{"push_to": REPOSITORY, "tag": "v3"},
True,
CustomerRegistrySource(
ImageReference(REPOSITORY, "v3"), prebuilt_image=None
reference=ImageReference(REPOSITORY, "v3"),
prebuilt_image=None,
placement=RequestedPlacement(),
),
id="tag_flag_composes_with_push_to",
),
@@ -650,7 +656,9 @@ class TestSelectSource:
{"push_to": REPOSITORY, "image": "app:dev"},
False,
CustomerRegistrySource(
ImageReference(REPOSITORY, "latest"), prebuilt_image="app:dev"
reference=ImageReference(REPOSITORY, "latest"),
prebuilt_image="app:dev",
placement=RequestedPlacement(),
),
id="prebuilt_image_is_retagged_for_push_to_without_docker_checks",
),
@@ -661,9 +669,9 @@ class TestSelectSource:
},
True,
CustomerRegistrySource(
ImageReference(REPOSITORY, "latest"),
None,
RequestedPlacement("listener-1", "agents"),
reference=ImageReference(REPOSITORY, "latest"),
prebuilt_image=None,
placement=RequestedPlacement("listener-1", "agents"),
),
id="push_to_carries_the_requested_placement",
),
@@ -952,6 +960,8 @@ class TestListener:
Listener("listener-1", "", ()),
id="only_an_id",
),
pytest.param({"compute_id": "c"}, None, id="no_id_is_not_a_listener"),
pytest.param({"id": ""}, None, id="empty_id_is_not_a_listener"),
],
)
def test_from_resource_reads_the_control_plane_shape(self, resource, expected):