Reject --image-pull-secret when a --name lookup finds an existing deployment

--image-pull-secret was only guarded against an existing --deployment-id.
If --name (or the default name) resolved to an existing deployment instead,
CustomerRegistrySource._update silently dropped the secrets: the image
pull secret the user intended never reached the control plane and the
revision could fail with ImagePullBackOff with no warning.
This commit is contained in:
gdibben
2026-10-14 08:58:15 +01:00
parent a751d09a52
commit c4a5cb4d2f
2 changed files with 24 additions and 0 deletions
+7
View File
@@ -1682,6 +1682,13 @@ class CustomerRegistrySource:
) -> DeployOutcome:
_ensure_customer_registry_source(existing)
self.requested_placement.ensure_not_requested(existing.id)
if self.image_pull_secrets:
raise click.UsageError(
"Image pull secrets are fixed when a deployment is created. "
f"Deployment {existing.id} already exists, so drop "
"--image-pull-secret, or create a new deployment with a "
"different --name."
)
image_uri, step = self._publish(ctx, step)
_log_deploy_step(step, f"Updating deployment {existing.id}")
updated = ctx.client.update_deployment(