mirror of
https://github.com/langchain-ai/langgraph.git
synced 2026-08-17 21:25:46 +02:00
Elior Nataf LackritzandGitHub
ea5f9cc9fb
Follow-up to #8540, which turned on `PLC0415` (import-outside-top-level) for checkpoint-postgres and checkpoint-sqlite. This does the remaining six packages: checkpoint, checkpoint-conformance, langgraph, prebuilt, cli, sdk-py. Scoped to tests, per @sydney-runkle's call on #8540: library code is exempted with `per-file-ignores`, since it still has deferred imports nobody has reviewed and mixing that in would make this hard to read. ## What changed Function-level imports across 56 test files moved to module level. Nine could not move and carry an explicit `# noqa: PLC0415` with a reason: | File | Why it stays local | |---|---| | `libs/langgraph/tests/test_deprecation.py` (4) | the import has to run inside `pytest.warns` for the warning to be observed | | `libs/langgraph/tests/test_serde_allowlist.py` | try/except guard, skips when langchain_core is absent | | `libs/langgraph/tests/test_delta_channel_benchmark.py` | optional psycopg probe | | `libs/checkpoint/tests/test_conformance_delta.py` (3) | protected by a module-level `pytest.importorskip`; hoisting past the guard turns a skip into a collection error | That last one is the trap: an import moved above `pytest.importorskip` silently defeats the guard. I hit it locally and it turned the skip into a `ModuleNotFoundError` at collection. Every file with an `importorskip` or `except ImportError` was checked by hand for this. ## Verification `make lint` and `make test` in each of the six: | Package | Tests | |---|---| | checkpoint | 156 passed, 17 skipped | | checkpoint-conformance | 1 passed | | langgraph | 1968 passed, 4 skipped | | prebuilt | 284 passed | | cli | 336 passed | | sdk-py | 493 passed | Also confirmed the rule actually fires: a throwaway test file with a function-level import is flagged in all six packages, and the source exemption holds.
62 lines
2.3 KiB
Python
62 lines
2.3 KiB
Python
from __future__ import annotations
|
|
|
|
import httpx
|
|
|
|
from langgraph_sdk._async.http import HttpClient
|
|
from langgraph_sdk._async.stream import ScopedStreamHandle
|
|
from langgraph_sdk._async.threads import ThreadsClient
|
|
from streaming._events import custom_event, lifecycle_completed_event
|
|
from streaming._fake_server import FakeServer
|
|
|
|
|
|
async def test_extension_projection_yields_matching_custom_payloads():
|
|
fake = FakeServer()
|
|
fake.script(
|
|
[
|
|
custom_event(seq=1, name="progress", step=1),
|
|
custom_event(seq=2, name="metrics", tokens=12),
|
|
custom_event(seq=3, name="progress", step=2),
|
|
lifecycle_completed_event(seq=4),
|
|
]
|
|
)
|
|
transport = httpx.ASGITransport(app=fake.app)
|
|
async with httpx.AsyncClient(transport=transport, base_url="http://test") as raw:
|
|
threads = ThreadsClient(HttpClient(raw))
|
|
async with threads.stream(thread_id="t-1", assistant_id="agent") as thread:
|
|
await thread.run.start(input={})
|
|
payloads = [payload async for payload in thread.extensions["progress"]]
|
|
|
|
assert payloads == [
|
|
{"name": "progress", "step": 1},
|
|
{"name": "progress", "step": 2},
|
|
]
|
|
assert any(
|
|
"custom:progress" in body.get("channels", [])
|
|
for body in fake.stream_request_bodies
|
|
)
|
|
|
|
|
|
async def test_extension_projection_supports_namespace_scope_on_subgraph_handle():
|
|
fake = FakeServer()
|
|
fake.script(
|
|
[
|
|
custom_event(seq=1, name="progress", namespace=["worker:abc"], step=1),
|
|
custom_event(seq=2, name="progress", namespace=[], step=0),
|
|
lifecycle_completed_event(seq=3),
|
|
]
|
|
)
|
|
transport = httpx.ASGITransport(app=fake.app)
|
|
async with httpx.AsyncClient(transport=transport, base_url="http://test") as raw:
|
|
threads = ThreadsClient(HttpClient(raw))
|
|
async with threads.stream(thread_id="t-1", assistant_id="agent") as thread:
|
|
await thread.run.start(input={})
|
|
handle = ScopedStreamHandle(
|
|
thread=thread,
|
|
path=("worker:abc",),
|
|
graph_name="worker",
|
|
trigger_call_id=None,
|
|
)
|
|
payloads = [payload async for payload in handle.extensions["progress"]]
|
|
|
|
assert payloads == [{"name": "progress", "step": 1}]
|