mirror of
https://github.com/langchain-ai/langgraph.git
synced 2026-09-02 05:08:44 +02:00
Elior Nataf LackritzandGitHub
ea5f9cc9fb
Follow-up to #8540, which turned on `PLC0415` (import-outside-top-level) for checkpoint-postgres and checkpoint-sqlite. This does the remaining six packages: checkpoint, checkpoint-conformance, langgraph, prebuilt, cli, sdk-py. Scoped to tests, per @sydney-runkle's call on #8540: library code is exempted with `per-file-ignores`, since it still has deferred imports nobody has reviewed and mixing that in would make this hard to read. ## What changed Function-level imports across 56 test files moved to module level. Nine could not move and carry an explicit `# noqa: PLC0415` with a reason: | File | Why it stays local | |---|---| | `libs/langgraph/tests/test_deprecation.py` (4) | the import has to run inside `pytest.warns` for the warning to be observed | | `libs/langgraph/tests/test_serde_allowlist.py` | try/except guard, skips when langchain_core is absent | | `libs/langgraph/tests/test_delta_channel_benchmark.py` | optional psycopg probe | | `libs/checkpoint/tests/test_conformance_delta.py` (3) | protected by a module-level `pytest.importorskip`; hoisting past the guard turns a skip into a collection error | That last one is the trap: an import moved above `pytest.importorskip` silently defeats the guard. I hit it locally and it turned the skip into a `ModuleNotFoundError` at collection. Every file with an `importorskip` or `except ImportError` was checked by hand for this. ## Verification `make lint` and `make test` in each of the six: | Package | Tests | |---|---| | checkpoint | 156 passed, 17 skipped | | checkpoint-conformance | 1 passed | | langgraph | 1968 passed, 4 skipped | | prebuilt | 284 passed | | cli | 336 passed | | sdk-py | 493 passed | Also confirmed the rule actually fires: a throwaway test file with a function-level import is flagged in all six packages, and the source exemption holds.
70 lines
1.9 KiB
Python
70 lines
1.9 KiB
Python
"""`CronClient` against the integration API.
|
|
|
|
Covers create / search / delete (no `update` since the surface accepts a
|
|
sparse update and the round-trip is implicitly exercised by the others).
|
|
The schedule fires in the future so the cron is never executed during
|
|
the test; we tear it down before any tick can land.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import pytest
|
|
|
|
from langgraph_sdk._async.cron import CronClient
|
|
from langgraph_sdk._async.http import HttpClient
|
|
from langgraph_sdk._sync.cron import SyncCronClient
|
|
from langgraph_sdk._sync.http import SyncHttpClient
|
|
|
|
from .conftest import ASSISTANT_ID
|
|
|
|
pytestmark = pytest.mark.integration
|
|
|
|
|
|
def _async_crons(raw):
|
|
|
|
return CronClient(HttpClient(raw))
|
|
|
|
|
|
def _sync_crons(raw):
|
|
|
|
return SyncCronClient(SyncHttpClient(raw))
|
|
|
|
|
|
# Once a year, on Jan 1 at 00:00 UTC. Deterministic and well past any
|
|
# test runtime.
|
|
_DISTANT_SCHEDULE = "0 0 1 1 *"
|
|
|
|
|
|
async def test_crons_create_search_delete_async(async_threads) -> None:
|
|
_, raw = async_threads
|
|
crons = _async_crons(raw)
|
|
created = await crons.create(
|
|
ASSISTANT_ID,
|
|
schedule=_DISTANT_SCHEDULE,
|
|
input={"messages": [], "value": "init", "items": []},
|
|
metadata={"suite": "integration", "label": "crons-async"},
|
|
)
|
|
cron_id = created["cron_id"]
|
|
try:
|
|
results = await crons.search(limit=20)
|
|
assert any(c["cron_id"] == cron_id for c in results)
|
|
finally:
|
|
await crons.delete(cron_id)
|
|
|
|
|
|
def test_crons_create_search_delete_sync(sync_threads) -> None:
|
|
_, raw = sync_threads
|
|
crons = _sync_crons(raw)
|
|
created = crons.create(
|
|
ASSISTANT_ID,
|
|
schedule=_DISTANT_SCHEDULE,
|
|
input={"messages": [], "value": "init", "items": []},
|
|
metadata={"suite": "integration", "label": "crons-sync"},
|
|
)
|
|
cron_id = created["cron_id"]
|
|
try:
|
|
results = crons.search(limit=20)
|
|
assert any(c["cron_id"] == cron_id for c in results)
|
|
finally:
|
|
crons.delete(cron_id)
|