mirror of
https://github.com/langchain-ai/langgraph.git
synced 2026-08-29 11:19:54 +02:00
Elior Nataf LackritzandGitHub
ea5f9cc9fb
Follow-up to #8540, which turned on `PLC0415` (import-outside-top-level) for checkpoint-postgres and checkpoint-sqlite. This does the remaining six packages: checkpoint, checkpoint-conformance, langgraph, prebuilt, cli, sdk-py. Scoped to tests, per @sydney-runkle's call on #8540: library code is exempted with `per-file-ignores`, since it still has deferred imports nobody has reviewed and mixing that in would make this hard to read. ## What changed Function-level imports across 56 test files moved to module level. Nine could not move and carry an explicit `# noqa: PLC0415` with a reason: | File | Why it stays local | |---|---| | `libs/langgraph/tests/test_deprecation.py` (4) | the import has to run inside `pytest.warns` for the warning to be observed | | `libs/langgraph/tests/test_serde_allowlist.py` | try/except guard, skips when langchain_core is absent | | `libs/langgraph/tests/test_delta_channel_benchmark.py` | optional psycopg probe | | `libs/checkpoint/tests/test_conformance_delta.py` (3) | protected by a module-level `pytest.importorskip`; hoisting past the guard turns a skip into a collection error | That last one is the trap: an import moved above `pytest.importorskip` silently defeats the guard. I hit it locally and it turned the skip into a `ModuleNotFoundError` at collection. Every file with an `importorskip` or `except ImportError` was checked by hand for this. ## Verification `make lint` and `make test` in each of the six: | Package | Tests | |---|---| | checkpoint | 156 passed, 17 skipped | | checkpoint-conformance | 1 passed | | langgraph | 1968 passed, 4 skipped | | prebuilt | 284 passed | | cli | 336 passed | | sdk-py | 493 passed | Also confirmed the rule actually fires: a throwaway test file with a function-level import is flagged in all six packages, and the source exemption holds.
63 lines
1.6 KiB
Python
63 lines
1.6 KiB
Python
from dataclasses import dataclass
|
|
from typing import Any
|
|
|
|
import orjson
|
|
import pytest
|
|
from pydantic import BaseModel
|
|
|
|
from langgraph_sdk.client import _aencode_json
|
|
|
|
|
|
async def _serde_roundtrip(data: Any):
|
|
_, body = await _aencode_json(data)
|
|
return orjson.loads(body) # ty: ignore[invalid-argument-type]
|
|
|
|
|
|
async def test_serde_basic():
|
|
# Test basic serialization
|
|
data = {"key": "value", "number": 42}
|
|
assert await _serde_roundtrip(data) == data
|
|
|
|
|
|
async def test_serde_pydantic():
|
|
# Test serialization with Pydantic model (if available)
|
|
|
|
class TestModel(BaseModel):
|
|
name: str
|
|
age: int
|
|
|
|
model = TestModel(name="test", age=25)
|
|
result = await _serde_roundtrip(model)
|
|
assert result["name"] == "test"
|
|
assert result["age"] == 25
|
|
|
|
nested_result = await _serde_roundtrip({"data": model})
|
|
assert nested_result["data"]["name"] == "test"
|
|
assert nested_result["data"]["age"] == 25
|
|
|
|
|
|
async def test_serde_dataclass():
|
|
|
|
@dataclass
|
|
class TestDataClass:
|
|
name: str
|
|
age: int
|
|
|
|
data = TestDataClass(name="test", age=25)
|
|
result = await _serde_roundtrip(data)
|
|
assert result["name"] == "test"
|
|
assert result["age"] == 25
|
|
|
|
nested_result = await _serde_roundtrip({"data": data})
|
|
assert nested_result["data"]["name"] == "test"
|
|
assert nested_result["data"]["age"] == 25
|
|
|
|
|
|
async def test_serde_pydantic_cls_fails():
|
|
# Test that serialization fails gracefully for Pydantic model when not available
|
|
class TestModel(BaseModel):
|
|
name: str
|
|
|
|
with pytest.raises(TypeError, match="Type is not JSON serializable"):
|
|
await _serde_roundtrip({"foo": TestModel})
|