Files
langgraph/libs/sdk-py/tests/integration/test_cancel.py
T
Elior Nataf LackritzandGitHub ea5f9cc9fb chore: enforce PLC0415 in tests for the remaining packages (#8547)
Follow-up to #8540, which turned on `PLC0415` (import-outside-top-level)
for checkpoint-postgres and checkpoint-sqlite. This does the remaining
six packages: checkpoint, checkpoint-conformance, langgraph, prebuilt,
cli, sdk-py.

Scoped to tests, per @sydney-runkle's call on #8540: library code is
exempted with `per-file-ignores`, since it still has deferred imports
nobody has reviewed and mixing that in would make this hard to read.

## What changed

Function-level imports across 56 test files moved to module level. Nine
could not move and carry an explicit `# noqa: PLC0415` with a reason:

| File | Why it stays local |
|---|---|
| `libs/langgraph/tests/test_deprecation.py` (4) | the import has to run
inside `pytest.warns` for the warning to be observed |
| `libs/langgraph/tests/test_serde_allowlist.py` | try/except guard,
skips when langchain_core is absent |
| `libs/langgraph/tests/test_delta_channel_benchmark.py` | optional
psycopg probe |
| `libs/checkpoint/tests/test_conformance_delta.py` (3) | protected by a
module-level `pytest.importorskip`; hoisting past the guard turns a skip
into a collection error |

That last one is the trap: an import moved above `pytest.importorskip`
silently defeats the guard. I hit it locally and it turned the skip into
a `ModuleNotFoundError` at collection. Every file with an `importorskip`
or `except ImportError` was checked by hand for this.

## Verification

`make lint` and `make test` in each of the six:

| Package | Tests |
|---|---|
| checkpoint | 156 passed, 17 skipped |
| checkpoint-conformance | 1 passed |
| langgraph | 1968 passed, 4 skipped |
| prebuilt | 284 passed |
| cli | 336 passed |
| sdk-py | 493 passed |

Also confirmed the rule actually fires: a throwaway test file with a
function-level import is flagged in all six packages, and the source
exemption holds.
2026-08-07 09:40:18 -04:00

139 lines
4.4 KiB
Python

"""Mid-run cancellation via `runs.cancel(...)`."""
from __future__ import annotations
import asyncio
import contextlib
import threading
import time
from typing import Any
import pytest
from langgraph_sdk._async.http import HttpClient
from langgraph_sdk._async.runs import RunsClient
from langgraph_sdk._sync.http import SyncHttpClient
from langgraph_sdk._sync.runs import SyncRunsClient
from .conftest import ASSISTANT_ID
pytestmark = pytest.mark.integration
_CANCEL_GRACE_SECONDS = 10.0
async def _cancel_after_first_event(
runs_client: Any,
thread_id: str,
run_id_future: asyncio.Future[str],
) -> None:
run_id = await run_id_future
await asyncio.sleep(0.1)
with contextlib.suppress(Exception):
await runs_client.cancel(thread_id, run_id, wait=False)
async def test_cancel_async(async_threads) -> None:
threads, raw = async_threads
runs_client = RunsClient(HttpClient(raw))
async with threads.stream(assistant_id=ASSISTANT_ID) as thread:
run_id_future: asyncio.Future[str] = asyncio.get_running_loop().create_future()
start_result = await thread.run.start(
input={"messages": [], "value": "init", "items": []}
)
run_id = start_result.get("run_id")
assert run_id, f"run.start returned no run_id: {start_result!r}"
run_id_future.set_result(run_id)
canceller = asyncio.create_task(
_cancel_after_first_event(runs_client, thread.thread_id, run_id_future)
)
started = time.monotonic()
iteration_error: BaseException | None = None
try:
async for _snap in thread.values:
if time.monotonic() - started > _CANCEL_GRACE_SECONDS:
raise AssertionError(
f"values iterator did not terminate within "
f"{_CANCEL_GRACE_SECONDS}s of cancel"
)
except BaseException as err:
iteration_error = err
await canceller
persisted = await threads.get(thread.thread_id)
status = persisted.get("status")
assert iteration_error is None, (
f"values iterator raised after cancel: {iteration_error!r}"
)
assert status != "success", (
f"expected non-success terminal status after cancel, got {status!r}"
)
def _cancel_after_first_event_sync(
runs_client: Any,
thread_id: str,
run_id_event: threading.Event,
run_id_holder: dict[str, str],
) -> None:
run_id_event.wait(timeout=10.0)
run_id = run_id_holder.get("run_id")
if not run_id:
return
time.sleep(0.1)
with contextlib.suppress(Exception):
runs_client.cancel(thread_id, run_id, wait=False)
def test_cancel_sync(sync_threads) -> None:
threads, raw = sync_threads
runs_client = SyncRunsClient(SyncHttpClient(raw))
with threads.stream(assistant_id=ASSISTANT_ID) as thread:
run_id_event = threading.Event()
run_id_holder: dict[str, str] = {}
start_result = thread.run.start(
input={"messages": [], "value": "init", "items": []}
)
run_id = start_result.get("run_id")
assert run_id, f"run.start returned no run_id: {start_result!r}"
run_id_holder["run_id"] = run_id
run_id_event.set()
canceller = threading.Thread(
target=_cancel_after_first_event_sync,
args=(runs_client, thread.thread_id, run_id_event, run_id_holder),
daemon=True,
name="cancel-worker",
)
canceller.start()
started = time.monotonic()
iteration_error: BaseException | None = None
try:
for _snap in thread.values:
if time.monotonic() - started > _CANCEL_GRACE_SECONDS:
raise AssertionError(
f"values iterator did not terminate within "
f"{_CANCEL_GRACE_SECONDS}s of cancel"
)
except BaseException as err:
iteration_error = err
canceller.join(timeout=5)
persisted = threads.get(thread.thread_id)
status = persisted.get("status")
assert iteration_error is None, (
f"values iterator raised after cancel: {iteration_error!r}"
)
assert status != "success", (
f"expected non-success terminal status after cancel, got {status!r}"
)