mirror of
https://github.com/langchain-ai/langgraph.git
synced 2026-08-17 21:25:46 +02:00
Elior Nataf LackritzandGitHub
ea5f9cc9fb
Follow-up to #8540, which turned on `PLC0415` (import-outside-top-level) for checkpoint-postgres and checkpoint-sqlite. This does the remaining six packages: checkpoint, checkpoint-conformance, langgraph, prebuilt, cli, sdk-py. Scoped to tests, per @sydney-runkle's call on #8540: library code is exempted with `per-file-ignores`, since it still has deferred imports nobody has reviewed and mixing that in would make this hard to read. ## What changed Function-level imports across 56 test files moved to module level. Nine could not move and carry an explicit `# noqa: PLC0415` with a reason: | File | Why it stays local | |---|---| | `libs/langgraph/tests/test_deprecation.py` (4) | the import has to run inside `pytest.warns` for the warning to be observed | | `libs/langgraph/tests/test_serde_allowlist.py` | try/except guard, skips when langchain_core is absent | | `libs/langgraph/tests/test_delta_channel_benchmark.py` | optional psycopg probe | | `libs/checkpoint/tests/test_conformance_delta.py` (3) | protected by a module-level `pytest.importorskip`; hoisting past the guard turns a skip into a collection error | That last one is the trap: an import moved above `pytest.importorskip` silently defeats the guard. I hit it locally and it turned the skip into a `ModuleNotFoundError` at collection. Every file with an `importorskip` or `except ImportError` was checked by hand for this. ## Verification `make lint` and `make test` in each of the six: | Package | Tests | |---|---| | checkpoint | 156 passed, 17 skipped | | checkpoint-conformance | 1 passed | | langgraph | 1968 passed, 4 skipped | | prebuilt | 284 passed | | cli | 336 passed | | sdk-py | 493 passed | Also confirmed the rule actually fires: a throwaway test file with a function-level import is flagged in all six packages, and the source exemption holds.
53 lines
1.6 KiB
Python
53 lines
1.6 KiB
Python
"""WebSocket transport against the integration API."""
|
|
|
|
from __future__ import annotations
|
|
|
|
import pytest
|
|
|
|
from langgraph_sdk.stream.transport import (
|
|
ProtocolWebSocketTransport,
|
|
SyncProtocolWebSocketTransport,
|
|
)
|
|
|
|
from .conftest import ASSISTANT_ID, EXPECTED_TERMINAL_ITEMS
|
|
|
|
pytestmark = pytest.mark.integration
|
|
|
|
|
|
async def test_websocket_async(async_threads) -> None:
|
|
threads, _ = async_threads
|
|
async with threads.stream(
|
|
assistant_id=ASSISTANT_ID, transport="websocket"
|
|
) as thread:
|
|
assert isinstance(thread._transport, ProtocolWebSocketTransport)
|
|
|
|
await thread.run.start(input={"messages": [], "value": "init", "items": []})
|
|
|
|
snapshots: list[dict] = []
|
|
async for snap in thread.values:
|
|
snapshots.append(snap)
|
|
|
|
assert thread.interrupted, "expected interrupt over ws"
|
|
await thread.run.respond("yes")
|
|
|
|
final = await thread.output
|
|
assert final.get("items") == EXPECTED_TERMINAL_ITEMS
|
|
|
|
|
|
def test_websocket_sync(sync_threads) -> None:
|
|
threads, _ = sync_threads
|
|
with threads.stream(assistant_id=ASSISTANT_ID, transport="websocket") as thread:
|
|
assert isinstance(thread._transport, SyncProtocolWebSocketTransport)
|
|
|
|
thread.run.start(input={"messages": [], "value": "init", "items": []})
|
|
|
|
snapshots: list[dict] = []
|
|
for snap in thread.values:
|
|
snapshots.append(snap)
|
|
|
|
assert thread.interrupted, "expected interrupt over ws"
|
|
thread.run.respond("yes")
|
|
|
|
final = thread.output
|
|
assert final.get("items") == EXPECTED_TERMINAL_ITEMS
|