From 2801ece3580c9db17d30af8dc893f02b728cab9a Mon Sep 17 00:00:00 2001
From: Anthony LC <anthony.le-courric@mail.numerique.gouv.fr>
Date: Thu, 19 Mar 2026 13:31:03 +0100
Subject: [PATCH] =?UTF-8?q?=E2=99=BF=EF=B8=8F(frontend)=20change=20aria-la?=
 =?UTF-8?q?bel=20for=20help=20menu=20button?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The help menu button's aria-label was
previously "Open onboarding menu", which was not
accurate and could be confusing for screen reader
users. This commit updates the aria-label to
"Open help menu" to better reflect the button's
purpose and improve accessibility.
---
 .../apps/e2e/__tests__/app-impress/doc-tree.spec.ts    |  4 ++--
 .../apps/e2e/__tests__/app-impress/help.spec.ts        | 10 ++++------
 .../impress/src/features/help/components/HelpMenu.tsx  |  2 +-
 src/frontend/apps/impress/src/i18n/translations.json   |  2 +-
 4 files changed, 8 insertions(+), 10 deletions(-)

diff --git a/src/frontend/apps/e2e/__tests__/app-impress/doc-tree.spec.ts b/src/frontend/apps/e2e/__tests__/app-impress/doc-tree.spec.ts
index f3d0477c4..b0cbd1cf1 100644
--- a/src/frontend/apps/e2e/__tests__/app-impress/doc-tree.spec.ts
+++ b/src/frontend/apps/e2e/__tests__/app-impress/doc-tree.spec.ts
@@ -299,7 +299,7 @@ test.describe('Doc Tree', () => {
 
     await page.keyboard.press('Tab');
 
-    await expect(page.getByLabel('Open onboarding menu')).toBeFocused();
+    await expect(page.getByLabel('Open help menu')).toBeFocused();
 
     await page.keyboard.press('Tab');
 
@@ -309,7 +309,7 @@ test.describe('Doc Tree', () => {
 
     await page.keyboard.press('Shift+Tab');
 
-    await expect(page.getByLabel('Open onboarding menu')).toBeFocused();
+    await expect(page.getByLabel('Open help menu')).toBeFocused();
 
     await page.keyboard.press('Shift+Tab');
 
diff --git a/src/frontend/apps/e2e/__tests__/app-impress/help.spec.ts b/src/frontend/apps/e2e/__tests__/app-impress/help.spec.ts
index 707b6e146..f1922757c 100644
--- a/src/frontend/apps/e2e/__tests__/app-impress/help.spec.ts
+++ b/src/frontend/apps/e2e/__tests__/app-impress/help.spec.ts
@@ -27,7 +27,7 @@ test.describe('Help feature', () => {
       await expect(page.getByRole('button', { name: 'New doc' })).toBeVisible();
 
       await expect(
-        page.getByRole('button', { name: 'Open onboarding menu' }),
+        page.getByRole('button', { name: 'Open help menu' }),
       ).toBeHidden();
     });
 
@@ -43,7 +43,7 @@ test.describe('Help feature', () => {
         },
       });
 
-      await page.getByRole('button', { name: 'Open onboarding menu' }).click();
+      await page.getByRole('button', { name: 'Open help menu' }).click();
 
       await getMenuItem(page, 'Onboarding').click();
 
@@ -87,7 +87,7 @@ test.describe('Help feature', () => {
     });
 
     test('closes modal with Skip button', async ({ page }) => {
-      await page.getByRole('button', { name: 'Open onboarding menu' }).click();
+      await page.getByRole('button', { name: 'Open help menu' }).click();
       await getMenuItem(page, 'Onboarding').click();
 
       const modal = page.getByTestId('onboarding-modal');
@@ -107,9 +107,7 @@ test.describe('Help feature', () => {
       // switch to french
       await waitForLanguageSwitch(page, TestLanguage.French);
 
-      await page
-        .getByRole('button', { name: "Ouvrir le menu d'embarquement" })
-        .click();
+      await page.getByRole('button', { name: "Ouvrir le menu d'aide" }).click();
 
       await getMenuItem(page, 'Premiers pas').click();
 
diff --git a/src/frontend/apps/impress/src/features/help/components/HelpMenu.tsx b/src/frontend/apps/impress/src/features/help/components/HelpMenu.tsx
index f36207355..46c8d0603 100644
--- a/src/frontend/apps/impress/src/features/help/components/HelpMenu.tsx
+++ b/src/frontend/apps/impress/src/features/help/components/HelpMenu.tsx
@@ -60,7 +60,7 @@ export const HelpMenu = ({
         >
           <Box $direction="row" $align="center">
             <Button
-              aria-label={t('Open onboarding menu')}
+              aria-label={t('Open help menu')}
               color={colorButton || 'neutral'}
               variant="tertiary"
               iconPosition="left"
diff --git a/src/frontend/apps/impress/src/i18n/translations.json b/src/frontend/apps/impress/src/i18n/translations.json
index c8889667d..b3f1f79f3 100644
--- a/src/frontend/apps/impress/src/i18n/translations.json
+++ b/src/frontend/apps/impress/src/i18n/translations.json
@@ -905,7 +905,7 @@
       "Open Source": "Open Source",
       "Open document {{title}}": "Ouvrir le document {{title}}",
       "Open document: {{title}}": "Ouvrir le document : {{title}}",
-      "Open onboarding menu": "Ouvrir le menu d'embarquement",
+      "Open help menu": "Ouvrir le menu d'aide",
       "Open root document": "Ouvrir le document racine",
       "Open the document options": "Ouvrir les options du document",
       "Open the menu of actions for the document: {{title}}": "Ouvrir le menu des actions du document : {{title}}",