diff --git a/CHANGELOG.md b/CHANGELOG.md index 05838ae6a..7c28763a2 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -18,6 +18,7 @@ and this project adheres to ### Fixed - 🐛(frontend) analytic feature flags problem #1953 +- 🐛(frontend) fix home collapsing panel #1954 - 🐛(frontend) fix disabled color on icon Dropdown #1950 - 🐛(frontend) fix zIndex table of content #1949 diff --git a/src/frontend/apps/impress/src/features/docs/doc-tree/components/DocSubPageItem.tsx b/src/frontend/apps/impress/src/features/docs/doc-tree/components/DocSubPageItem.tsx index 9d9856ffd..bdd7fb633 100644 --- a/src/frontend/apps/impress/src/features/docs/doc-tree/components/DocSubPageItem.tsx +++ b/src/frontend/apps/impress/src/features/docs/doc-tree/components/DocSubPageItem.tsx @@ -71,7 +71,7 @@ export const DocSubPageItem = (props: TreeViewNodeProps) => { allChildren as TreeViewDataType[], ); treeContext?.treeData.setSelectedNode(createdDoc); - togglePanel(); + togglePanel({ type: 'mobile' }); }) .catch(console.error); } else { @@ -85,7 +85,7 @@ export const DocSubPageItem = (props: TreeViewNodeProps) => { node.open(); router.push(`/docs/${createdDoc.id}`); treeContext?.treeData.setSelectedNode(newDoc); - togglePanel(); + togglePanel({ type: 'mobile' }); } }; diff --git a/src/frontend/apps/impress/src/features/header/components/Header.tsx b/src/frontend/apps/impress/src/features/header/components/Header.tsx index d80bf536b..936708849 100644 --- a/src/frontend/apps/impress/src/features/header/components/Header.tsx +++ b/src/frontend/apps/impress/src/features/header/components/Header.tsx @@ -7,11 +7,11 @@ import { useConfig } from '@/core/config'; import { useCunninghamTheme } from '@/cunningham'; import { ButtonLogin } from '@/features/auth'; import { LanguagePicker } from '@/features/language'; +import { LeftPanelToggleMobile } from '@/features/left-panel'; import { useResponsiveStore } from '@/stores'; import { HEADER_HEIGHT } from '../conf'; -import { ButtonTogglePanel } from './ButtonTogglePanel'; import { Title } from './Title'; import { Waffle } from './Waffle'; @@ -46,7 +46,7 @@ export const Header = () => { var(--c--contextuals--border--surface--primary); `} > - {!isDesktop && } + {!isDesktop && } { > {isSmallMobile && ( - + )} {!isSmallMobile && logo?.src && ( diff --git a/src/frontend/apps/impress/src/features/left-panel/components/LefPanelTargetFilters.tsx b/src/frontend/apps/impress/src/features/left-panel/components/LefPanelTargetFilters.tsx index f83afee80..2df901298 100644 --- a/src/frontend/apps/impress/src/features/left-panel/components/LefPanelTargetFilters.tsx +++ b/src/frontend/apps/impress/src/features/left-panel/components/LefPanelTargetFilters.tsx @@ -7,14 +7,12 @@ import { Box, Icon, StyledLink, Text } from '@/components'; import { useCunninghamTheme } from '@/cunningham'; import { DocDefaultFilter } from '@/docs/doc-management'; import { useLeftPanelStore } from '@/features/left-panel'; -import { useResponsiveStore } from '@/stores'; export const LeftPanelTargetFilters = () => { const { t } = useTranslation(); const pathname = usePathname(); const searchParams = useSearchParams(); - const { isDesktop } = useResponsiveStore(); const { closePanel } = useLeftPanelStore(); const { colorsTokens, spacingsTokens } = useCunninghamTheme(); @@ -52,9 +50,7 @@ export const LeftPanelTargetFilters = () => { }; const handleFilterClick = () => { - if (!isDesktop) { - closePanel(); - } + closePanel({ type: 'mobile' }); }; return ( diff --git a/src/frontend/apps/impress/src/features/left-panel/components/LeftPanel.tsx b/src/frontend/apps/impress/src/features/left-panel/components/LeftPanel.tsx index 4ff92237e..72c59633b 100644 --- a/src/frontend/apps/impress/src/features/left-panel/components/LeftPanel.tsx +++ b/src/frontend/apps/impress/src/features/left-panel/components/LeftPanel.tsx @@ -1,5 +1,3 @@ -import { usePathname } from 'next/navigation'; -import { useEffect } from 'react'; import { useTranslation } from 'react-i18next'; import { createGlobalStyle, css } from 'styled-components'; @@ -26,15 +24,9 @@ export const LeftPanel = () => { const { t } = useTranslation(); const { spacingsTokens } = useCunninghamTheme(); - const { togglePanel, isPanelOpen, isPanelOpenMobile } = useLeftPanelStore(); + const { isPanelOpen, isPanelOpenMobile } = useLeftPanelStore(); const isPanelOpenState = isDesktop ? isPanelOpen : isPanelOpenMobile; - const pathname = usePathname(); - - useEffect(() => { - togglePanel(isDesktop); - }, [pathname, isDesktop, togglePanel]); - return ( <> {isDesktop && ( diff --git a/src/frontend/apps/impress/src/features/left-panel/components/LeftPanelCollapseButton.tsx b/src/frontend/apps/impress/src/features/left-panel/components/LeftPanelCollapseButton.tsx index 56b9d828f..dc11f914b 100644 --- a/src/frontend/apps/impress/src/features/left-panel/components/LeftPanelCollapseButton.tsx +++ b/src/frontend/apps/impress/src/features/left-panel/components/LeftPanelCollapseButton.tsx @@ -71,7 +71,7 @@ export const LeftPanelCollapseButton = () => { >