WEBDIENSTE/lasuite-docs
1
0
Fork 0
mirror of https://github.com/suitenumerique/docs.git synced 2026-09-17 23:28:01 +02:00
Code Issues Packages Projects Releases Wiki Activity

♻️(backend) rename DocumentViewset::_title_search in _search_title

Browse Source 
We rename the private method _title_search in _search_title in the
DocumentViewset for having the search methods prefixed with _search
This commit is contained in:
Manuel Raynaud
2026-05-27 17:41:38 +02:00
parent e85e7d6c65
commit b77f7ab6f4
3 changed files with 38 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/backend/core/tests/documents/test_api_documents_search.py
+8 -6
View File
@@ -142,8 +142,10 @@ def test_api_documents_search_fallback_on_search_list_sub_docs(
assert response.json() == mocked_response
@mock.patch("core.api.viewsets.DocumentViewSet._title_search")
def test_api_documents_search_indexer_crashes(mock_title_search, indexer_settings):
@mock.patch("core.api.viewsets.DocumentViewSet._search_using_database")
def test_api_documents_search_indexer_crashes(
mock_search_using_database, indexer_settings
):
"""
When indexer is configured but crashes -> falls back on title_search
"""
@@ -170,7 +172,7 @@ def test_api_documents_search_indexer_crashes(mock_title_search, indexer_setting
"previous": None,
"results": [{"title": "mocked title_search result"}],
}
mock_title_search.return_value = drf_response.Response(mocked_response)
mock_search_using_database.return_value = drf_response.Response(mocked_response)
parent = factories.DocumentFactory(title="parent", users=[user])
q = "alpha"
@@ -181,9 +183,9 @@ def test_api_documents_search_indexer_crashes(mock_title_search, indexer_setting
# the search endpoint did not crash
assert response.status_code == 200
# fallback on title_search
assert mock_title_search.call_count == 1
assert mock_title_search.call_args[0][0].GET.get("q") == q
assert mock_title_search.call_args[0][0].GET.get("path") == parent.path
assert mock_search_using_database.call_count == 1
assert mock_search_using_database.call_args[0][0].GET.get("q") == q
assert mock_search_using_database.call_args[0][0].GET.get("path") == parent.path
assert response.json() == mocked_response
src/backend/core/tests/documents/test_api_documents_search_feature_flag.py
+18 -18
View File
@@ -18,13 +18,13 @@ pytestmark = pytest.mark.django_db
@responses.activate
@mock.patch("core.api.viewsets.DocumentViewSet._title_search")
@mock.patch("core.api.viewsets.DocumentViewSet._search_with_indexer")
@mock.patch("core.api.viewsets.DocumentViewSet._search_using_database")
@mock.patch("core.api.viewsets.DocumentViewSet._search_using_indexer")
@pytest.mark.parametrize(
"activated_flags,"
"expected_search_type,"
"expected_search_with_indexer_called,"
"expected_title_search_called",
"expected_search_using_indexer_called,"
"expected_search_using_database_called",
[
([], SearchType.TITLE, False, True),
([FeatureFlag.FLAG_FIND_HYBRID_SEARCH], SearchType.HYBRID, True, False),
@@ -40,15 +40,15 @@ pytestmark = pytest.mark.django_db
([FeatureFlag.FLAG_FIND_FULL_TEXT_SEARCH], SearchType.FULL_TEXT, True, False),
],
)
@pytest.mark.usefixtures("indexer_settings")
# pylint: disable=too-many-arguments, too-many-positional-arguments
def test_api_documents_search_success( # noqa : PLR0913
mock_search_with_indexer,
mock_title_search,
mock_search_using_indexer,
mock_search_using_database,
activated_flags,
expected_search_type,
expected_search_with_indexer_called,
expected_title_search_called,
indexer_settings,
expected_search_using_indexer_called,
expected_search_using_database_called,
):
"""
Test that the API endpoint for searching documents returns a successful response
@@ -57,8 +57,8 @@ def test_api_documents_search_success( # noqa : PLR0913
"""
assert get_document_indexer() is not None
mock_search_with_indexer.return_value = HttpResponse()
mock_title_search.return_value = HttpResponse()
mock_search_using_indexer.return_value = HttpResponse()
mock_search_using_database.return_value = HttpResponse()
with override_flag(
FeatureFlag.FLAG_FIND_HYBRID_SEARCH,
@@ -74,17 +74,17 @@ def test_api_documents_search_success( # noqa : PLR0913
assert response.status_code == 200
if expected_search_with_indexer_called:
mock_search_with_indexer.assert_called_once()
if expected_search_using_indexer_called:
mock_search_using_indexer.assert_called_once()
assert (
mock_search_with_indexer.call_args.kwargs["search_type"]
mock_search_using_indexer.call_args.kwargs["search_type"]
== expected_search_type
)
else:
assert not mock_search_with_indexer.called
assert not mock_search_using_indexer.called
if expected_title_search_called:
if expected_search_using_database_called:
assert SearchType.TITLE == expected_search_type
mock_title_search.assert_called_once()
mock_search_using_database.assert_called_once()
else:
assert not mock_title_search.called
assert not mock_search_using_database.called