WEBDIENSTE/lasuite-messages
1
0
Fork 0
mirror of https://github.com/suitenumerique/messages.git synced 2026-09-29 05:04:59 +02:00
Code Issues Packages Projects Releases Wiki Activity

✨(api) Allow superuser+staff to view all mail domains in admin API

Browse Source 
- Add condition in MailDomainAdminViewSet.get_queryset() to return all domains
  when user is both superuser and staff
- Add comprehensive tests covering all user permission combinations:
  * superuser + staff: can see all domains
  * superuser only: cannot see all domains (empty list)
  * staff only: cannot see all domains (empty list)
  * staff with domain access: can only see accessible domains
- Maintain existing behavior for regular users and domain admins

This change ensures that superusers with staff privileges have full
administrative access to all mail domains through the admin API,
while maintaining proper access control for other user types.
This commit is contained in:
Sabrina Demagny
2025-07-10 15:45:44 +02:00
parent d3df815d1f
commit f3b5cccf5d
2 changed files with 79 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/backend/core/api/viewsets/maildomain.py
+3
View File
@@ -26,6 +26,9 @@ class MailDomainAdminViewSet(mixins.ListModelMixin, viewsets.GenericViewSet):
if not user or not user.is_authenticated:
return models.MailDomain.objects.none()
if user.is_superuser and user.is_staff:
return models.MailDomain.objects.all().order_by("name")
accessible_maildomain_ids = models.MailDomainAccess.objects.filter(
user=user, role=models.MailDomainAccessRoleChoices.ADMIN
).values_list("maildomain_id", flat=True)