From da44279425eac75d09b0f658f06cfb523d076c2a Mon Sep 17 00:00:00 2001 From: Marie PUPO JEAMMET Date: Wed, 29 Apr 2026 16:08:24 +0200 Subject: [PATCH] =?UTF-8?q?=F0=9F=90=9B(dimail)=20fix=20trailing=20slash?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Trailing slash are the worst. This caused dimail api to fail miserably. --- env.d/development/common.dist | 1 + .../tests/api/mailboxes/test_api_mailboxes_send_link.py | 2 +- src/backend/mailbox_manager/utils/dimail.py | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/env.d/development/common.dist b/env.d/development/common.dist index 6e013c85..7fbc0809 100644 --- a/env.d/development/common.dist +++ b/env.d/development/common.dist @@ -68,4 +68,5 @@ MbyqKyC6DAzv4jEEhHaN7oY= " # INTEROP +WEBMAIL_URL = "https://webmail.fr" MAIL_PROVISIONING_API_CREDENTIALS="bGFfcmVnaWU6cGFzc3dvcmQ=" # Dev and test key for dimail interop diff --git a/src/backend/mailbox_manager/tests/api/mailboxes/test_api_mailboxes_send_link.py b/src/backend/mailbox_manager/tests/api/mailboxes/test_api_mailboxes_send_link.py index 7d7b3c50..a57a0ace 100644 --- a/src/backend/mailbox_manager/tests/api/mailboxes/test_api_mailboxes_send_link.py +++ b/src/backend/mailbox_manager/tests/api/mailboxes/test_api_mailboxes_send_link.py @@ -171,7 +171,7 @@ def test_api_mailboxes__login_link_connexion_failed(dimail_token_ok): # pylint: # token response in fixtures responses.add( responses.POST, - f"{dimail_url}/domains/{mail_domain.name}/mailboxes/{mailbox.local_part}/code/", + f"{dimail_url}/domains/{mail_domain.name}/mailboxes/{mailbox.local_part}/code", body=ConnectionError(), ) diff --git a/src/backend/mailbox_manager/utils/dimail.py b/src/backend/mailbox_manager/utils/dimail.py index 0ae19687..5dfdbe8f 100644 --- a/src/backend/mailbox_manager/utils/dimail.py +++ b/src/backend/mailbox_manager/utils/dimail.py @@ -386,7 +386,7 @@ class DimailAPIClient: try: response = session.post( - f"{self.API_URL}/domains/{mailbox.domain.name}/mailboxes/{mailbox.local_part}/code/", + f"{self.API_URL}/domains/{mailbox.domain.name}/mailboxes/{mailbox.local_part}/code", json={"expires_in": 3600, "maxuse": 1}, headers=self._get_headers(), verify=True,