From 09f15c086545fea3601a9a9fc0e1eee8b8af01c7 Mon Sep 17 00:00:00 2001 From: ciregenz Date: Tue, 4 Aug 2026 20:59:44 -0700 Subject: [PATCH] [eric] browser: see into cross-origin iframes, which Chromium reports as pages not iframes --- electron/main.js | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/electron/main.js b/electron/main.js index 1816a2fc..00ec1299 100644 --- a/electron/main.js +++ b/electron/main.js @@ -3570,7 +3570,13 @@ function wireChildSessions(wc) { } if (method === 'Target.attachedToTarget') { const info = params.targetInfo || {}; - if (info.type !== 'iframe') return; + // A cross-origin OOPIF is reported as type 'page', NOT 'iframe'. Filtering on 'iframe' alone + // therefore discarded exactly the frames we most need to see into: an embedded comment box, a + // helpdesk widget, a checkout field. Measured on disqus.com, whose composer is a cross-origin + // iframe: perception returned textboxes=0, so no composer matching could have found it, and + // the site scored 0/2 on the editor-shape holdout reading as "no composer" when the truth was + // "we are blind in here". Accept both; everything else (workers, extensions) still drops. + if (info.type !== 'iframe' && info.type !== 'page') return; // The event's own sessionId is the PARENT session (empty = root frame). sessions.set(params.sessionId, { frameId: info.targetId,